[Notes] [Git][BuildStream/buildstream][jjardon/pycodestyle] 3 commits: WIP

[Javier Jardón <gitlab mg gitlab com>]

Title: GitLab

Javier Jardón pushed to branch jjardon/pycodestyle at BuildStream / buildstream

Commits:

• b92b7376
  by Javier Jardón at 2018-08-29T11:11:23Z

  WIP
  

• 10614190
  by Javier Jardón at 2018-08-29T11:11:23Z

  Use pycodestyle instead pep8
  
  pep8 package was renamed to pycodestyle to reduce confusion.
  

• bc4f4be5
  by Javier Jardón at 2018-08-29T11:11:23Z

  setup.cfg: Ignore W605 and W504 for now
  
  This is the current occurence:
  40      W605 invalid escape sequence '\s'
  75      W504 line break after binary operator
  

5 changed files:

• .gitlab-ci.yml
• buildstream/_ostree.py
• buildstream/element.py
• dev-requirements.txt
• setup.cfg

Changes:

.gitlab-ci.yml

---

...	...	@@ -71,6 +71,8 @@ source_dist:
71	71	- chown -R buildstream:buildstream buildstream
72	72	- cd buildstream
73	73
	74	+ - pip3 install pytest-codestyle
	75	+
74	76	# Run the tests from the source distribution, We run as a simple
75	77	# user to test for permission issues
76	78	- su buildstream -c 'python3 setup.py test --index-url invalid://uri --addopts --integration'
...	...	@@ -120,6 +122,8 @@ tests-unix:
120	122	# Unpack and get into dist/buildstream
121	123	- cd dist && ./unpack.sh && cd buildstream
122	124
	125	+ - pip3 install pytest-codestyle
	126	+
123	127	# Since the unix platform is required to run as root, no user change required
124	128	- python3 setup.py test --index-url invalid://uri --addopts --integration
125	129

buildstream/_ostree.py

---

...	...	@@ -34,7 +34,7 @@ from ._exceptions import BstError, ErrorDomain
34	34
35	35	# pylint: disable=wrong-import-position,wrong-import-order
36	36	gi.require_version('OSTree', '1.0')
37		-from gi.repository import GLib, Gio, OSTree # nopep8
	37	+from gi.repository import GLib, Gio, OSTree # noqa
38	38
39	39
40	40	# For users of this file, they must expect (except) it.

buildstream/element.py

---

...	...	@@ -1519,7 +1519,7 @@ class Element(Plugin):
1519	1519	utils._force_rmtree(rootdir)
1520	1520
1521	1521	with _signals.terminator(cleanup_rootdir), \
1522		- self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox: # nopep8
	1522	+ self.__sandbox(rootdir, output_file, output_file, self.__sandbox_config) as sandbox: # noqa
1523	1523
1524	1524	sandbox_vroot = sandbox.get_virtual_directory()
1525	1525

dev-requirements.txt

---

1	1	coverage == 4.4.0
2		-pep8
3	2	pylint == 2.1.1
4	3	pytest >= 3.7
	4	+pytest-codestyle
5	5	pytest-cov >= 2.5.0
6	6	pytest-datafiles
7	7	pytest-env
8		-pytest-pep8
9	8	pytest-pylint
10	9	pytest-xdist

setup.cfg

---

...	...	@@ -11,20 +11,10 @@ parentdir_prefix = BuildStream-
11	11	test=pytest
12	12
13	13	[tool:pytest]
14		-addopts = --verbose --basetemp ./tmp --pep8 --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
	14	+addopts = --verbose --basetemp ./tmp --codestyle --pylint --pylint-rcfile=.pylintrc --cov=buildstream --cov-config .coveragerc --durations=20
15	15	norecursedirs = tests/integration/project integration-cache tmp __pycache__ .eggs
16	16	python_files = tests/*/*.py
17		-pep8maxlinelength = 119
18		-pep8ignore =
19		- * E129
20		- * E125
21		- doc/source/conf.py ALL
22		- tmp/* ALL
23		- */lib/python3* ALL
24		- */bin/* ALL
25		- buildstream/_fuse/fuse.py ALL
26		- .eggs/* ALL
27		- *_pb2.py ALL
28		- *_pb2_grpc.py ALL
	17	+codestyle_max_line_length = 119
	18	+codestyle_ignore = E129 E125 W504 W605
29	19	env =
30	20	D:BST_TEST_SUITE=True

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.