[Notes] [Git][BuildStream/buildstream][coldtom/autotools-libtool] 86 com

Javier Jardón pushed to branch coldtom/autotools-libtool at BuildStream / buildstream

Commits:

c15cb951

by Tristan Van Berkom at 2018-08-20T10:19:03Z

setup.cfg: Add tests/integration/project to norecursedirs

This is causing pytest to try to import the recently added app1.py
from the pip related tests. This fails because it's not meant to be
imported outside of the sandbox environment.

372abed5

by Tristan Van Berkom at 2018-08-20T11:47:53Z

Merge branch 'tristan/exclude-project-py-from-tests' into 'master'

setup.cfg: Add tests/integration/project to norecursedirs

See merge request BuildStream/buildstream!682

1f88a1e9

by Jonathan Maw at 2018-08-20T12:36:02Z

Use ArtifactCache's get_cache_size when calculating the quota

It would have been more convenient to store the quota size in the
ArtifactCache, except that the scheduler needs the quota size and
doesn't have access to the ArtifactCache.

d9507a9e

by Jonathan Maw at 2018-08-20T12:36:02Z

Fix get_cache_size to store it in the ArtifactCache, not the context

a9b81dc4

by Jonathan Maw at 2018-08-20T12:36:02Z

artifactcache: Read and write cache size to disk

a67906e6
by Jonathan Maw at 2018-08-20T13:06:51Z
```
Add tests that cache size works
```

92e34ccd

by Jonathan Maw at 2018-08-20T16:27:18Z

Merge branch 'jonathan/cache-cache-size' into 'master'

Jonathan/cache cache size

See merge request BuildStream/buildstream!679

f1a619b5

by Jonathan Maw at 2018-08-20T16:34:03Z

CASCache: Fix cell-var-from-loop linting error

ba74a128

by Jonathan Maw at 2018-08-20T17:53:33Z

Merge branch 'jonathan/cascache-cell-var-from-loop' into 'master'

Jonathan/cascache cell var from loop

See merge request BuildStream/buildstream!686

18acd3ea

by Valentin David at 2018-08-21T08:44:34Z

Fix broken indentation after tracking.

Issue was introduced by 171e803f (include directive) and the fix was
found courtesy of @Qinusty. This fixes also the include
feature. Because elements are to be serialized, the included fragments
need to use copy_tree when loaded.

Related to #470.

6bd688cf

by Valentin David at 2018-08-21T08:44:34Z

buildstream/_includes.py: Fix caching of included fragments.

4cab18e3

by Qinusty at 2018-08-21T09:38:39Z

Merge branch 'valentindavid/fix-broken-indentation-after-track' into 'master'

Fix broken indentation after track

See merge request BuildStream/buildstream!622

f3fbdac0

by Jonathan Maw at 2018-08-21T11:33:34Z

Pipeline: Skip except_elements logic if no elements to except

3a4c147a

by Jonathan Maw at 2018-08-21T12:43:41Z

Merge branch 'jonathan/faster-except-elements' into 'master'

Pipeline: Skip except_elements logic if no elements to except

See merge request BuildStream/buildstream!688

d1bd8c0b

by Chandan Singh at 2018-08-21T12:46:57Z

.gitlab-ci.yml: Bump tags for testsuite images

These new images come with pinned versions of `pytest` and `pylint`:

- `pylint`: `== 2.1.1`
- `pytest`: `>= 3.7`

12d1cec2

by Chandan Singh at 2018-08-21T12:46:57Z

dev-requirements.txt: Pin versions of pytest and pylint

These packages should only be updated as a deliberate change and the
code should be tested with the new versions to ensure that the test
still pass.

Any future updates should also happen in sync with the
buildstream-docker-images repository so that the testsuite base images
also enforce the same restrictions for the development requirements.

Replaces https://gitlab.com/BuildStream/buildstream/merge_requests/684.

320b9562

by Tristan Van Berkom at 2018-08-21T13:57:00Z

Merge branch 'chandan/update-ci-tags' into 'master'

Restrict pylint/pytest versions and bump CI tags

See merge request BuildStream/buildstream!689

ef606229

by Josh Smith at 2018-08-21T14:49:57Z

plugin.py: Stop printing None for fatal-warnings

Providing warn with detail=None (default) will no longer print None when
a fatal warning is triggered.

d8256c74

by Qinusty at 2018-08-21T15:46:14Z

Merge branch 'Qinusty/598-fatal-warning-none-detail' into 'master'

Fatal warnings no longer print None when detail=None

See merge request BuildStream/buildstream!694

ab1caac1

by Chandan Singh at 2018-08-21T23:47:32Z

setup.py: Add fields required for publishing on PyPi

Fill out those fields in `setup.py` that are required for publishing a
package on PyPi.

Part of https://gitlab.com/BuildStream/buildstream/issues/587.

81278f84

by Tristan Van Berkom at 2018-08-22T05:23:33Z

Merge branch 'chandan/pypi-prep' into 'master'

setup.py: Add fields required for publishing on PyPi

See merge request BuildStream/buildstream!695

3d4e649d

by Tristan Van Berkom at 2018-08-22T05:24:42Z

_frontend/linuxapp.py: Fix special casing around desktop notification escape sequence

Now we allow the notification to happen on any TERM
which starts with 'xterm' or 'vte', and we only do it
if the VTE_VERSION is >= 4600, where we know for sure that
VTE will not print garbage on the terminal.

Fixes #385

c8bafb68

by Tristan Van Berkom at 2018-08-22T06:24:12Z

Merge branch 'tristan/notifications' into 'master'

_frontend/linuxapp.py: Fix special casing around desktop notification escape sequence

Closes #385

See merge request BuildStream/buildstream!692

eeaddbac

by William Salmon at 2018-08-22T08:05:28Z

Catch Non Numeric versions

This patch just displays a better message than the default stack trace
but dose not try to fix the problem. A further patch will be created but
it effects versioneer so may take longer to land as it may need to go
via versioneer mainline.

e15f5fa3

by William Salmon at 2018-08-22T08:05:28Z

Search for tags with the *.*.* patten for version

This has been done in a way that I hope might be able to be upstreamed
in to versioneer. This is not garanteed but it would be good if it
could be.

Please see https://github.com/warner/python-versioneer/pull/186 and
https://github.com/wsalmonct/python-versioneer/tree/feature/regexTags
for further details.

ff52ae18

by Will Salmon at 2018-08-22T09:33:04Z

Merge branch 'willsalmon/versionTagRegrex' into 'master'

Search for tags with the *.*.* patten for version

See merge request BuildStream/buildstream!601

f4e51cf1

by Sam Thursfield at 2018-08-22T10:38:41Z

Don't strip pathname from debug symbol files

When GDB looks for debug symbols it looks for the full path of the file
inside the configured debug-file-directory. For example, if the
debug-file-directory is set to a default of /usr/lib/debug, and you are
debugging /usr/bin/python3, GDB will look for its debug symbols at this
location: /usr/lib/debug/usr/bin/python3.

BuildStream has been putting all debug files inside /usr/lib/debug
under their $(basename), so in the above example GDB would fail to find
any debug symbols for /usr/bin/python3 because they would be in the
incorrect locatoin of /usr/lib/debug/python3.

5b79bbb7

by Tristan Van Berkom at 2018-08-22T11:39:32Z

Merge branch 'tristan/debug-symbols-location' into 'master'

Don't strip pathname from debug symbol files

See merge request BuildStream/buildstream!697

91d62d2f

by Chandan Singh at 2018-08-22T18:38:01Z

MANIFEST.in: Fix include for dev-requirements.txt

Currently, running any setuptools commands using `setup.py` generates a
warning like so:
        warning: manifest_maker: MANIFEST.in, line 21: unknown action 'dev-requirements.txt'

The syntax is invalid and got accidentally introduced in !637 but it's a
shame that this is not a warning and no obvious way to make it an error
if there are invalid things in MANIFEST.in file.

cd0775eb

by Chandan Singh at 2018-08-22T23:44:36Z

Merge branch 'chandan/fix-mainfest-dev-requirements' into 'master'

MANIFEST.in: Fix include for dev-requirements.txt

See merge request BuildStream/buildstream!704

b0d1aa83

by Tristan Van Berkom at 2018-08-23T05:54:05Z

_frontend/linuxapp.py: Fixing fallout from !693

When fixing terminal notifications, I had introduced a bug
with accesses to `os.environ` which triggered KeyError, this
patch fixes it.

2215859c

by Valentin David at 2018-08-23T06:40:19Z

Improve error message for deleted open workspaces

Fixes #576.

e37ac3bc

by Tristan Van Berkom at 2018-08-23T07:45:49Z

Merge branch 'valentindavid/inconsistant-workspace' into 'master'

Improve error message for deleted open workspaces

Closes #576

See merge request BuildStream/buildstream!703

2ac654a8

by Valentin David at 2018-08-23T08:02:50Z

Remove artifact extracts when artifact expires in cache

Fixes #561

176aa09f

by Tristan Van Berkom at 2018-08-23T09:10:51Z

Merge branch 'valentindavid/extract-expiry' into 'master'

Remove artifact extracts when artifact expires in cache

Closes #561

See merge request BuildStream/buildstream!685

f1e3f10f

by Mathieu Bridon at 2018-08-23T09:11:47Z

deps: Specify the minimum version required for blessings

Buildstream uses the Terminal.does_styling attribute, which was only
added in blessings 1.6.

Blessings helpfully returns an empty string when calling an nonexistent
attribute on the Terminal object, instead of failing.

Because Fedora has blessings 1.5, Buildstream thought that my terminal
couldn't handle styling, and just didn't print the status bar, silently.

Specifying the minimum version avoids this silent failure.

bea01531
by Tristan Van Berkom at 2018-08-23T09:14:40Z
```
.gitlab-ci.yml: Avoid running tests in post-merge
```

da19bcf1

by Tristan Van Berkom at 2018-08-23T09:14:40Z

README.rst: Removing the badges

Now that we only run pre-merge CI, it makes no sense to show a badge for
the coverage and pipeline status of the last run of master.

It would make sense to show a badge for the last pipeline which
was run for the last merge request that was merged to master, but
I don't see any feature to get that information.

8216ff8d

by Tristan Van Berkom at 2018-08-23T10:13:23Z

Merge branch 'tristan/reduce-gitlab-ci' into 'master'

.gitlab-ci.yml: Avoid running tests in post-merge

See merge request BuildStream/buildstream!709

56096b60

by Chandan Singh at 2018-08-24T02:12:03Z

.gitlab-ci.yml: Verify that source tarball installs correctly

Add a check to verify that the source distribution tarball that we
generate installs corrctly. It is useful to do this check as this is the
same tarball will be used when installing BuildStream via PyPI.

This check also happens indirectly in the coverage job where we install
BuildStream but this check makes it more explicit and will also cause
the CI to fail early if the tarball is not correct.

86e4729d

by Tristan Van Berkom at 2018-08-24T06:42:03Z

Merge branch 'chandan/ci-sdist-test' into 'master'

.gitlab-ci.yml: Verify that source tarball installs correctly

See merge request BuildStream/buildstream!720

d88568ef

by Valentin David at 2018-08-24T06:48:08Z

tests/integration/source-determinism.py: Use cli_integration.

f7ef151b

by Tristan Van Berkom at 2018-08-24T07:36:19Z

Merge branch 'valentindavid/cli_integration_source_determinism' into 'master'

tests/integration/source-determinism.py: Use cli_integration.

See merge request BuildStream/buildstream!715

fa476d79

by Tristan Van Berkom at 2018-08-24T07:55:43Z

tests/integration/project: Use the same alias for the alpine tarball

This makes the integration tests use the same 'alpine' alias for the
tests as we use in the examples, this avoids a redundant download
of an extra alpine tarball in integration tests.

This is a part of #603

255f9ee3

by Tristan Van Berkom at 2018-08-24T08:39:19Z

Merge branch 'tristan/avoid-redundant-alpine' into 'master'

tests/integration/project: Use the same alias for the alpine tarball

See merge request BuildStream/buildstream!722

e1ed09aa

by Jim MacArthur at 2018-08-24T09:51:27Z

element.py: chmod 777 directories if delete fails.

Staging may produce directories with less than 'rwx' permissions which
will cause tempfile to throw an exception on deleting the temporary
directory if not changed.

01fe504b

by James Ennis at 2018-08-24T09:51:27Z

tar tests: Add tarball which contains a read-only dir

a3755c9a

by James Ennis at 2018-08-24T09:51:27Z

tar.py: Add test for a tarball containing a read-only dir

1bfcca1a

by James Ennis at 2018-08-24T10:31:41Z

Merge branch 'jmac/tempfile-extraction-bug' into 'master'

Correct crash after staging tars with read-only directories

See merge request BuildStream/buildstream!713

744925f3

by James Ennis at 2018-08-24T10:34:57Z

HACKING.rst: Remove -k flag for individual tests as this is not required

dfee6d75

by James Ennis at 2018-08-24T11:15:45Z

Merge branch 'jennis/correct_HACKING' into 'master'

'-k' flag not needed to run individual tests

See merge request BuildStream/buildstream!714

923bfaec

by Chandan Singh at 2018-08-24T11:22:33Z

doc: Add instructions to install BuildStream via PyPI

Add instructions to install and update BuildStream python package via
PyPI, and also make it the recommended method.

Part of https://gitlab.com/BuildStream/buildstream/issues/587.

2c3a6ab8

by Chandan Singh at 2018-08-24T12:01:56Z

Merge branch 'chandan/pip-install-instructions' into 'master'

doc: Add instructions to install BuildStream via PyPI

See merge request BuildStream/buildstream!717

f4745600

by Josh Smith at 2018-08-24T12:20:05Z

setup.cfg: Show timing of the 20 slowest tests

This helps identifying what tests are slow or if the CI got stuck on
some of them

4c40a027

by Javier Jardón at 2018-08-24T13:04:41Z

Merge branch 'jjardon/ci_show_timings' into 'master'

.gitlab-ci.yml: Show timing of the 20 slowest tests

See merge request BuildStream/buildstream!716

0301f74e

by Benjamin Schubert at 2018-08-24T14:52:49Z

buildelement.py: remove double logging (again) as in #507

This was broken again by d14d8ee29b5fcaadcfd05934de71b46221243fcd,
this commits re-applies the fix from 12fea82e12a27eccb34ef4efbaa7c6874787eb4c

f991644c

by Qinusty at 2018-08-24T15:33:48Z

Merge branch 'bschubert15/fix-double-log' into 'master'

buildelement.py: remove double logging (again) as in #507

See merge request BuildStream/buildstream!730

f4c2bf19

by Phil Dawson at 2018-08-25T08:43:09Z

workspaces.rst: Move terminal sessions to doc/source/sessions-stored/

23b01f24

by Phil Dawson at 2018-08-25T08:43:09Z

workspaces.rst: fix note which is not rendering correctly

369bec0c

by Tristan Van Berkom at 2018-08-25T08:44:26Z

doc/source/developing/workspaces.rst: Some whitespace fixes

Some whitespace changes to follow the style regarding empty
lines between sections.

24cb3037

by Tristan Van Berkom at 2018-08-25T09:10:53Z

.gitignore: Ignore doc/source/sessions directory of generated html files

A preventative measure against people committing the generated
html files to the wrong location.

4f8fe977

by Tristan Van Berkom at 2018-08-25T09:10:53Z

HACKING.rst: Documenting the new "shell" configuration in the bst2html input file format

d819fb64

by Tristan Van Berkom at 2018-08-25T11:41:15Z

Merge branch 'tristan/fixup-workspace-docs' into 'master'

Fixing some fallout in the workspace documentation additions

Closes #553

See merge request BuildStream/buildstream!732

ba675863