GNOME.org
 

[Notes] [Git][BuildGrid/buildgrid][finn/separate-services] 4 commits: Added instance support to BuildGrid

Title: GitLab

finn pushed to branch finn/separate-services at BuildGrid / buildgrid

Commits:

29 changed files:

Changes:

  • buildgrid/_app/bots/temp_directory.py
    ... ... @@ -29,7 +29,7 @@ def work_temp_directory(context, lease):
    29 29 
         then uploads results back to CAS
    30 30 
         """
    31 31
    32 
    -    instance_name = context.instance_name
    32 
    +    parent = context.parent
    33 33 
         stub_bytestream = bytestream_pb2_grpc.ByteStreamStub(context.channel)
    34 34
    35 35 
         action_digest = remote_execution_pb2.Digest()
    ... ... @@ -37,12 +37,12 @@ def work_temp_directory(context, lease):
    37 37
    38 38 
         action = remote_execution_pb2.Action()
    39 39
    40 
    -    action = parse_to_pb2_from_fetch(action, stub_bytestream, action_digest, instance_name)
    40 
    +    action = parse_to_pb2_from_fetch(action, stub_bytestream, action_digest, parent)
    41 41
    42 42 
         with tempfile.TemporaryDirectory() as temp_dir:
    43 43
    44 44 
             command = remote_execution_pb2.Command()
    45 
    -        command = parse_to_pb2_from_fetch(command, stub_bytestream, action.command_digest, instance_name)
    45 
    +        command = parse_to_pb2_from_fetch(command, stub_bytestream, action.command_digest, parent)
    46 46
    47 47 
             arguments = "cd {} &&".format(temp_dir)
    48 48
    ... ... @@ -51,7 +51,7 @@ def work_temp_directory(context, lease):
    51 51
    52 52 
             context.logger.info(arguments)
    53 53
    54 
    -        write_fetch_directory(temp_dir, stub_bytestream, action.input_root_digest, instance_name)
    54 
    +        write_fetch_directory(temp_dir, stub_bytestream, action.input_root_digest, parent)
    55 55
    56 56 
             proc = subprocess.Popen(arguments,
    57 57 
                                     shell=True,
    ... ... @@ -75,7 +75,7 @@ def work_temp_directory(context, lease):
    75 75 
                 requests.append(remote_execution_pb2.BatchUpdateBlobsRequest.Request(
    76 76 
                     digest=digest, data=chunk))
    77 77
    78 
    -        request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=instance_name,
    78 
    +        request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=parent,
    79 79 
                                                                    requests=requests)
    80 80
    81 81 
             stub_cas = remote_execution_pb2_grpc.ContentAddressableStorageStub(context.channel)

  • buildgrid/_app/commands/cmd_bot.py
    ... ... @@ -35,7 +35,7 @@ from ..cli import pass_context
    35 35
    36 36
    37 37 
     @click.group(name='bot', short_help="Create and register bot clients.")
    38 
    -@click.option('--parent', type=click.STRING, default='bgd_test', show_default=True,
    38 
    +@click.option('--parent', type=click.STRING, default='main', show_default=True,
    39 39 
                   help="Targeted farm resource.")
    40 40 
     @click.option('--port', type=click.INT, default='50051', show_default=True,
    41 41 
                   help="Remote server's port number.")
    ... ... @@ -49,6 +49,7 @@ def cli(context, host, port, parent):
    49 49 
         context.logger = logging.getLogger(__name__)
    50 50 
         context.logger.info("Starting on port {}".format(port))
    51 51 
         context.channel = channel
    52 
    +    context.parent = parent
    52 53
    53 54 
         worker = Worker()
    54 55 
         worker.add_device(Device())
    ... ... @@ -75,14 +76,11 @@ def run_dummy(context):
    75 76
    76 77
    77 78 
     @cli.command('temp-directory', short_help="Runs commands in temp directory and uploads results.")
    78 
    -@click.option('--instance-name', type=click.STRING, default='testing', show_default=True,
    79 
    -              help="Targeted farm instance name.")
    80 79 
     @pass_context
    81 
    -def run_temp_directory(context, instance_name):
    80 
    +def run_temp_directory(context):
    82 81 
         """ Downloads files and command from CAS and runs
    83 82 
         in a temp directory, uploading result back to CAS
    84 83 
         """
    85 
    -    context.instance_name = instance_name
    86 84 
         try:
    87 85 
             b = bot.Bot(context.bot_session)
    88 86 
             b.session(temp_directory.work_temp_directory,

  • buildgrid/_app/commands/cmd_cas.py
    ... ... @@ -31,25 +31,26 @@ from ..cli import pass_context
    31 31
    32 32
    33 33 
     @click.group(name='cas', short_help="Interact with the CAS server.")
    34 
    +@click.option('--instance-name', type=click.STRING, default='main', show_default=True,
    35 
    +              help="Targeted farm instance name.")
    34 36 
     @click.option('--port', type=click.INT, default='50051', show_default=True,
    35 37 
                   help="Remote server's port number.")
    36 38 
     @click.option('--host', type=click.STRING, default='localhost', show_default=True,
    37 39 
                   help="Remote server's hostname.")
    38 40 
     @pass_context
    39 
    -def cli(context, host, port):
    41 
    +def cli(context, instance_name, host, port):
    40 42 
         context.logger = logging.getLogger(__name__)
    41 43 
         context.logger.info("Starting on port {}".format(port))
    42 44
    45 
    +    context.instance_name = instance_name
    43 46 
         context.channel = grpc.insecure_channel('{}:{}'.format(host, port))
    44 47 
         context.port = port
    45 48
    46 49
    47 50 
     @cli.command('upload-files', short_help="Upload files to the CAS server.")
    48 
    -@click.option('--instance-name', type=click.STRING, default='testing', show_default=True,
    49 
    -              help="Targeted farm instance name.")
    50 51 
     @click.argument('files', nargs=-1, type=click.File('rb'), required=True)
    51 52 
     @pass_context
    52 
    -def upload_files(context, files, instance_name):
    53 
    +def upload_files(context, files):
    53 54 
         stub = remote_execution_pb2_grpc.ContentAddressableStorageStub(context.channel)
    54 55
    55 56 
         requests = []
    ... ... @@ -58,7 +59,7 @@ def upload_files(context, files, instance_name):
    58 59 
             requests.append(remote_execution_pb2.BatchUpdateBlobsRequest.Request(
    59 60 
                 digest=create_digest(chunk), data=chunk))
    60 61
    61 
    -    request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=instance_name,
    62 
    +    request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=context.instance_name,
    62 63 
                                                                requests=requests)
    63 64
    64 65 
         context.logger.info("Sending: {}".format(request))
    ... ... @@ -67,11 +68,9 @@ def upload_files(context, files, instance_name):
    67 68
    68 69
    69 70 
     @cli.command('upload-dir', short_help="Upload a directory to the CAS server.")
    70 
    -@click.option('--instance-name', type=click.STRING, default='testing', show_default=True,
    71 
    -              help="Targeted farm instance name.")
    72 71 
     @click.argument('directory', nargs=1, type=click.Path(), required=True)
    73 72 
     @pass_context
    74 
    -def upload_dir(context, directory, instance_name):
    73 
    +def upload_dir(context, directory):
    75 74 
         context.logger.info("Uploading directory to cas")
    76 75 
         stub = remote_execution_pb2_grpc.ContentAddressableStorageStub(context.channel)
    77 76
    ... ... @@ -81,7 +80,7 @@ def upload_dir(context, directory, instance_name):
    81 80 
             requests.append(remote_execution_pb2.BatchUpdateBlobsRequest.Request(
    82 81 
                 digest=file_digest, data=chunk))
    83 82
    84 
    -    request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=instance_name,
    83 
    +    request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=context.instance_name,
    85 84 
                                                                requests=requests)
    86 85
    87 86 
         context.logger.info("Request:\n{}".format(request))

  • buildgrid/_app/commands/cmd_execute.py
    ... ... @@ -36,34 +36,35 @@ from ..cli import pass_context
    36 36
    37 37
    38 38 
     @click.group(name='execute', short_help="Execute simple operations.")
    39 
    +@click.option('--instance-name', type=click.STRING, default='main',
    40 
    +              show_default=True, help="Targeted farm instance name.")
    39 41 
     @click.option('--port', type=click.INT, default='50051', show_default=True,
    40 42 
                   help="Remote server's port number.")
    41 43 
     @click.option('--host', type=click.STRING, default='localhost', show_default=True,
    42 44 
                   help="Remote server's hostname.")
    43 45 
     @pass_context
    44 
    -def cli(context, host, port):
    46 
    +def cli(context, instance_name, host, port):
    45 47 
         context.logger = logging.getLogger(__name__)
    46 48 
         context.logger.info("Starting on port {}".format(port))
    47 49
    50 
    +    context.instance_name = instance_name
    48 51 
         context.channel = grpc.insecure_channel('{}:{}'.format(host, port))
    49 52 
         context.port = port
    50 53
    51 54
    52 55 
     @cli.command('request-dummy', short_help="Send a dummy action.")
    53 
    -@click.option('--instance-name', type=click.STRING, default='testing', show_default=True,
    54 
    -              help="Targeted farm instance name.")
    55 56 
     @click.option('--number', type=click.INT, default=1, show_default=True,
    56 57 
                   help="Number of request to send.")
    57 58 
     @click.option('--wait-for-completion', is_flag=True,
    58 59 
                   help="Stream updates until jobs are completed.")
    59 60 
     @pass_context
    60 
    -def request_dummy(context, number, instance_name, wait_for_completion):
    61 
    +def request_dummy(context, number, wait_for_completion):
    61 62 
         action_digest = remote_execution_pb2.Digest()
    62 63
    63 64 
         context.logger.info("Sending execution request...")
    64 65 
         stub = remote_execution_pb2_grpc.ExecutionStub(context.channel)
    65 66
    66 
    -    request = remote_execution_pb2.ExecuteRequest(instance_name=instance_name,
    67 
    +    request = remote_execution_pb2.ExecuteRequest(instance_name=context.instance_name,
    67 68 
                                                       action_digest=action_digest,
    68 69 
                                                       skip_cache_lookup=True)
    69 70
    ... ... @@ -98,7 +99,7 @@ def list_operations(context):
    98 99 
         context.logger.info("Getting list of operations")
    99 100 
         stub = operations_pb2_grpc.OperationsStub(context.channel)
    100 101
    101 
    -    request = operations_pb2.ListOperationsRequest()
    102 
    +    request = operations_pb2.ListOperationsRequest(name=context.instance_name)
    102 103
    103 104 
         response = stub.ListOperations(request)
    104 105
    ... ... @@ -115,7 +116,8 @@ def list_operations(context):
    115 116 
     @pass_context
    116 117 
     def wait_execution(context, operation_name):
    117 118 
         stub = remote_execution_pb2_grpc.ExecutionStub(context.channel)
    118 
    -    request = remote_execution_pb2.WaitExecutionRequest(name=operation_name)
    119 
    +    request = remote_execution_pb2.WaitExecutionRequest(instance_name=context.instance_name,
    120 
    +                                                        name=operation_name)
    119 121
    120 122 
         response = stub.WaitExecution(request)
    121 123
    ... ... @@ -124,8 +126,6 @@ def wait_execution(context, operation_name):
    124 126
    125 127
    126 128 
     @cli.command('command', short_help="Send a command to be executed.")
    127 
    -@click.option('--instance-name', type=click.STRING, default='testing', show_default=True,
    128 
    -              help="Targeted farm instance name.")
    129 129 
     @click.option('--output-file', nargs=2, type=(click.STRING, click.BOOL), multiple=True,
    130 130 
                   help="Tuple of expected output file and is-executeable flag.")
    131 131 
     @click.option('--output-directory', default='testing', show_default=True,
    ... ... @@ -133,7 +133,7 @@ def wait_execution(context, operation_name):
    133 133 
     @click.argument('input-root', nargs=1, type=click.Path(), required=True)
    134 134 
     @click.argument('commands', nargs=-1, type=click.STRING, required=True)
    135 135 
     @pass_context
    136 
    -def command(context, input_root, commands, output_file, output_directory, instance_name):
    136 
    +def command(context, input_root, commands, output_file, output_directory):
    137 137 
         stub = remote_execution_pb2_grpc.ExecutionStub(context.channel)
    138 138
    139 139 
         execute_command = remote_execution_pb2.Command()
    ... ... @@ -170,11 +170,11 @@ def command(context, input_root, commands, output_file, output_directory, instan
    170 170 
         requests.append(remote_execution_pb2.BatchUpdateBlobsRequest.Request(
    171 171 
             digest=action_digest, data=action.SerializeToString()))
    172 172
    173 
    -    request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=instance_name,
    173 
    +    request = remote_execution_pb2.BatchUpdateBlobsRequest(instance_name=context.instance_name,
    174 174 
                                                                requests=requests)
    175 175 
         remote_execution_pb2_grpc.ContentAddressableStorageStub(context.channel).BatchUpdateBlobs(request)
    176 176
    177 
    -    request = remote_execution_pb2.ExecuteRequest(instance_name=instance_name,
    177 
    +    request = remote_execution_pb2.ExecuteRequest(instance_name=context.instance_name,
    178 178 
                                                       action_digest=action_digest,
    179 179 
                                                       skip_cache_lookup=True)
    180 180 
         response = stub.Execute(request)
    ... ... @@ -201,7 +201,7 @@ def command(context, input_root, commands, output_file, output_directory, instan
    201 201 
                         raise
    202 202
    203 203 
             with open(path, 'wb+') as f:
    204 
    -            write_fetch_blob(f, stub, output_file_response.digest, instance_name)
    204 
    +            write_fetch_blob(f, stub, output_file_response.digest, context.instance_name)
    205 205
    206 206 
             if output_file_response.path in output_executeables:
    207 207 
                 st = os.stat(path)

  • buildgrid/_app/commands/cmd_server.py
    ... ... @@ -25,12 +25,12 @@ import logging
    25 25
    26 26 
     import click
    27 27
    28 
    -from buildgrid.server import build_grid_server
    28 
    +from buildgrid.server import buildgrid_server
    29 29 
     from buildgrid.server.cas.storage.disk import DiskStorage
    30 30 
     from buildgrid.server.cas.storage.lru_memory_cache import LRUMemoryCache
    31 31 
     from buildgrid.server.cas.storage.s3 import S3Storage
    32 32 
     from buildgrid.server.cas.storage.with_cache import WithCacheStorage
    33 
    -from buildgrid.server.execution.action_cache import ActionCache
    33 
    +from buildgrid.server.actioncache.storage import ActionCache
    34 34
    35 35 
     from ..cli import pass_context
    36 36
    ... ... @@ -45,6 +45,7 @@ def cli(context):
    45 45
    46 46
    47 47 
     @cli.command('start', short_help="Setup a new server instance.")
    48 
    +@click.argument('instances', nargs=-1, type=click.STRING)
    48 49 
     @click.option('--port', type=click.INT, default='50051', show_default=True,
    49 50 
                   help="The port number to be listened.")
    50 51 
     @click.option('--max-cached-actions', type=click.INT, default=50, show_default=True,
    ... ... @@ -67,7 +68,9 @@ def cli(context):
    67 68 
     @click.option('--cas-disk-directory', type=click.Path(file_okay=False, dir_okay=True, writable=True),
    68 69 
                   help="For --cas=disk, the folder to store CAS blobs in.")
    69 70 
     @pass_context
    70 
    -def start(context, port, max_cached_actions, allow_uar, cas, **cas_args):
    71 
    +def start(context, instances, port, max_cached_actions, allow_uar, cas, **cas_args):
    72 
    +    """ Starts a BuildGrid server.
    73 
    +    """
    71 74 
         context.logger.info("Starting on port {}".format(port))
    72 75
    73 76 
         cas_storage = _make_cas_storage(context, cas, cas_args)
    ... ... @@ -79,9 +82,13 @@ def start(context, port, max_cached_actions, allow_uar, cas, **cas_args):
    79 82 
         else:
    80 83 
             action_cache = ActionCache(cas_storage, max_cached_actions, allow_uar)
    81 84
    82 
    -    server = build_grid_server.BuildGridServer(port,
    83 
    -                                               cas_storage=cas_storage,
    84 
    -                                               action_cache=action_cache)
    85 
    +    if instances is None:
    86 
    +        instances = ['main']
    87 
    +
    88 
    +    server = buildgrid_server.BuildGridServer(port,
    89 
    +                                              instances,
    90 
    +                                              cas_storage=cas_storage,
    91 
    +                                              action_cache=action_cache)
    85 92 
         loop = asyncio.get_event_loop()
    86 93 
         try:
    87 94 
             server.start()

  • buildgrid/_exceptions.py
    ... ... @@ -39,9 +39,7 @@ class BgdError(Exception):
    39 39
    40 40 
     class ErrorDomain(Enum):
    41 41 
         SERVER = 1
    42 
    -    EXECUTION = 2
    43 
    -    WORKER = 3
    44 
    -    BOT = 4
    42 
    +    BOT = 2
    45 43
    46 44
    47 45 
     class ServerError(BgdError):
    ... ... @@ -49,16 +47,6 @@ class ServerError(BgdError):
    49 47 
             super().__init__(message, detail=detail, domain=ErrorDomain.SERVER, reason=reason)
    50 48
    51 49
    52 
    -class ExecutionError(BgdError):
    53 
    -    def __init__(self, message, detail=None, reason=None):
    54 
    -        super().__init__(message, detail=detail, domain=ErrorDomain.EXECUTION, reason=reason)
    55 
    -
    56 
    -
    57 
    -class WorkerError(BgdError):
    58 
    -    def __init__(self, message, detail=None, reason=None):
    59 
    -        super().__init__(message, detail=detail, domain=ErrorDomain.WORKER, reason=reason)
    60 
    -
    61 
    -
    62 50 
     class BotError(BgdError):
    63 51 
         def __init__(self, message, detail=None, reason=None):
    64 52 
             super().__init__(message, detail=detail, domain=ErrorDomain.BOT, reason=reason)

  • buildgrid/server/worker/__init__.py → buildgrid/server/actioncache/__init__.py

  • buildgrid/server/execution/action_cache_service.py → buildgrid/server/actioncache/service.py

  • buildgrid/server/execution/action_cache.py → buildgrid/server/actioncache/storage.py
    ... ... @@ -21,7 +21,7 @@ Implements an in-memory action Cache
    21 21 
     """
    22 22
    23 23
    24 
    -from ..cas.reference_cache import ReferenceCache
    24 
    +from ..referencestorage.storage import ReferenceCache
    25 25
    26 26
    27 27 
     class ActionCache(ReferenceCache):

  • buildgrid/server/bots/__init__.py

  • buildgrid/server/worker/bots_interface.py → buildgrid/server/bots/instance.py
    ... ... @@ -54,7 +54,8 @@ class BotsInterface:
    54 54 
                 pass
    55 55
    56 56 
             # Bot session name, selected by the server
    57 
    -        name = str(uuid.uuid4())
    57 
    +        name = "{}/{}".format(parent, str(uuid.uuid4()))
    58 
    +
    58 59 
             bot_session.name = name
    59 60
    60 61 
             self._bot_ids[name] = bot_id

  • buildgrid/server/worker/bots_service.py → buildgrid/server/bots/service.py
    ... ... @@ -33,14 +33,17 @@ from .._exceptions import InvalidArgumentError, OutofSyncError
    33 33
    34 34 
     class BotsService(bots_pb2_grpc.BotsServicer):
    35 35
    36 
    -    def __init__(self, instance):
    37 
    -        self._instance = instance
    36 
    +    def __init__(self, instances):
    37 
    +        self._instances = instances
    38 38 
             self.logger = logging.getLogger(__name__)
    39 39
    40 40 
         def CreateBotSession(self, request, context):
    41 41 
             try:
    42 
    -            return self._instance.create_bot_session(request.parent,
    43 
    -                                                     request.bot_session)
    42 
    +            parent = request.parent
    43 
    +            instance = self._get_instance(request.parent)
    44 
    +            return instance.create_bot_session(parent,
    45 
    +                                               request.bot_session)
    46 
    +
    44 47 
             except InvalidArgumentError as e:
    45 48 
                 self.logger.error(e)
    46 49 
                 context.set_details(str(e))
    ... ... @@ -50,8 +53,15 @@ class BotsService(bots_pb2_grpc.BotsServicer):
    50 53
    51 54 
         def UpdateBotSession(self, request, context):
    52 55 
             try:
    53 
    -            return self._instance.update_bot_session(request.name,
    54 
    -                                                     request.bot_session)
    56 
    +            names = request.name.split("/")
    57 
    +            # Operation name should be in format:
    58 
    +            # {instance/name}/{uuid}
    59 
    +            instance_name = ''.join(names[0:-1])
    60 
    +
    61 
    +            instance = self._get_instance(instance_name)
    62 
    +            return instance.update_bot_session(request.name,
    63 
    +                                               request.bot_session)
    64 
    +
    55 65 
             except InvalidArgumentError as e:
    56 66 
                 self.logger.error(e)
    57 67 
                 context.set_details(str(e))
    ... ... @@ -72,3 +82,10 @@ class BotsService(bots_pb2_grpc.BotsServicer):
    72 82 
         def PostBotEventTemp(self, request, context):
    73 83 
             context.set_code(grpc.StatusCode.UNIMPLEMENTED)
    74 84 
             return Empty()
    85 
    +
    86 
    +    def _get_instance(self, name):
    87 
    +        try:
    88 
    +            return self._instances[name]
    89 
    +
    90 
    +        except KeyError:
    91 
    +            raise InvalidArgumentError("Instance doesn't exist on server: {}".format(name))

  • buildgrid/server/cas/content_addressable_storage_service.py → buildgrid/server/buildgrid_instance.py
    ... ... @@ -14,37 +14,39 @@
    14 14
    15 15
    16 16 
     """
    17 
    -ContentAddressableStorageService
    17 
    +BuildGrid Instance
    18 18 
     ==================
    19 19
    20 
    -Implements the Content Addressable Storage API, which provides methods
    21 
    -to check for missing CAS blobs and update them in bulk.
    20 
    +An instance of the BuildGrid server.
    21 
    +
    22 
    +Contains scheduler, execution instance and an interface to the bots.
    22 23 
     """
    23 24
    24 
    -from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2 as re_pb2
    25 
    -from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2_grpc as re_pb2_grpc
    26 
    -
    27 
    -
    28 
    -class ContentAddressableStorageService(re_pb2_grpc.ContentAddressableStorageServicer):
    29 
    -
    30 
    -    def __init__(self, storage):
    31 
    -        self._storage = storage
    32 
    -
    33 
    -    def FindMissingBlobs(self, request, context):
    34 
    -        # Only one instance for now.
    35 
    -        storage = self._storage
    36 
    -        return re_pb2.FindMissingBlobsResponse(
    37 
    -            missing_blob_digests=storage.missing_blobs(request.blob_digests))
    38 
    -
    39 
    -    def BatchUpdateBlobs(self, request, context):
    40 
    -        # Only one instance for now.
    41 
    -        storage = self._storage
    42 
    -        requests = []
    43 
    -        for request_proto in request.requests:
    44 
    -            requests.append((request_proto.digest, request_proto.data))
    45 
    -        response = re_pb2.BatchUpdateBlobsResponse()
    46 
    -        for (digest, _), status in zip(requests, storage.bulk_update_blobs(requests)):
    47 
    -            response_proto = response.responses.add()
    48 
    -            response_proto.digest.CopyFrom(digest)
    49 
    -            response_proto.status.CopyFrom(status)
    50 
    -        return response
    25 
    +
    26 
    +import logging
    27 
    +
    28 
    +from .execution.execution_instance import ExecutionInstance
    29 
    +from .scheduler import Scheduler
    30 
    +from .worker.bots_interface import BotsInterface
    31 
    +
    32 
    +
    33 
    +class BuildGridInstance(ExecutionInstance, BotsInterface):
    34 
    +
    35 
    +    def __init__(self, action_cache=None, cas_storage=None):
    36 
    +        scheduler = Scheduler(action_cache)
    37 
    +
    38 
    +        self.logger = logging.getLogger(__name__)
    39 
    +
    40 
    +        ExecutionInstance.__init__(self, scheduler, cas_storage)
    41 
    +        BotsInterface.__init__(self, scheduler)
    42 
    +
    43 
    +    def stream_operation_updates(self, message_queue, operation_name):
    44 
    +        operation = message_queue.get()
    45 
    +        while not operation.done:
    46 
    +            yield operation
    47 
    +            operation = message_queue.get()
    48 
    +        yield operation
    49 
    +
    50 
    +    def cancel_operation(self, name):
    51 
    +        # TODO: Cancel leases
    52 
    +        raise NotImplementedError("Cancelled operations not supported")

  • buildgrid/server/build_grid_server.py → buildgrid/server/buildgrid_server.py
    ... ... @@ -29,35 +29,25 @@ from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_p
    29 29 
     from buildgrid._protos.google.devtools.remoteworkers.v1test2 import bots_pb2_grpc
    30 30 
     from buildgrid._protos.google.longrunning import operations_pb2_grpc
    31 31
    32 
    -from .cas.bytestream_service import ByteStreamService
    33 
    -from .cas.content_addressable_storage_service import ContentAddressableStorageService
    34 
    -from .execution.action_cache_service import ActionCacheService
    35 
    -from .execution.execution_service import ExecutionService
    36 
    -from .execution.operations_service import OperationsService
    37 
    -from .execution.execution_instance import ExecutionInstance
    32 
    +from .buildgrid_instance import BuildGridInstance
    33 
    +from .cas.service import ByteStreamService, ContentAddressableStorageService
    34 
    +from .actioncache.service import ActionCacheService
    35 
    +from .execution.service import ExecutionService
    36 
    +from .operations.service import OperationsService
    37 
    +from .execution.instance import ExecutionInstance
    38 38 
     from .scheduler import Scheduler
    39 
    -from .worker.bots_service import BotsService
    40 
    -from .worker.bots_interface import BotsInterface
    39 
    +from .bots.service import BotsService
    40 
    +from .bots.instance import BotsInterface
    41 41
    42 42
    43 43 
     class BuildGridServer:
    44 44
    45 
    -    def __init__(self, port='50051', max_workers=10, cas_storage=None, action_cache=None):
    45 
    +    def __init__(self, port='50051', instances=None, max_workers=10, action_cache=None, cas_storage=None):
    46 46 
             port = '[::]:{0}'.format(port)
    47 
    -        scheduler = Scheduler(action_cache)
    48 
    -        bots_interface = BotsInterface(scheduler)
    49 
    -        execution_instance = ExecutionInstance(scheduler, cas_storage)
    50 47
    51 48 
             self._server = grpc.server(futures.ThreadPoolExecutor(max_workers))
    52 49 
             self._server.add_insecure_port(port)
    53 50
    54 
    -        bots_pb2_grpc.add_BotsServicer_to_server(BotsService(bots_interface),
    55 
    -                                                 self._server)
    56 
    -        remote_execution_pb2_grpc.add_ExecutionServicer_to_server(ExecutionService(execution_instance),
    57 
    -                                                                  self._server)
    58 
    -        operations_pb2_grpc.add_OperationsServicer_to_server(OperationsService(execution_instance),
    59 
    -                                                             self._server)
    60 
    -
    61 51 
             if cas_storage is not None:
    62 52 
                 cas_service = ContentAddressableStorageService(cas_storage)
    63 53 
                 remote_execution_pb2_grpc.add_ContentAddressableStorageServicer_to_server(cas_service,
    ... ... @@ -69,6 +59,20 @@ class BuildGridServer:
    69 59 
                 remote_execution_pb2_grpc.add_ActionCacheServicer_to_server(action_cache_service,
    70 60 
                                                                             self._server)
    71 61
    62 
    +        buildgrid_instances = {}
    63 
    +        if not instances:
    64 
    +            buildgrid_instances["main"] = BuildGridInstance(action_cache, cas_storage)
    65 
    +        else:
    66 
    +            for name in instances:
    67 
    +                buildgrid_instances[name] = BuildGridInstance(action_cache, cas_storage)
    68 
    +
    69 
    +        bots_pb2_grpc.add_BotsServicer_to_server(BotsService(buildgrid_instances),
    70 
    +                                                 self._server)
    71 
    +        remote_execution_pb2_grpc.add_ExecutionServicer_to_server(ExecutionService(buildgrid_instances),
    72 
    +                                                                  self._server)
    73 
    +        operations_pb2_grpc.add_OperationsServicer_to_server(OperationsService(buildgrid_instances),
    74 
    +                                                             self._server)
    75 
    +
    72 76 
         def start(self):
    73 77 
             self._server.start()
    74 78

  • buildgrid/server/cas/bytestream_service.py → buildgrid/server/cas/service.py
    ... ... @@ -14,21 +14,47 @@
    14 14
    15 15
    16 16 
     """
    17 
    -ByteStreamService
    17 
    +CAS services
    18 18 
     ==================
    19 19
    20 
    -Implements the ByteStream API, which clients can use to read and write
    21 
    -CAS blobs.
    20 
    +Implements the Content Addressable Storage API and ByteStream API.
    22 21 
     """
    23 22
    23 
    +
    24 24 
     import grpc
    25 25
    26 26 
     from buildgrid._protos.google.bytestream import bytestream_pb2, bytestream_pb2_grpc
    27 27 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2 as re_pb2
    28 
    +from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2_grpc as re_pb2_grpc
    28 29
    29 30 
     from ...settings import HASH
    30 31
    31 32
    33 
    +class ContentAddressableStorageService(re_pb2_grpc.ContentAddressableStorageServicer):
    34 
    +
    35 
    +    def __init__(self, storage):
    36 
    +        self._storage = storage
    37 
    +
    38 
    +    def FindMissingBlobs(self, request, context):
    39 
    +        # Only one instance for now.
    40 
    +        storage = self._storage
    41 
    +        return re_pb2.FindMissingBlobsResponse(
    42 
    +            missing_blob_digests=storage.missing_blobs(request.blob_digests))
    43 
    +
    44 
    +    def BatchUpdateBlobs(self, request, context):
    45 
    +        # Only one instance for now.
    46 
    +        storage = self._storage
    47 
    +        requests = []
    48 
    +        for request_proto in request.requests:
    49 
    +            requests.append((request_proto.digest, request_proto.data))
    50 
    +        response = re_pb2.BatchUpdateBlobsResponse()
    51 
    +        for (digest, _), status in zip(requests, storage.bulk_update_blobs(requests)):
    52 
    +            response_proto = response.responses.add()
    53 
    +            response_proto.digest.CopyFrom(digest)
    54 
    +            response_proto.status.CopyFrom(status)
    55 
    +        return response
    56 
    +
    57 
    +
    32 58 
     class ByteStreamService(bytestream_pb2_grpc.ByteStreamServicer):
    33 59
    34 60 
         BLOCK_SIZE = 1 * 1024 * 1024  # 1 MB block size

  • buildgrid/server/execution/execution_instance.py → buildgrid/server/execution/instance.py
    ... ... @@ -56,12 +56,14 @@ class ExecutionInstance:
    56 56
    57 57 
         def get_operation(self, name):
    58 58 
             operation = self._scheduler.jobs.get(name)
    59 
    +
    59 60 
             if operation is None:
    60 61 
                 raise InvalidArgumentError("Operation name does not exist: {}".format(name))
    62 
    +
    61 63 
             else:
    62 64 
                 return operation.get_operation()
    63 65
    64 
    -    def list_operations(self, name, list_filter, page_size, page_token):
    66 
    +    def list_operations(self, list_filter, page_size, page_token):
    65 67 
             # TODO: Pages
    66 68 
             # Spec says number of pages and length of a page are optional
    67 69 
             return self._scheduler.get_operations()
    ... ... @@ -72,10 +74,6 @@ class ExecutionInstance:
    72 74 
             except KeyError:
    73 75 
                 raise InvalidArgumentError("Operation name does not exist: {}".format(name))
    74 76
    75 
    -    def cancel_operation(self, name):
    76 
    -        # TODO: Cancel leases
    77 
    -        raise NotImplementedError("Cancelled operations not supported")
    78 
    -
    79 77 
         def register_message_client(self, name, queue):
    80 78 
             try:
    81 79 
                 self._scheduler.register_client(name, queue)

  • buildgrid/server/execution/execution_service.py → buildgrid/server/execution/service.py
    ... ... @@ -35,23 +35,23 @@ from .._exceptions import InvalidArgumentError
    35 35
    36 36 
     class ExecutionService(remote_execution_pb2_grpc.ExecutionServicer):
    37 37
    38 
    -    def __init__(self, instance):
    38 
    +    def __init__(self, instances):
    39 39 
             self.logger = logging.getLogger(__name__)
    40 
    -        self._instance = instance
    40 
    +        self._instances = instances
    41 41
    42 42 
         def Execute(self, request, context):
    43 
    -        # Ignore request.instance_name for now
    44 
    -        # Have only one instance
    45 43 
             try:
    46 44 
                 message_queue = queue.Queue()
    47 
    -            operation = self._instance.execute(request.action_digest,
    48 
    -                                               request.skip_cache_lookup,
    49 
    -                                               message_queue)
    45 
    +            instance = self._get_instance(request.instance_name)
    46 
    +            operation = instance.execute(request.action_digest,
    47 
    +                                         request.skip_cache_lookup,
    48 
    +                                         message_queue)
    50 49
    51 
    -            context.add_callback(partial(self._remove_client, operation.name, message_queue))
    50 
    +            context.add_callback(partial(instance.unregister_message_client,
    51 
    +                                         operation.name, message_queue))
    52 52
    53 
    -            yield from self._stream_operation_updates(message_queue,
    54 
    -                                                      operation.name)
    53 
    +            yield from instance.stream_operation_updates(message_queue,
    54 
    +                                                         operation.name)
    55 55
    56 56 
             except InvalidArgumentError as e:
    57 57 
                 self.logger.error(e)
    ... ... @@ -59,23 +59,25 @@ class ExecutionService(remote_execution_pb2_grpc.ExecutionServicer):
    59 59 
                 context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
    60 60 
                 yield operations_pb2.Operation()
    61 61
    62 
    -        except NotImplementedError as e:
    63 
    -            self.logger.error(e)
    64 
    -            context.set_details(str(e))
    65 
    -            context.set_code(grpc.StatusCode.UNIMPLEMENTED)
    66 
    -            yield operations_pb2.Operation()
    67 
    -
    68 62 
         def WaitExecution(self, request, context):
    69 63 
             try:
    64 
    +            names = request.name.split("/")
    65 
    +
    66 
    +            # Operation name should be in format:
    67 
    +            # {instance/name}/{operation_id}
    68 
    +            instance_name = ''.join(names[0:-1])
    69 
    +
    70 70 
                 message_queue = queue.Queue()
    71 
    -            operation_name = request.name
    71 
    +            operation_name = names[-1]
    72 
    +            instance = self._get_instance(instance_name)
    72 73
    73 
    -            self._instance.register_message_client(operation_name, message_queue)
    74 
    +            instance.register_message_client(operation_name, message_queue)
    74 75
    75 
    -            context.add_callback(partial(self._remove_client, operation_name, message_queue))
    76 
    +            context.add_callback(partial(instance.unregister_message_client,
    77 
    +                                         operation_name, message_queue))
    76 78
    77 
    -            yield from self._stream_operation_updates(message_queue,
    78 
    -                                                      operation_name)
    79 
    +            yield from instance.stream_operation_updates(message_queue,
    80 
    +                                                         operation_name)
    79 81
    80 82 
             except InvalidArgumentError as e:
    81 83 
                 self.logger.error(e)
    ... ... @@ -83,12 +85,9 @@ class ExecutionService(remote_execution_pb2_grpc.ExecutionServicer):
    83 85 
                 context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
    84 86 
                 yield operations_pb2.Operation()
    85 87
    86 
    -    def _remove_client(self, operation_name, message_queue):
    87 
    -        self._instance.unregister_message_client(operation_name, message_queue)
    88 
    +    def _get_instance(self, name):
    89 
    +        try:
    90 
    +            return self._instances[name]
    88 91
    89 
    -    def _stream_operation_updates(self, message_queue, operation_name):
    90 
    -        operation = message_queue.get()
    91 
    -        while not operation.done:
    92 
    -            yield operation
    93 
    -            operation = message_queue.get()
    94 
    -        yield operation
    92 
    +        except KeyError:
    93 
    +            raise InvalidArgumentError("Instance doesn't exist on server: {}".format(name))

  • buildgrid/server/operations/__init__.py

  • buildgrid/server/execution/operations_service.py → buildgrid/server/operations/service.py
    ... ... @@ -23,6 +23,8 @@ import logging
    23 23
    24 24 
     import grpc
    25 25
    26 
    +from google.protobuf.empty_pb2 import Empty
    27 
    +
    26 28 
     from buildgrid._protos.google.longrunning import operations_pb2_grpc, operations_pb2
    27 29
    28 30 
     from .._exceptions import InvalidArgumentError
    ... ... @@ -30,42 +32,102 @@ from .._exceptions import InvalidArgumentError
    30 32
    31 33 
     class OperationsService(operations_pb2_grpc.OperationsServicer):
    32 34
    33 
    -    def __init__(self, instance):
    34 
    -        self._instance = instance
    35 
    +    def __init__(self, instances):
    36 
    +        self._instances = instances
    35 37 
             self.logger = logging.getLogger(__name__)
    36 38
    37 39 
         def GetOperation(self, request, context):
    38 40 
             try:
    39 
    -            return self._instance.get_operation(request.name)
    41 
    +            name = request.name
    42 
    +            operation_name = self._get_operation_name(name)
    43 
    +
    44 
    +            instance = self._get_instance(name)
    45 
    +
    46 
    +            operation = instance.get_operation(operation_name)
    47 
    +            operation.name = name
    48 
    +            return operation
    40 49
    41 50 
             except InvalidArgumentError as e:
    42 51 
                 self.logger.error(e)
    43 52 
                 context.set_details(str(e))
    44 53 
                 context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
    45 
    -            return operations_pb2.Operation()
    54 
    +
    55 
    +        return operations_pb2.Operation()
    46 56
    47 57 
         def ListOperations(self, request, context):
    48 
    -        return self._instance.list_operations(request.name,
    49 
    -                                              request.filter,
    58 
    +        try:
    59 
    +            # Name should be the collection name
    60 
    +            # Or in this case, the instance_name
    61 
    +            name = request.name
    62 
    +            instance = self._get_instance(name)
    63 
    +
    64 
    +            result = instance.list_operations(request.filter,
    50 65 
                                                   request.page_size,
    51 66 
                                                   request.page_token)
    52 67
    68 
    +            for operation in result.operations:
    69 
    +                operation.name = "{}/{}".format(name, operation.name)
    70 
    +
    71 
    +            return result
    72 
    +
    73 
    +        except InvalidArgumentError as e:
    74 
    +            self.logger.error(e)
    75 
    +            context.set_details(str(e))
    76 
    +            context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
    77 
    +
    78 
    +        return operations_pb2.ListOperationsResponse()
    79 
    +
    53 80 
         def DeleteOperation(self, request, context):
    54 81 
             try:
    55 
    -            return self._instance.delete_operation(request.name)
    82 
    +            name = request.name
    83 
    +            operation_name = self._get_operation_name(name)
    84 
    +
    85 
    +            instance = self._get_instance(name)
    86 
    +
    87 
    +            instance.delete_operation(operation_name)
    56 88
    57 89 
             except InvalidArgumentError as e:
    58 90 
                 self.logger.error(e)
    59 91 
                 context.set_details(str(e))
    60 92 
                 context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
    61 
    -            return operations_pb2.Operation()
    93 
    +
    94 
    +        return Empty()
    62 95
    63 96 
         def CancelOperation(self, request, context):
    64 97 
             try:
    65 
    -            return self._instance.cancel_operation(request.name)
    98 
    +            name = request.name
    99 
    +            operation_name = self._get_operation_name(name)
    100 
    +
    101 
    +            instance = self._get_instance(name)
    102 
    +
    103 
    +            instance.cancel_operation(operation_name)
    66 104
    67 105 
             except NotImplementedError as e:
    68 106 
                 self.logger.error(e)
    69 107 
                 context.set_details(str(e))
    70 108 
                 context.set_code(grpc.StatusCode.UNIMPLEMENTED)
    71 
    -            return operations_pb2.Operation()
    109 
    +
    110 
    +        except InvalidArgumentError as e:
    111 
    +            self.logger.error(e)
    112 
    +            context.set_details(str(e))
    113 
    +            context.set_code(grpc.StatusCode.INVALID_ARGUMENT)
    114 
    +
    115 
    +        return Empty()
    116 
    +
    117 
    +    def _get_operation_name(self, name):
    118 
    +        return name.split("/")[-1]
    119 
    +
    120 
    +    def _get_instance(self, name):
    121 
    +        try:
    122 
    +            names = name.split("/")
    123 
    +
    124 
    +            # Operation name should be in format:
    125 
    +            # {instance/name}/{operation_id}
    126 
    +            instance_name = ''.join(names[0:-1])
    127 
    +            if not instance_name:
    128 
    +                return self._instances[name]
    129 
    +
    130 
    +            return self._instances[instance_name]
    131 
    +
    132 
    +        except KeyError:
    133 
    +            raise InvalidArgumentError("Instance doesn't exist on server: {}".format(name))

  • buildgrid/server/referencestorage/__init__.py

  • buildgrid/server/cas/reference_storage_service.py → buildgrid/server/referencestorage/service.py

  • buildgrid/server/cas/reference_cache.py → buildgrid/server/referencestorage/storage.py

  • tests/action_cache.py
    ... ... @@ -17,8 +17,8 @@
    17 17
    18 18 
     import pytest
    19 19
    20 
    +from buildgrid.server.actioncache.storage import ActionCache
    20 21 
     from buildgrid.server.cas.storage import lru_memory_cache
    21 
    -from buildgrid.server.execution import action_cache
    22 22 
     from buildgrid.server._exceptions import NotFoundError
    23 23 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2
    24 24
    ... ... @@ -28,8 +28,8 @@ def cas():
    28 28 
         return lru_memory_cache.LRUMemoryCache(1024 * 1024)
    29 29
    30 30
    31 
    -def test_null_action_cache(cas):
    32 
    -    cache = action_cache.ActionCache(cas, 0)
    31 
    +def test_null_cas_action_cache(cas):
    32 
    +    cache = ActionCache(cas, 0)
    33 33
    34 34 
         action_digest1 = remote_execution_pb2.Digest(hash='alpha', size_bytes=4)
    35 35 
         dummy_result = remote_execution_pb2.ActionResult()
    ... ... @@ -39,8 +39,8 @@ def test_null_action_cache(cas):
    39 39 
             cache.get_action_result(action_digest1)
    40 40
    41 41
    42 
    -def test_action_cache_expiry(cas):
    43 
    -    cache = action_cache.ActionCache(cas, 2)
    42 
    +def test_expiry(cas):
    43 
    +    cache = ActionCache(cas, 2)
    44 44
    45 45 
         action_digest1 = remote_execution_pb2.Digest(hash='alpha', size_bytes=4)
    46 46 
         action_digest2 = remote_execution_pb2.Digest(hash='bravo', size_bytes=4)
    ... ... @@ -62,8 +62,8 @@ def test_action_cache_expiry(cas):
    62 62 
         assert cache.get_action_result(action_digest3) is not None
    63 63
    64 64
    65 
    -def test_action_cache_checks_cas(cas):
    66 
    -    cache = action_cache.ActionCache(cas, 50)
    65 
    +def test_checks_cas(cas):
    66 
    +    cache = ActionCache(cas, 50)
    67 67
    68 68 
         action_digest1 = remote_execution_pb2.Digest(hash='alpha', size_bytes=4)
    69 69 
         action_digest2 = remote_execution_pb2.Digest(hash='bravo', size_bytes=4)

  • tests/cas/test_services.py
    ... ... @@ -24,8 +24,8 @@ import pytest
    24 24 
     from buildgrid._protos.google.bytestream import bytestream_pb2
    25 25 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2 as re_pb2
    26 26 
     from buildgrid.server.cas.storage.storage_abc import StorageABC
    27 
    -from buildgrid.server.cas.bytestream_service import ByteStreamService
    28 
    -from buildgrid.server.cas.content_addressable_storage_service import ContentAddressableStorageService
    27 
    +from buildgrid.server.cas.service import ByteStreamService
    28 
    +from buildgrid.server.cas.service import ContentAddressableStorageService
    29 29 
     from buildgrid.settings import HASH
    30 30
    31 31

  • tests/integration/action_cache_service.py
    ... ... @@ -26,7 +26,8 @@ import pytest
    26 26
    27 27 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2
    28 28 
     from buildgrid.server.cas.storage import lru_memory_cache
    29 
    -from buildgrid.server.execution import action_cache, action_cache_service
    29 
    +from buildgrid.server.actioncache.storage import ActionCache
    30 
    +from buildgrid.server.actioncache.service import ActionCacheService
    30 31
    31 32
    32 33 
     # Can mock this
    ... ... @@ -42,11 +43,11 @@ def cas():
    42 43
    43 44 
     @pytest.fixture
    44 45 
     def cache(cas):
    45 
    -    yield action_cache.ActionCache(cas, 50)
    46 
    +    yield ActionCache(cas, 50)
    46 47
    47 48
    48 49 
     def test_simple_action_result(cache, context):
    49 
    -    service = action_cache_service.ActionCacheService(cache)
    50 
    +    service = ActionCacheService(cache)
    50 51 
         action_digest = remote_execution_pb2.Digest(hash='sample', size_bytes=4)
    51 52
    52 53 
         # Check that before adding the ActionResult, attempting to fetch it fails
    ... ... @@ -67,8 +68,8 @@ def test_simple_action_result(cache, context):
    67 68
    68 69
    69 70 
     def test_disabled_update_action_result(cache, context):
    70 
    -    disabled_push = action_cache.ActionCache(cas, 50, False)
    71 
    -    service = action_cache_service.ActionCacheService(disabled_push)
    71 
    +    disabled_push = ActionCache(cas, 50, False)
    72 
    +    service = ActionCacheService(disabled_push)
    72 73
    73 74 
         request = remote_execution_pb2.UpdateActionResultRequest()
    74 75 
         service.UpdateActionResult(request, context)

  • tests/integration/bots_service.py
    ... ... @@ -18,7 +18,6 @@
    18 18 
     # pylint: disable=redefined-outer-name
    19 19
    20 20 
     import copy
    21 
    -import uuid
    22 21 
     from unittest import mock
    23 22
    24 23 
     import grpc
    ... ... @@ -27,9 +26,10 @@ import pytest
    27 26
    28 27 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2
    29 28 
     from buildgrid._protos.google.devtools.remoteworkers.v1test2 import bots_pb2
    30 
    -from buildgrid.server import scheduler, job
    29 
    +from buildgrid.server import job, buildgrid_instance
    31 30 
     from buildgrid.server.job import LeaseState
    32 
    -from buildgrid.server.worker import bots_interface, bots_service
    31 
    +from buildgrid.server.bots.instance import BotsInterface
    32 
    +from buildgrid.server.bots.service import BotsService
    33 33
    34 34
    35 35 
     # GRPC context
    ... ... @@ -53,30 +53,28 @@ def bot_session():
    53 53
    54 54
    55 55 
     @pytest.fixture
    56 
    -def schedule():
    57 
    -    yield scheduler.Scheduler()
    56 
    +def buildgrid():
    57 
    +    yield buildgrid_instance.BuildGridInstance()
    58 58
    59 59
    60 60 
     @pytest.fixture
    61 61 
     def bots(schedule):
    62 
    -    yield bots_interface.BotsInterface(schedule)
    62 
    +    yield BotsInterface(schedule)
    63 63
    64 64
    65 65 
     # Instance to test
    66 66 
     @pytest.fixture
    67 
    -def instance(bots):
    68 
    -    yield bots_service.BotsService(bots)
    67 
    +def instance(buildgrid):
    68 
    +    instances = {"": buildgrid}
    69 
    +    yield BotsService.BotsService(instances)
    69 70
    70 71
    71 72 
     def test_create_bot_session(bot_session, context, instance):
    72 
    -    parent = 'rach'
    73 
    -    request = bots_pb2.CreateBotSessionRequest(parent=parent,
    74 
    -                                               bot_session=bot_session)
    73 
    +    request = bots_pb2.CreateBotSessionRequest(bot_session=bot_session)
    75 74
    76 75 
         response = instance.CreateBotSession(request, context)
    77 76
    78 77 
         assert isinstance(response, bots_pb2.BotSession)
    79 
    -    assert uuid.UUID(response.name, version=4)
    80 78 
         assert bot_session.bot_id == response.bot_id
    81 79
    82 80
    ... ... @@ -92,8 +90,7 @@ def test_create_bot_session_bot_id_fail(context, instance):
    92 90
    93 91
    94 92 
     def test_update_bot_session(bot_session, context, instance):
    95 
    -    request = bots_pb2.CreateBotSessionRequest(parent='',
    96 
    -                                               bot_session=bot_session)
    93 
    +    request = bots_pb2.CreateBotSessionRequest(bot_session=bot_session)
    97 94 
         bot = instance.CreateBotSession(request, context)
    98 95
    99 96 
         request = bots_pb2.UpdateBotSessionRequest(name=bot.name,
    ... ... @@ -106,8 +103,7 @@ def test_update_bot_session(bot_session, context, instance):
    106 103
    107 104
    108 105 
     def test_update_bot_session_zombie(bot_session, context, instance):
    109 
    -    request = bots_pb2.CreateBotSessionRequest(parent='',
    110 
    -                                               bot_session=bot_session)
    106 
    +    request = bots_pb2.CreateBotSessionRequest(bot_session=bot_session)
    111 107 
         bot = instance.CreateBotSession(request, context)
    112 108 
         # Update server with incorrect UUID by rotating it
    113 109 
         bot.name = bot.name[len(bot.name): 0]
    ... ... @@ -121,8 +117,7 @@ def test_update_bot_session_zombie(bot_session, context, instance):
    121 117
    122 118
    123 119 
     def test_update_bot_session_bot_id_fail(bot_session, context, instance):
    124 
    -    request = bots_pb2.UpdateBotSessionRequest(name='ana',
    125 
    -                                               bot_session=bot_session)
    120 
    +    request = bots_pb2.UpdateBotSessionRequest(bot_session=bot_session)
    126 121
    127 122 
         instance.UpdateBotSession(request, context)
    128 123
    ... ... @@ -131,17 +126,15 @@ def test_update_bot_session_bot_id_fail(bot_session, context, instance):
    131 126
    132 127 
     @pytest.mark.parametrize("number_of_jobs", [0, 1, 3, 500])
    133 128 
     def test_number_of_leases(number_of_jobs, bot_session, context, instance):
    134 
    -    request = bots_pb2.CreateBotSessionRequest(parent='',
    135 
    -                                               bot_session=bot_session)
    129 
    +    request = bots_pb2.CreateBotSessionRequest(bot_session=bot_session)
    136 130 
         # Inject work
    137 131 
         for _ in range(0, number_of_jobs):
    138 132 
             action_digest = remote_execution_pb2.Digest()
    139 
    -        instance._instance._scheduler.append_job(job.Job(action_digest))
    133 
    +        instance._instances[""].execute(action_digest, True)
    140 134
    141 135 
         response = instance.CreateBotSession(request, context)
    142 136
    143 137 
         assert len(response.leases) == number_of_jobs
    144 
    -    assert isinstance(response, bots_pb2.BotSession)
    145 138
    146 139
    147 140 
     def test_update_leases_with_work(bot_session, context, instance):
    ... ... @@ -149,7 +142,7 @@ def test_update_leases_with_work(bot_session, context, instance):
    149 142 
                                                    bot_session=bot_session)
    150 143 
         # Inject work
    151 144 
         action_digest = remote_execution_pb2.Digest(hash='gaff')
    152 
    -    instance._instance._scheduler.append_job(job.Job(action_digest))
    145 
    +    instance._instances[""].execute(action_digest, True)
    153 146
    154 147 
         response = instance.CreateBotSession(request, context)
    155 148
    ... ... @@ -159,7 +152,6 @@ def test_update_leases_with_work(bot_session, context, instance):
    159 152
    160 153 
         assert isinstance(response, bots_pb2.BotSession)
    161 154 
         assert response.leases[0].state == LeaseState.PENDING.value
    162 
    -    assert uuid.UUID(response.leases[0].id, version=4)
    163 155 
         assert response_action == action_digest
    164 156
    165 157
    ... ... @@ -172,7 +164,7 @@ def test_update_leases_work_complete(bot_session, context, instance):
    172 164
    173 165 
         # Inject work
    174 166 
         action_digest = remote_execution_pb2.Digest(hash='gaff')
    175 
    -    instance._instance._scheduler.append_job(job.Job(action_digest))
    167 
    +    instance._instances[""].execute(action_digest, True)
    176 168
    177 169 
         request = bots_pb2.UpdateBotSessionRequest(name=response.name,
    178 170 
                                                    bot_session=response)
    ... ... @@ -200,7 +192,7 @@ def test_work_rejected_by_bot(bot_session, context, instance):
    200 192 
                                                    bot_session=bot_session)
    201 193 
         # Inject work
    202 194 
         action_digest = remote_execution_pb2.Digest(hash='gaff')
    203 
    -    instance._instance._scheduler.append_job(job.Job(action_digest))
    195 
    +    instance._instances[""].execute(action_digest, True)
    204 196
    205 197 
         # Simulated the severed binding between client and server
    206 198 
         response = copy.deepcopy(instance.CreateBotSession(request, context))
    ... ... @@ -222,7 +214,8 @@ def test_work_out_of_sync_from_pending(state, bot_session, context, instance):
    222 214 
                                                    bot_session=bot_session)
    223 215 
         # Inject work
    224 216 
         action_digest = remote_execution_pb2.Digest(hash='gaff')
    225 
    -    instance._instance._scheduler.append_job(job.Job(action_digest))
    217 
    +    instance._instances[""].execute(action_digest, True)
    218 
    +
    226 219 
         # Simulated the severed binding between client and server
    227 220 
         response = copy.deepcopy(instance.CreateBotSession(request, context))
    228 221
    ... ... @@ -242,7 +235,8 @@ def test_work_out_of_sync_from_active(state, bot_session, context, instance):
    242 235 
                                                    bot_session=bot_session)
    243 236 
         # Inject work
    244 237 
         action_digest = remote_execution_pb2.Digest(hash='gaff')
    245 
    -    instance._instance._scheduler.append_job(job.Job(action_digest))
    238 
    +    instance._instances[""].execute(action_digest, True)
    239 
    +
    246 240 
         # Simulated the severed binding between client and server
    247 241 
         response = copy.deepcopy(instance.CreateBotSession(request, context))
    248 242
    ... ... @@ -268,7 +262,8 @@ def test_work_active_to_active(bot_session, context, instance):
    268 262 
                                                    bot_session=bot_session)
    269 263 
         # Inject work
    270 264 
         action_digest = remote_execution_pb2.Digest(hash='gaff')
    271 
    -    instance._instance._scheduler.append_job(job.Job(action_digest))
    265 
    +    instance._instances[""].execute(action_digest, True)
    266 
    +
    272 267 
         # Simulated the severed binding between client and server
    273 268 
         response = copy.deepcopy(instance.CreateBotSession(request, context))
    274 269

  • tests/integration/execution_service.py
    ... ... @@ -20,15 +20,19 @@
    20 20 
     import uuid
    21 21 
     from unittest import mock
    22 22
    23 
    +import grpc
    23 24 
     from grpc._server import _Context
    24 25 
     import pytest
    26 
    +from google.protobuf import any_pb2
    25 27
    26 28 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2
    27 29 
     from buildgrid._protos.google.longrunning import operations_pb2
    28 30
    29 
    -from buildgrid.server import scheduler, job
    31 
    +from buildgrid.server import job, buildgrid_instance
    30 32 
     from buildgrid.server.cas.storage import lru_memory_cache
    31 
    -from buildgrid.server.execution import action_cache, execution_instance, execution_service
    33 
    +from buildgrid.server.actioncache.storage import ActionCache
    34 
    +from buildgrid.server.execution.instance import ExecutionInstance
    35 
    +from buildgrid.server.execution.service import ExecutionService
    32 36
    33 37
    34 38 
     @pytest.fixture
    ... ... @@ -38,19 +42,21 @@ def context():
    38 42
    39 43
    40 44 
     @pytest.fixture(params=["action-cache", "no-action-cache"])
    41 
    -def execution(request):
    45 
    +def buildgrid(request):
    42 46 
         if request.param == "action-cache":
    43 47 
             storage = lru_memory_cache.LRUMemoryCache(1024 * 1024)
    44 
    -        cache = action_cache.ActionCache(storage, 50)
    45 
    -        schedule = scheduler.Scheduler(cache)
    46 
    -        return execution_instance.ExecutionInstance(schedule, storage)
    47 
    -    return execution_instance.ExecutionInstance(scheduler.Scheduler())
    48 
    +        cache = ActionCache(storage, 50)
    49 
    +
    50 
    +        return buildgrid_instance.BuildGridInstance(action_cache=cache,
    51 
    +                                                    cas_storage=storage)
    52 
    +    return buildgrid_instance.BuildGridInstance()
    48 53
    49 54
    50 55 
     # Instance to test
    51 56 
     @pytest.fixture
    52 
    -def instance(execution):
    53 
    -    yield execution_service.ExecutionService(execution)
    57 
    +def instance(buildgrid):
    58 
    +    instances = {"": buildgrid}
    59 
    +    yield ExecutionService(instances)
    54 60
    55 61
    56 62 
     @pytest.mark.parametrize("skip_cache_lookup", [True, False])
    ... ... @@ -72,23 +78,45 @@ def test_execute(skip_cache_lookup, instance, context):
    72 78 
         assert result.done is False
    73 79
    74 80
    75 
    -# def test_wait_execution(instance, context):
    76 
    -    # TODO: Figure out why next(response) hangs on the .get()
    77 
    -    # method when running in pytest.
    78 
    -#     action_digest = remote_execution_pb2.Digest()
    79 
    -#     action_digest.hash = 'zhora'
    81 
    +def test_wrong_execute_instance(instance, context):
    82 
    +    request = remote_execution_pb2.ExecuteRequest(instance_name='blade')
    83 
    +    response = instance.Execute(request, context)
    84 
    +
    85 
    +    next(response)
    86 
    +    context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)
    87 
    +
    88 
    +
    89 
    +def test_wait_execution(instance, buildgrid, context):
    90 
    +    action_digest = remote_execution_pb2.Digest()
    91 
    +    action_digest.hash = 'zhora'
    92 
    +
    93 
    +    j = job.Job(action_digest, None)
    94 
    +    j._operation.done = True
    95 
    +
    96 
    +    request = remote_execution_pb2.WaitExecutionRequest(name="{}/{}".format('', j.name))
    80 97
    81 
    -#     j = job.Job(action_digest, None)
    82 
    -#     j._operation.done = True
    98 
    +    buildgrid._scheduler.jobs[j.name] = j
    83 99
    84 
    -#     request = remote_execution_pb2.WaitExecutionRequest(name=j.name)
    100 
    +    action_result_any = any_pb2.Any()
    101 
    +    action_result = remote_execution_pb2.ActionResult()
    102 
    +    action_result_any.Pack(action_result)
    85 103
    86 
    -#     instance._instance._scheduler.jobs[j.name] = j
    104 
    +    j.update_execute_stage(job.ExecuteStage.COMPLETED)
    105 
    +
    106 
    +    response = instance.WaitExecution(request, context)
    107 
    +
    108 
    +    result = next(response)
    109 
    +
    110 
    +    assert isinstance(result, operations_pb2.Operation)
    111 
    +    metadata = remote_execution_pb2.ExecuteOperationMetadata()
    112 
    +    result.metadata.Unpack(metadata)
    113 
    +    assert metadata.stage == job.ExecuteStage.COMPLETED.value
    114 
    +    assert uuid.UUID(result.name, version=4)
    115 
    +    assert result.done is True
    87 116
    88 
    -#     action_result_any = any_pb2.Any()
    89 
    -#     action_result = remote_execution_pb2.ActionResult()
    90 
    -#     action_result_any.Pack(action_result)
    91 117
    92 
    -#     instance._instance._scheduler._update_execute_stage(j, job.ExecuteStage.COMPLETED)
    118 
    +def test_wrong_instance_wait_execution(instance, buildgrid, context):
    119 
    +    request = remote_execution_pb2.WaitExecutionRequest(name="blade")
    120 
    +    next(instance.WaitExecution(request, context))
    93 121
    94 
    -#     response = instance.WaitExecution(request, context)
    122 
    +    context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)

  • tests/integration/operations_service.py
    ... ... @@ -28,10 +28,14 @@ from google.protobuf import any_pb2
    28 28 
     from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_pb2
    29 29 
     from buildgrid._protos.google.longrunning import operations_pb2
    30 30
    31 
    -from buildgrid.server import scheduler
    31 
    +from buildgrid.server.builddrid_instance import BuildGridInstance
    32 32 
     from buildgrid.server._exceptions import InvalidArgumentError
    33 33
    34 
    -from buildgrid.server.execution import execution_instance, operations_service
    34 
    +from buildgrid.server.execution.instance import ExecutionInstance
    35 
    +from buildgrid.server.operations.service import OperationsService
    36 
    +
    37 
    +
    38 
    +instance_name = "blade"
    35 39
    36 40
    37 41 
     # Can mock this
    ... ... @@ -52,65 +56,80 @@ def execute_request():
    52 56
    53 57
    54 58 
     @pytest.fixture
    55 
    -def schedule():
    56 
    -    yield scheduler.Scheduler()
    57 
    -
    58 
    -
    59 
    -@pytest.fixture
    60 
    -def execution(schedule):
    61 
    -    yield execution_instance.ExecutionInstance(schedule)
    59 
    +def buildgrid():
    60 
    +    yield BuildGridInstance()
    62 61
    63 62
    64 63 
     # Instance to test
    65 64 
     @pytest.fixture
    66 
    -def instance(execution):
    67 
    -    yield operations_service.OperationsService(execution)
    65 
    +def instance(buildgrid):
    66 
    +    instances = {instance_name: buildgrid}
    67 
    +    yield OperationsService(instances)
    68 68
    69 69
    70 70 
     # Queue an execution, get operation corresponding to that request
    71 
    -def test_get_operation(instance, execute_request, context):
    72 
    -    response_execute = instance._instance.execute(execute_request.action_digest,
    73 
    -                                                  execute_request.skip_cache_lookup)
    71 
    +def test_get_operation(instance, buildgrid, execute_request, context):
    72 
    +    response_execute = buildgrid.execute(execute_request.action_digest,
    73 
    +                                         execute_request.skip_cache_lookup)
    74 74
    75 75 
         request = operations_pb2.GetOperationRequest()
    76 76
    77 
    -    request.name = response_execute.name
    77 
    +    request.name = "{}/{}".format(instance_name, response_execute.name)
    78 78
    79 79 
         response = instance.GetOperation(request, context)
    80 80 
         assert response is response_execute
    81 81
    82 82
    83 83 
     def test_get_operation_fail(instance, context):
    84 
    +    request = operations_pb2.GetOperationRequest()
    85 
    +    request.name = "{}/{}".format(instance_name, "runner")
    86 
    +    instance.GetOperation(request, context)
    87 
    +
    88 
    +    context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)
    89 
    +
    90 
    +
    91 
    +def test_get_operation_instance_fail(instance, context):
    84 92 
         request = operations_pb2.GetOperationRequest()
    85 93 
         instance.GetOperation(request, context)
    86 94
    87 95 
         context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)
    88 96
    89 97
    90 
    -def test_list_operations(instance, execute_request, context):
    91 
    -    response_execute = instance._instance.execute(execute_request.action_digest,
    92 
    -                                                  execute_request.skip_cache_lookup)
    98 
    +def test_list_operations(instance, buildgrid, execute_request, context):
    99 
    +    response_execute = buildgrid.execute(execute_request.action_digest,
    100 
    +                                         execute_request.skip_cache_lookup)
    93 101
    94 
    -    request = operations_pb2.ListOperationsRequest()
    102 
    +    request = operations_pb2.ListOperationsRequest(name=instance_name)
    95 103 
         response = instance.ListOperations(request, context)
    96 104
    97 
    -    assert response.operations[0].name == response_execute.name
    105 
    +    assert response.operations[0].name.split('/')[-1] == response_execute.name
    106 
    +
    98 107
    108 
    +def test_list_operations_instance_fail(instance, buildgrid, execute_request, context):
    109 
    +    buildgrid.execute(execute_request.action_digest,
    110 
    +                      execute_request.skip_cache_lookup)
    99 111
    100 
    -def test_list_operations_with_result(instance, execute_request, context):
    101 
    -    response_execute = instance._instance.execute(execute_request.action_digest,
    102 
    -                                                  execute_request.skip_cache_lookup)
    112 
    +    request = operations_pb2.ListOperationsRequest()
    113 
    +    instance.ListOperations(request, context)
    114 
    +
    115 
    +    context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)
    116 
    +
    117 
    +
    118 
    +def test_list_operations_with_result(instance, buildgrid, execute_request, context):
    119 
    +    response_execute = buildgrid.execute(execute_request.action_digest,
    120 
    +                                         execute_request.skip_cache_lookup)
    103 121
    104 122 
         action_result = remote_execution_pb2.ActionResult()
    105 123 
         output_file = remote_execution_pb2.OutputFile(path='unicorn')
    106 124 
         action_result.output_files.extend([output_file])
    107 125
    108 
    -    instance._instance._scheduler.job_complete(response_execute.name, _pack_any(action_result))
    126 
    +    buildgrid._scheduler.job_complete(response_execute.name,
    127 
    +                                      _pack_any(action_result))
    109 128
    110 
    -    request = operations_pb2.ListOperationsRequest()
    129 
    +    request = operations_pb2.ListOperationsRequest(name=instance_name)
    111 130 
         response = instance.ListOperations(request, context)
    112 131
    113 
    -    assert response.operations[0].name == response_execute.name
    132 
    +    assert response.operations[0].name.split('/')[-1] == response_execute.name
    114 133
    115 134 
         execute_response = remote_execution_pb2.ExecuteResponse()
    116 135 
         response.operations[0].response.Unpack(execute_response)
    ... ... @@ -118,7 +137,7 @@ def test_list_operations_with_result(instance, execute_request, context):
    118 137
    119 138
    120 139 
     def test_list_operations_empty(instance, context):
    121 
    -    request = operations_pb2.ListOperationsRequest()
    140 
    +    request = operations_pb2.ListOperationsRequest(name=instance_name)
    122 141
    123 142 
         response = instance.ListOperations(request, context)
    124 143
    ... ... @@ -126,21 +145,23 @@ def test_list_operations_empty(instance, context):
    126 145
    127 146
    128 147 
     # Send execution off, delete, try to find operation should fail
    129 
    -def test_delete_operation(instance, execute_request, context):
    130 
    -    response_execute = instance._instance.execute(execute_request.action_digest,
    131 
    -                                                  execute_request.skip_cache_lookup)
    148 
    +def test_delete_operation(instance, buildgrid, execute_request, context):
    149 
    +    response_execute = buildgrid.execute(execute_request.action_digest,
    150 
    +                                         execute_request.skip_cache_lookup)
    132 151 
         request = operations_pb2.DeleteOperationRequest()
    133 
    -    request.name = response_execute.name
    152 
    +    request.name = "{}/{}".format(instance_name, response_execute.name)
    134 153 
         instance.DeleteOperation(request, context)
    135 154
    136 155 
         request = operations_pb2.GetOperationRequest()
    137 
    -    request.name = response_execute.name
    156 
    +    request.name = "{}/{}".format(instance_name, response_execute.name)
    157 
    +
    138 158 
         with pytest.raises(InvalidArgumentError):
    139 
    -        instance._instance.get_operation(response_execute.name)
    159 
    +        buildgrid.get_operation(response_execute.name)
    140 160
    141 161
    142 
    -def test_delete_operation_fail(instance, execute_request, context):
    162 
    +def test_delete_operation_fail(instance, context):
    143 163 
         request = operations_pb2.DeleteOperationRequest()
    164 
    +    request.name = "{}/{}".format(instance_name, "runner")
    144 165 
         instance.DeleteOperation(request, context)
    145 166
    146 167 
         context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)
    ... ... @@ -148,11 +169,19 @@ def test_delete_operation_fail(instance, execute_request, context):
    148 169
    149 170 
     def test_cancel_operation(instance, context):
    150 171 
         request = operations_pb2.CancelOperationRequest()
    172 
    +    request.name = "{}/{}".format(instance_name, "runner")
    151 173 
         instance.CancelOperation(request, context)
    152 174
    153 175 
         context.set_code.assert_called_once_with(grpc.StatusCode.UNIMPLEMENTED)
    154 176
    155 177
    178 
    +def test_cancel_operation_instance_fail(instance, context):
    179 
    +    request = operations_pb2.CancelOperationRequest()
    180 
    +    instance.CancelOperation(request, context)
    181 
    +
    182 
    +    context.set_code.assert_called_once_with(grpc.StatusCode.INVALID_ARGUMENT)
    183 
    +
    184 
    +
    156 185 
     def _pack_any(pack):
    157 186 
         some_any = any_pb2.Any()
    158 187 
         some_any.Pack(pack)

  • tests/integration/reference_storage_service.py
    ... ... @@ -25,7 +25,8 @@ from buildgrid._protos.build.bazel.remote.execution.v2 import remote_execution_p
    25 25 
     from buildgrid._protos.buildstream.v2 import buildstream_pb2
    26 26
    27 27 
     from buildgrid.server.cas.storage import lru_memory_cache
    28 
    -from buildgrid.server.cas import reference_cache, reference_storage_service
    28 
    +from buildgrid.server.referencestorage.service import ReferenceStorageService
    29 
    +from buildgrid.server.referencestorage.storage import ReferenceCache
    29 30
    30 31
    31 32 
     # Can mock this
    ... ... @@ -41,12 +42,12 @@ def cas():
    41 42
    42 43 
     @pytest.fixture
    43 44 
     def cache(cas):
    44 
    -    yield reference_cache.ReferenceCache(cas, 50)
    45 
    +    yield ReferenceCache(cas, 50)
    45 46
    46 47
    47 48 
     def test_simple_result(cache, context):
    48 49 
         keys = ["rick", "roy", "rach"]
    49 
    -    service = reference_storage_service.ReferenceStorageService(cache)
    50 
    +    service = ReferenceStorageService(cache)
    50 51
    51 52 
         # Check that before adding the ReferenceResult, attempting to fetch it fails
    52 53 
         request = buildstream_pb2.GetReferenceRequest(key=keys[0])
    ... ... @@ -67,9 +68,9 @@ def test_simple_result(cache, context):
    67 68
    68 69
    69 70 
     def test_disabled_update_result(cache, context):
    70 
    -    disabled_push = reference_cache.ReferenceCache(cas, 50, False)
    71 
    +    disabled_push = ReferenceCache(cas, 50, False)
    71 72 
         keys = ["rick", "roy", "rach"]
    72 
    -    service = reference_storage_service.ReferenceStorageService(disabled_push)
    73 
    +    service = ReferenceStorageService(disabled_push)
    73 74
    74 75 
         # Add an ReferenceResult to the cache
    75 76 
         reference_result = remote_execution_pb2.Digest(hash='deckard')
    ... ... @@ -85,8 +86,8 @@ def test_disabled_update_result(cache, context):
    85 86
    86 87 
     @pytest.mark.parametrize("allow_updates", [True, False])
    87 88 
     def test_status(allow_updates, context):
    88 
    -    cache = reference_cache.ReferenceCache(cas, 5, allow_updates)
    89 
    -    service = reference_storage_service.ReferenceStorageService(cache)
    89 
    +    cache = ReferenceCache(cas, 5, allow_updates)
    90 
    +    service = ReferenceStorageService(cache)
    90 91
    91 92 
         request = buildstream_pb2.StatusRequest()
    92 93 
         response = service.Status(request, context)

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.

    [Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]