[Notes] [Git][BuildStream/buildstream][master] 2 commits: plugin.py: Stop printing None for fatal-warnings

[Qinusty <gitlab mg gitlab com>]

Title: GitLab

Qinusty pushed to branch master at BuildStream / buildstream

Commits:

• ef606229
  by Josh Smith at 2018-08-21T14:49:57Z

  plugin.py: Stop printing None for fatal-warnings
  
  Providing warn with detail=None (default) will no longer print None when
  a fatal warning is triggered.
  

• d8256c74
  by Qinusty at 2018-08-21T15:46:14Z

  Merge branch 'Qinusty/598-fatal-warning-none-detail' into 'master'
  
  Fatal warnings no longer print None when detail=None
  
  See merge request BuildStream/buildstream!694

1 changed file:

• buildstream/plugin.py

Changes:

buildstream/plugin.py

---

...	...	@@ -508,6 +508,7 @@ class Plugin():
508	508	project = self._get_project()
509	509
510	510	if project._warning_is_fatal(warning_token):
	511	+ detail = detail if detail else ""
511	512	raise PluginError(message="{}\n{}".format(brief, detail), reason=warning_token)
512	513
513	514	self.__message(MessageType.WARN, brief=brief, detail=detail)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.