[Notes] [Git][BuildStream/buildstream][bst-1.2] 3 commits: tests/fronten

Tristan Van Berkom pushed to branch bst-1.2 at BuildStream / buildstream

Commits:

b82d6793

by Phil Dawson at 2018-08-14T05:33:23Z

tests/frontend/show.py: Add test case for maximum recursion depth being exceeded

Add test to ensure gracefull handling of exception thrown while loading
a pipeline due the python's max recursion depth being exceeded.

This is part of the work for issue #203

9e2b66cc

by Phil Dawson at 2018-08-14T05:33:23Z

app.py: Handle exception thrown when recursion limit is exceeded

Because the RecursionError exception was introduced in Python 3.5, until we
drop support for for Python 3.4, we must use RuntimeError.

cbdeba7b

by Tristan Van Berkom at 2018-08-14T06:45:42Z

Merge branch 'valentindavid/203-BuildStream-crashes-when-dependency-tree-too-deep' into 'bst-1.2'

203 build stream crashes when dependency tree too deep

See merge request BuildStream/buildstream!654

Changes:

buildstream/_frontend/app.py

@@ -275,6 +275,10 @@ class App():
              # Exit with the error
              self._error_exit(e)
 +        except RecursionError:
 +            click.echo("RecursionError: Depency depth is too large. Maximum recursion depth exceeded.",
 +                       err=True)
 +            sys.exit(-1)
          else:
              # No exceptions occurred, print session time and summary

tests/frontend/show.py

  import os
 -import pytest
 +import sys
 +import shutil
  import itertools
 +import pytest
  from tests.testutils import cli, generate_junction
  from buildstream import _yaml
@@ -232,3 +234,58 @@ def test_fetched_junction(cli, tmpdir, datafiles, element_name):
      results = result.output.strip().splitlines()
      assert 'junction.bst:import-etc.bst-buildable' in results
++
++
 +###############################################################
 +#                   Testing recursion depth                   #
 +###############################################################
 +@pytest.mark.parametrize("dependency_depth", [100, 500, 1200])
 +def test_exceed_max_recursion_depth(cli, tmpdir, dependency_depth):
 +    project_name = "recursion-test"
 +    path = str(tmpdir)
 +    project_path = os.path.join(path, project_name)
++
 +    def setup_test():
 +        """
 +        Creates a bst project with dependencydepth + 1 elements, each of which
 +        depends of the previous element to be created. Each element created
 +        is of type import and has an empty source file.
 +        """
 +        os.mkdir(project_path)
++
 +        result = cli.run(project=project_path, silent=True,
 +                         args=['init', '--project-name', project_name])
 +        result.assert_success()
++
 +        sourcefiles_path = os.path.join(project_path, "files")
 +        os.mkdir(sourcefiles_path)
++
 +        element_path = os.path.join(project_path, "elements")
 +        for i in range(0, dependency_depth + 1):
 +            element = {
 +                'kind': 'import',
 +                'sources': [{'kind': 'local',
 +                             'path': 'files/source{}'.format(str(i))}],
 +                'depends': ['element{}.bst'.format(str(i - 1))]
 +            }
 +            if i == 0:
 +                del element['depends']
 +            _yaml.dump(element, os.path.join(element_path, "element{}.bst".format(str(i))))
++
 +            source = os.path.join(sourcefiles_path, "source{}".format(str(i)))
 +            open(source, 'x').close()
 +            assert os.path.exists(source)
++
 +    setup_test()
 +    result = cli.run(project=project_path, silent=True,
 +                     args=['show', "element{}.bst".format(str(dependency_depth))])
++
 +    recursion_limit = sys.getrecursionlimit()
 +    if dependency_depth <= recursion_limit:
 +        result.assert_success()
 +    else:
 +        #  Assert exception is thown and handled
 +        assert not result.unhandled_exception
 +        assert result.exit_code == -1
++
 +    shutil.rmtree(project_path)

[Notes] [Git][BuildStream/buildstream][bst-1.2] 3 commits: tests/frontend/show.py: Add test case for maximum recursion depth being exceeded

Tristan Van Berkom pushed to branch bst-1.2 at BuildStream / buildstream

Commits:

2 changed files:

Changes: