[Notes] [Git][BuildStream/buildstream][chandan/dev-requirements] Move development reqirements to dev-requirements.txt

[Chandan Singh <gitlab mg gitlab com>]

Title: GitLab

Chandan Singh pushed to branch chandan/dev-requirements at BuildStream / buildstream

Commits:

• 95920f48
  by Chandan Singh at 2018-08-11T15:46:05Z

  Move development reqirements to dev-requirements.txt
  
  In some cases, such as when working inside a virtual environment, it can
  be desirable to install all dependencies for running tests using `pip`.
  This is currently not possible since setuptools does not support
  installing these dependencies in a virtual environment (by design).
  (See https://stackoverflow.com/a/21003259.)
  
  To circumvent this issue, move such requirements to
  `dev-requirements.txt` file that can be used easily with
  `pip install -r`. This also enables tests to be run directly using
  `pytest`, which can be more convenient than `-addopts` approach when one
  needs to add multiple options.
  
  This will also be useful in creating better testuite images, and fix
  some of the issues noticed in
  https://gitlab.com/BuildStream/buildstream-docker-images/merge_requests/56.
  

3 changed files:

• MANIFEST.in
• + dev-requirements.txt
• setup.py

Changes:

MANIFEST.in

---

...	...	@@ -21,3 +21,6 @@ recursive-include tests *.expected
21	21
22	22	# Protocol Buffers
23	23	recursive-include buildstream/_protos *.proto
	24	+
	25	+# Requirements files
	26	+dev-requirements.txt

dev-requirements.txt

---

	1	+# Pin coverage to 4.2 for now, were experiencing
	2	+# random crashes with 4.4.2
	3	+coverage == 4.4.0
	4	+pep8
	5	+pytest >= 3.1.0
	6	+pytest-cov >= 2.5.0
	7	+pytest-datafiles
	8	+pytest-env
	9	+pytest-pep8
	10	+pytest-pylint
	11	+# Provide option to run tests in parallel, less reliable
	12	+pytest-xdist

setup.py

---

...	...	@@ -218,6 +218,15 @@ def get_cmdclass():
218	218	return cmdclass
219	219
220	220
	221	+#####################################################
	222	+# Gather requirements #
	223	+#####################################################
	224	+setup_requires = set(['pytest-runner'])
	225	+with open('dev-requirements.txt') as dev_reqs:
	226	+ dev_requires = set([line for line in dev_reqs.read().split('\n')
	227	+ if not line.strip().startswith('#')])
	228	+
	229	+
221	230	#####################################################
222	231	# Main setup() Invocation #
223	232	#####################################################
...	...	@@ -260,17 +269,6 @@ setup(name='BuildStream',
260	269	'grpcio >= 1.10',
261	270	],
262	271	entry_points=bst_install_entry_points,
263		- setup_requires=['pytest-runner'],
264		- tests_require=['pep8',
265		- # Pin coverage to 4.2 for now, we're experiencing
266		- # random crashes with 4.4.2
267		- 'coverage == 4.4.0',
268		- 'pytest-datafiles',
269		- 'pytest-env',
270		- 'pytest-pep8',
271		- 'pytest-pylint',
272		- 'pytest-cov >= 2.5.0',
273		- # Provide option to run tests in parallel, less reliable
274		- 'pytest-xdist',
275		- 'pytest >= 3.1.0'],
	272	+ setup_requires=list(setup_requires),
	273	+ tests_require=list(dev_requires - setup_requires),
276	274	zip_safe=False)

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.