[Notes] [Git][BuildStream/buildstream][jmac/remote_execution

Jim MacArthur pushed to branch jmac/remote_execution_client at BuildStream / buildstream

Commits:

4708ee6b

by Antoine Wacheux at 2018-05-31T12:57:51Z

_artifactcache/ostreecache.py: Fix artifact cache initialization result tuple

In case of failure, the tuple contained 4 elements instead of 3, causing
BuildStream to crash.

065f5ac7
by Tristan Maat at 2018-06-05T08:47:33Z
```
_context.py: Normalize user-defined paths
```

279dcb40

by Tristan Maat at 2018-06-05T08:47:33Z

tests/context/context.py: Test setting XDG_CACHE_HOME

fe24fc3b

by Gökçen Nurlu at 2018-06-05T16:23:22Z

Add test to verify cleanup behaviour after bwrap

This adds `sandbox-bwrap/test-cleanup.bst` to test the cleanup behaviour in
`sandbox/_sandboxbwrap.py`: There already exists a non-empty `/tmp` folder and
BuildStream should not try to remove it after a command is executed with bwrap.

75fe8037

by Gökçen Nurlu at 2018-06-05T16:23:22Z

_sandboxbwrap.py: Fix post-bwrap cleanup behaviour

The cleanup was supposed not to remove folders (`/dev`, `/tmp`, `/proc`) if
they already existed before bwrap but it did the opposite: it tried to remove
them if they existed before, and didn't remove them if they were created during
bwrap. This was caused by a `not` clause, and this removes it.

Fixes #379

8d88b52a

by Phillip Smyth at 2018-06-05T18:00:03Z

utils.py: Correcting a typo in safe_remove's comment

1d694b28

by Chandan Singh at 2018-06-05T19:34:21Z

_artifactcache/pushreceive.py: Add Click type for CLI argument 'repo'

The CLI for `bst-artifact-receive` expects a `repo` argument, which is
supposed to be a directory, but Click currently expects it to be just
any string. This results in stack traces like the one below when the
argument provided is not a directory:

        $ ~/.local/bin/bst-artifact-receive --pull-url http://foo foobaz
        Traceback (most recent call last):
          File "/root/.local/bin/bst-artifact-receive", line 8, in <module>
            sys.exit(receive_main())
          ...
          File "/src/buildstream/buildstream/_artifactcache/pushreceive.py", line 581, in __init__
            self.repo.open(None)
        GLib.Error: g-io-error-quark: /src/buildstream/43fref: opendir(/src/buildstream/foobaz): No such file or directory (1)

Add types for this argument such that it throws better error messages
when it receives bad arguments. With the Click types added, it will
instead fail with messages like these:

        $ ~/.local/bin/bst-artifact-receive --pull-url http://foo foobaz
        Usage: bst-artifact-receive [OPTIONS] REPO

        Error: Invalid value for "repo": Directory "foobaz" does not exist.

        $ ~/.local/bin/bst-artifact-receive --pull-url http://foo setup.py
        Usage: bst-artifact-receive [OPTIONS] REPO

        Error: Invalid value for "repo": Directory "setup.py" is a file.

Fixes #409.

7f9216b3

by Tristan Van Berkom at 2018-06-06T17:20:24Z

_frontend/app.py: Remove unused variable at global scope

5dc8ab98
by Ed Baunton at 2018-06-06T17:56:59Z
```
Add a kind for Make
```

b36db258

by Tristan Van Berkom at 2018-06-06T18:50:54Z

doc/source/authoring.rst: Adding `make` element to the docs

5ddec56f

by Tristan Van Berkom at 2018-06-06T18:54:03Z

_versions.py: Bump format version to 9

For addition of new `make` plugin

17fa7ba4

by Tristan Van Berkom at 2018-06-06T18:54:27Z

make plugin: Ammended documentation to note it's since version.

0f2fd8c8
by Tristan Van Berkom at 2018-06-06T18:55:56Z
```
NEWS: Mentioning new `make` build element
```
55dc3b27
by Tristan Van Berkom at 2018-06-06T18:59:00Z
```
make build element: Add support for PREFIX
```

7df95654

by Chandan Singh at 2018-06-06T21:27:30Z

_loader/loader.py: Report element-path when failing to load elements

It can be confusing, especially to new BuildStream users, that the CLI
expects targets to be specified relative to element-path and not the
current directory. Previously, the CLI would give a generic message
stating that the file could not be found but it was not obvious that it
was looking in the `element-path` directory.

Explicitly print the element-path in the summary. Also, try to check if
the specified element exists in the elements directory and print a hint
to use the element-path relative paths if that's the case.

Fixes #396.

This is is also related to #341. This commit aims to tackle that issue
by trying to educate users about element-path.

a5ff465d

by Chandan Singh at 2018-06-06T22:10:49Z

_project.py: Allow running bst commands from subdirectories of project root

When initializing the project, BuildStream will continue searching for
project.conf in parent directories in case it is not found in the
current directory.

Fixes #368.

69e59443

by Chandan Singh at 2018-06-06T22:10:49Z

_frontend/cli.py: Try to autocomplete element paths when running from a subdirectory

The previous commit added support for running bst commands form
subdirectories of the project root. Make autocomplete also work in a
similar way.

e36001f9
by Ed Baunton at 2018-06-07T13:43:27Z
```
Make `bst help` work
```
b25c31ea
by Ed Baunton at 2018-06-07T17:34:27Z
```
Implement bst help
```

8234e9c7

by Tristan Van Berkom at 2018-06-07T20:14:11Z

_frontend/cli.py: Allow specifying commands in `bst help`

  o This supports deeply nested commands as well as shallow commands

  o Automated support for bash completions included

9c65b908

by Tristan Van Berkom at 2018-06-07T20:14:11Z

tests/completions: Added test case for custom `bst help` completions

4632cb03
by Tristan Maat at 2018-06-07T20:35:51Z
```
_ostree.py: Reintroduce remove()
```

60a29f68

by Tristan Maat at 2018-06-07T20:35:51Z

_ostree.py: Introduce _list_all_refs() and list_artifacts()

The unused list_remote_refs() function has also been removed as
part of this commit.

b7191fda
by James Ennis at 2018-06-07T20:35:51Z
```
pushreceive.py: Ensure there is a repopath
```

58adbe0b

by James Ennis at 2018-06-07T20:41:03Z

pushreceive.py: Remove LRP artifacts from cache, introduce clean_up_cache()

This fixes #136

8a0c0a9a

by James Ennis at 2018-06-07T20:41:33Z

element_generators.py: Add a utility function to create arbitrary size elements

New file consisting of functions that allow us to generate elements
on the fly
__init__.py now includes create_element_size()

ed0df6b5

by James Ennis at 2018-06-07T20:41:33Z

push.py: Add tests to test remote cache expiry

The tests include a new environment variable: BST_CACHE_QUOTA.
This variable is used in receive_main() in pushreceive.py.
Test names: test_artifact_expires, test_large_artifact_is_not_cached_remotely
test_recently_pulled_artifact_does_not_expire: marked as xfail until
we implement LRU expiry in remote share

b8a52cbd

by James Ennis at 2018-06-07T20:41:33Z

pushreceive.py: Add comments to code and name variables more sensibly

b823a616

by James Ennis at 2018-06-07T20:41:33Z

pushreceive.py: Ensure huge artifacts are not pushed

a231d41b
by James Ennis at 2018-06-07T20:41:33Z
```
pushreceive.py: Abstract the buffer_
```

de194dad

by Tristan Van Berkom at 2018-06-07T20:41:33Z

_artifactcache/pushreceive.py: Cleanup reported error when receiving oversized artifacts

This user facing string was redundantly declared in two places, only
the message when catching the error was ever printed.

8f2bf4e6

by Tristan Van Berkom at 2018-06-08T19:48:11Z

autotools plugin: Dont regenerate existing configure scripts

This closes #256

af10c1ba

by Valentin David at 2018-06-08T21:07:22Z

Interpret names as colon separated junction path in loader.

'a.bst:b.bst' gets interpreted as 'b.bst' from junction 'a.bst'.

Part of #359.

ccec163b

by Valentin David at 2018-06-08T21:07:22Z

Reword uses of project in Workspaces.

Make it clear we expect the top-level project here as we use it to
resolve paths relative to project directory.

130bfbb8

by Valentin David at 2018-06-08T21:07:22Z

Handle cross junction elements in workspaces.

Workspaces are now index by colon separated junction path. This
now allows to create workspaces for elements in external projects.

Workspaces are owned by context instead of root project. However
it is initialized once top-level project is registered as we need
to resolve paths relatively to this top-level project.

Part of #359.

acde3ba8

by Valentin David at 2018-06-08T21:07:22Z

Allow tracking dependencies within sub-projects.

--track-cross-junctions now concerns crossing junctions rather than
forbidding elements in sub-project to be tracked.

Part of #359.

71b78794

by Tristan Van Berkom at 2018-06-09T19:48:42Z

doc/source/index.rst: Use only one level depth ToC on main page

The main page has too much information on it otherwise, we want
a friendly, not overwhelming first page to our docs.

055b77e8

by Tristan Van Berkom at 2018-06-09T21:14:10Z

doc: Added plugins as ToC elements instead of orphaned links

  o Now the page titles are declared in plugins, allowing for
    a more descriptive ToC

  o Makefile and plugin.rsttemplate updated to not produce the title,
    to no longer use `:orphan:` for plugin pages, and to ignore any
    private modules in the plugin directories.

  o Interestingly, now the docs will fail to build if you add
    a new plugin and forget to add it to the documentation.

5f794829

by Tristan Van Berkom at 2018-06-09T21:23:23Z

doc/source/main_core.rst: Use a hidden toctree to hide away some things

Sphinx generates some library style module index, we just include
it in a hidden toctree and avoid using it altogether.

96c219d0

by Tristan Van Berkom at 2018-06-09T21:36:07Z

doc/source/core_framework.rst: Use a toctree instead of links

1e98ecb2

by Tristan Van Berkom at 2018-06-09T22:00:24Z

doc/source/index.rst: Add resources directly at the bottom of the main page

This is nice to have on the main page, and is only a few links, dont
like having a whole toplevel ToC entry for this.

77dd1091

by Tristan Van Berkom at 2018-06-09T22:08:49Z

doc: Split out cache keys and sandboxing writings into a sub section

53653d29

by Tristan Van Berkom at 2018-06-09T22:09:50Z

doc/source/authoring.rst: Removed unneeded link anchor from here

52412db4

by Tristan Van Berkom at 2018-06-09T22:18:28Z

.gitlab-ci.yml: Stop depending on specific version of sphinx

This branch fixes #312 by using a hidden toctree to include
the buildstream package and reducing the amount of allowed :orphan:
pages.

8e6f1a9b

by Tristan Van Berkom at 2018-06-09T23:44:25Z

doc: Stop generating the modules index

We still have a few unused artifacts in the docs generation,
this is just one less.

99fb2d53

by Tristan Van Berkom at 2018-06-09T23:45:41Z

doc/examples/flatpak-autotools: Use consistent project name

This was named autotools-flatpak, changed to flatpak-autotools.

710e1fd4

by Tristan Van Berkom at 2018-06-09T23:48:09Z

doc/source/examples_flatpak_autotools.rst: Added some links to the example project on gitlab.

4af8112d

by Tristan Van Berkom at 2018-06-10T00:11:07Z

doc/source/examples.rst: Use a flat ToC here

Here we're really listing examples, a ToC with depth is
not great here.

d0dc9e64

by Tristan Van Berkom at 2018-06-10T00:21:47Z

doc/source/main_using.rst: Reversed ToC here

Seems that the "commands" is taking a lot of space such that
we can't see the other sections here easily, that is alright
if "commands" remains at the end.

ea775fa3
by Tristan Van Berkom at 2018-06-10T01:12:37Z
```
doc: Removed some unused link targets
```

9f77cb66

by Tristan Maat at 2018-06-11T18:16:33Z

Handle missing tags in git repositories correctly

Fixes issue #380

e112a88f

by Tristan Van Berkom at 2018-06-12T21:38:25Z

doc/bst2html.py: Added bst2html.py

This baby runs bst and captures the output with colors enabled
and then generates some html we can include in documentation.

These can be generated in CI continuously and used in the documentation.

52f70a0d

by Tristan Van Berkom at 2018-06-12T21:38:26Z

doc/Makefile: Run bst2html.py to generate .html files from .run files

If you need an example output of bst to put in the documentation,
just add a .run file to the doc/examples directory and it will result
in a similarly named .html file in doc/source/examples.

050cf2eb

by Tristan Van Berkom at 2018-06-12T21:38:26Z

doc/sessions: Added run files describing scenarios to build

The Makefile uses these to run some scenarios which are
later included by the documentation directly.

c900d42e

by Tristan Van Berkom at 2018-06-12T21:38:26Z

doc/source/examples_flatpak_autotools.rst: Using generated examples

Show the commands at work in this example.

4dfc8607

by Tristan Van Berkom at 2018-06-12T21:38:26Z

doc/source/examples.rst: Restructuring individual examples into an examples subdirectory

19dddf82

by Tristan Van Berkom at 2018-06-12T21:38:26Z

doc/source/sessions: Committing generated session files.

This is only to make it easier for people who just want to
build docs locally and not regenerate the session files.

The session snapshot html files are always generated in CI every time.

f3b19f2c

by Tristan Van Berkom at 2018-06-12T21:38:26Z

HACKING.rst: Added guidelines for adding examples

And some instructions about generating `bst` output for documentation

d9da078d

by Tristan Van Berkom at 2018-06-12T21:38:26Z

.gitlab-ci.yml: Speed up docs build by setting up BST_SOURCE_CACHE

Use the gitlab cache for caching sources needed for building projects
in order to collect sample output for documentation pages.

53bc7272

by Tristan Van Berkom at 2018-06-13T02:41:15Z

doc: Don't allow setting a height on the generated session html

This was a bad idea and doesnt play well with mobile UIs, better
off to just include the whole thing even if it's long, and let
the backing page handle vertical scrolling.

9d7296eb

by Tristan Van Berkom at 2018-06-13T04:24:27Z

doc: Overhaul of page names and titles

 o Giving main pages simple word titles

   This makes the main page:

   * About
   * Installing
   * Using
   * Reference
   * Contributing

 o Now named all rst files with their parent page name as a prefix.

 o Also changed some titles to make overall consistent titles.

ba018efe

by Chandan Singh at 2018-06-13T20:24:15Z

contrib/bst-here: Fix command/arg in usage instructions

As we can only accept arguments when a command is specified, make it
clear in the usage instructions.

fa73abe4

by Chandan Singh at 2018-06-13T20:24:15Z

contrib/bst-here: Remove redundant create_volume_if_not_exists() method

This method doesn't really do anything as this is already the default
behavior of `docker volume create` so remove it and always call
`docker volume create` directly. This command will always print the name
of the volume on STDOUT which is not very interesting so silence that.
(If it errors out for some reason, that output will go to STDERR so the
user should still be able to see that.)

6da05577

by Tristan Van Berkom at 2018-06-14T03:12:53Z

doc: Improve the new console output html generator

Before we were creating one description file for each output,
making it easier to declare a make rule for it - but the result
was that we would have to build things more and it takes a
long time.

Instead, now we have session files which describe a series of commands
to run in a session, and each command optionally produces an output file.

5ba5415e

by Tristan Van Berkom at 2018-06-14T22:22:03Z

doc/Makefile: Fixed loop over session files

This list needs to not be quoted.

a01a5cc8

by Tristan Van Berkom at 2018-06-16T17:27:49Z

doc/bst2html.py: Add support for `fake-output` when running commands.

When specifying a fake-output string, we don't really run the command
or assume it was a `bst` command, and we pretend that `fake-output`
was the output of the command.

Specifying an empty string explicitly enables the behavior too
for faking a command that has no stdout/stderr.

This also adds the "remove-files" hack allowing the session scripts
to remove files before executing commands (kind of unsure if we're
gonna keep this...)

b592a80b

by Tristan Van Berkom at 2018-06-16T19:44:56Z

doc/bst2html.py, doc/Makefile: Added --force option

If --force is not specified, then we'll skip session files in
the case that all of the outputs exist.

Now setting BST_FORCE_SESSION_REBUILD when building the docs
will cause the session files to be rebuilt regardless of whether
they exist or not.

The .gitlab-ci.yml was also changed to use this and force rebuilds.

1b88e2c6

by Tristan Van Berkom at 2018-06-16T20:14:04Z

doc: Adding part 1 of the getting started tutorial

  o doc/Makefile: Added new directory to collect rst files from

  o doc/examples/first-project: Added the "first-project" example
    project.

  o doc/source/sessions/first-project-*.html: Added the generated
    snippets

  o doc/source/using_tutorial.rst: Added the new main tutorial page

  o doc/source/tutorial/first-project.rst: Added part 1 of the tutorial here

  o tests/examples/first-project.py: Added test for the example project

This is largely based on an example by Javier Jardón, which was
submitted at https://gitlab.com/BuildStream/buildstream/merge_requests/323

Fixes #103

6fa3f922

by Tristan Van Berkom at 2018-06-16T20:14:04Z

doc/Makefile: Stage stored sessions from session-stored

Separate the revisioned provisional session html files such
that the git tree does not become dirty as a result of a
documentation build process - which messes up the docs version
number and the version number printed in some command line output.

3f560378

by Tristan Van Berkom at 2018-06-18T00:58:20Z

doc/source/tutorial/first-project.rst: Adding links

Linking out to the relevant invoking pages for the command line
reference, and adding a link anchor here for use by the next chapter.

73b93002

by Tristan Van Berkom at 2018-06-18T01:37:22Z

doc: Adding part 2 of the getting started tutorial

  o doc/examples/running-commands: New example project of a `manual` build element

  o doc/sessions/running-commands.run: New session file to capture bst output

  o doc/source/sessions-stored: Added new generated sessions

  o doc/source/tutorial/running-commands.rst: New tutorial entry describing how
                                              commands are run in the sandbox

  o tests/examples/running-commands.py: Test case validating the tutorial's assertions

72fbaa1c

by Tristan Van Berkom at 2018-06-18T19:01:14Z

doc/source/tutorial/running-commands.rst: Adding summary

And adding some link anchors needed by the incomming chapter.

b4105e8d

by Tristan Van Berkom at 2018-06-18T19:17:52Z

doc: Adding part 3 of the getting started tutorial: autotools element

This part of the tutorial uses a lot of the work from Phil Dawson
and James Ennis, and uses their example submitted on merge request
499 as a basis to introduce the user to yaml composition and variable
resolution.

This is a part of issue #103

9b81f958

by Tristan Van Berkom at 2018-06-18T19:18:19Z

doc/source/using_tutorial.rst: Use a numbered ToC for the tutorial

48b4cb5c

by Tristan Van Berkom at 2018-06-19T00:19:09Z

doc/examples/autotools/project.conf: Correcting project name here

5b6441fa

by Tristan Van Berkom at 2018-06-19T02:41:50Z

doc: Use consistent titles when referring to files in an example project

Use the following form across the board:

  ``elements/foo.bst``
  ~~~~~~~~~~~~~~~~~~~~

  .. literalinclude:: ../path/to/foo.bst
     :language: yaml

Always use an example project relative path, too.

bb223156

by Tristan Van Berkom at 2018-06-19T02:47:46Z

doc/source/examples/flatpak-autotools.rst: Reordering of titles.

Place the titles of literally included `bst` files directly before
the includes, and moved all related text to start below the included
file for each section.

4016bec1
by Gökçen Nurlu at 2018-06-19T04:41:24Z
```
Remove shebangs from python files

Fixes #424
```

4f168b9b

by Daniel Playle at 2018-06-20T22:05:19Z

Restrict version of pylint

pylint >2 is not compatible with pytest_pylint in its current form. As
such, allowing any version of pylint for testing results in a failure.

This commit restricts down the allowable versions of pylint to those
that are both compatible with pytest_pylint, and also offer the feature
set that we require.

See https://gitlab.com/BuildStream/buildstream/issues/427 for further
details.

49fb3636

by Phil Dawson at 2018-06-21T23:32:46Z

MANIFEST.in: Fix typo when including BuildStream.doap

Correct includsion of buildstream.doap which does not exist
to 'include BuildStream.doap'.

This commit resolves issue #430

411dd100

by Patrick Martin at 2018-06-22T15:41:34Z

doc/source/index.rst: fix tiny, but impactful typo

Fixes #435

d9a433a7

by Javier Jardón at 2018-06-22T17:03:44Z

BuildStream depends on host tools for Source plugins

b5d91794

by Javier Jardón at 2018-06-22T17:03:44Z

Source plugin tar depends on host's lzip

Issue #353

7d97c6d3

by Javier Jardón at 2018-06-22T17:03:44Z

Source plugin bzr depends on host's bzr

Issue #353

3b1e869b

by Javier Jardón at 2018-06-22T17:03:44Z

Source plugin git depends on host's git

Issue #353

be92cc8d

by Javier Jardón at 2018-06-22T17:03:44Z

Source plugin patch depends on host's patch

Issue #353

e90098e0

by Javier Jardón at 2018-06-22T17:03:44Z

Source plugin deb depends on host's arpy python package

Issue #353

4f1d5a1c

by Tristan Van Berkom at 2018-06-22T17:05:39Z

doc/source/core_plugins.rst, doc/source/install_main.rst: Fixing link anchor name

In core_plugins.rst, we are already using _plugins, _plugins_build_elements,
so lets call this one _plugins_sources to be consistent.

10d21ff0
by Valentin David at 2018-06-23T01:17:40Z
```
Fix element check for BST_FORBID_BDEPENDS
```

6641bcd6

by Tristan Van Berkom at 2018-06-25T07:04:58Z

doc/source/main_using.rst: Updating headline for this page.

The purpose of this page has changed with time, better to clarify
this in the headline of the page.

6d4cbe0c

by Tristan Van Berkom at 2018-06-25T07:04:58Z

doc/source/format_declaring.rst: Improving linkage to other parts of the manual

Adding a couple of important links to relevant material.

4b499ba3

by Tristan Van Berkom at 2018-06-25T07:04:58Z

doc/source/tutorial/autotools.rst: Consistent wording of "chapter"

We've been calling these tutorials "chapters", let's not start
also calling them "sections".

1d84bb80

by Tristan Van Berkom at 2018-06-25T07:04:58Z

doc/source/tutorial/running-commands.rst: Added tip about using `--` in `bst shell`

a25d683e

by Tristan Van Berkom at 2018-06-25T07:04:58Z

doc: Adding part 4 of the getting started tutorial: integration commands

This new section talks about how integration commands work
and shows them at work.

91d87e3c

by Tristan Van Berkom at 2018-06-26T23:40:28Z

_scheduler/job.py: Added long comment

This explains the nature of a complicated asyncio callback,
which I've looked up on multiple occasions and is not available
in python online docs (only in the source can you follow it).

463698ec

by Francisco Redondo Marchena at 2018-06-28T14:18:10Z

Add error message when running commands on directories

Issue #446

48848f4e

by James Ennis at 2018-06-29T08:45:12Z

loader.py: Check whether the dir specified is also a <dir>.bst file

  - Slight modification to the wording of existing error message.
  - Closes #446

aaf52d03

by Tristan Maat at 2018-06-29T15:56:20Z

cli.py: Make buildstream check element paths instead of click

This is to avoid inconsistencies when dealing with paths inside an
elements directory

a85aaee6
by Tiago Gomes at 2018-07-02T14:45:04Z
```
Fix documentation typo
```

9067e269

by Tiago Gomes at 2018-07-02T14:45:04Z

Provide better error message on missing commands

Before running a command in the sandbox, check its existence and fail
early if it does not.

This fixes issue #289.

c5fe9465

by Jürg Billeter at 2018-07-08T12:33:46Z

_signals.py: Guard against use in non-main thread

3d1e23d6

by Jürg Billeter at 2018-07-09T13:44:49Z

tests: Remove unneeded ArtifactShare.update_summary() method

The OSTree summary file is no longer used.

5f4b9377

by Jürg Billeter at 2018-07-09T13:44:49Z

_artifactcache/artifactcache.py: Update remote init error message

initialize_remotes() no longer fetches remote refs.

9defbb62

by Jürg Billeter at 2018-07-09T13:44:49Z

tests/frontend/push.py: Add missing skip annotation for non-Linux

bc5a40e3
by Phillip Smyth at 2018-07-11T11:06:40Z
```
Move _list_dir_contents to __init__.py
```

ddeac63a

by Jonathan Maw at 2018-07-16T12:19:14Z

tests: Fix filter tests not checking whether files should be missing.

They weren't actually catching it if you checked-out the entire depended
element, instead of just the specified split domains

4c6512d6

by Jonathan Maw at 2018-07-16T16:12:08Z

Only redirect elements for workspace and track operations

It was redirecting for checkout operations

fa2eaba2
by Jürg Billeter at 2018-07-17T05:56:40Z
```
tests: Use context manager for ArtifactShare
```

ba4581f8