[Notes] [Git][BuildStream/buildstream][bst-1.2] 2 commits: cascache.py: Raise ArtifactError on grpc error

[Qinusty <gitlab mg gitlab com>]

Title: GitLab

Qinusty pushed to branch bst-1.2 at BuildStream / buildstream

Commits:

• e06907ba
  by Josh Smith at 2018-08-03T15:31:48Z

  cascache.py: Raise ArtifactError on grpc error
  
  This aims to fix issue #502.
  

• 98616f50
  by Qinusty at 2018-08-03T16:30:24Z

  Merge branch 'Qinusty/backport-576' into 'bst-1.2'
  
  Backport unhandled exception fix in cascache.py
  
  See merge request BuildStream/buildstream!602

1 changed file:

• buildstream/_artifactcache/cascache.py

Changes:

buildstream/_artifactcache/cascache.py

---

...	...	@@ -238,7 +238,8 @@ class CASCache(ArtifactCache):
238	238
239	239	except grpc.RpcError as e:
240	240	if e.code() != grpc.StatusCode.NOT_FOUND:
241		- raise
	241	+ raise ArtifactError("Failed to pull artifact {}: {}".format(
	242	+ element._get_brief_display_key(), e)) from e
242	243
243	244	return False
244	245
...	...	@@ -279,6 +280,7 @@ class CASCache(ArtifactCache):
279	280
280	281	except grpc.RpcError as e:
281	282	if e.code() != grpc.StatusCode.NOT_FOUND:
	283	+ # Intentionally re-raise RpcError for outer except block.
282	284	raise
283	285
284	286	missing_blobs = {}

—
View it on GitLab.
You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can adjust your notification settings.