Re: [BuildStream] Guidance on unit tests



Hi Angelos,

On Mon, 2018-11-26 at 22:53 +0400, Angelos Evripiotis wrote:
On Thu, Nov 22, 2018 at 1:50 PM Angelos Evripiotis
<angelos evripiotis gmail com> wrote:
[...]
On Tue, 20 Nov 2018 at 10:33, Tristan Van Berkom via BuildStream-
list
<buildstream-list gnome org> wrote:
[...]

I'll re-add a relevant part that you snipped here:

    "Do you agree with Jim and myself on the above conversation ?"

As you wrote this last patch to the guide, I do hope that you will
offer up an alternative.

Of course! I think there's enough said for me to start another MR,
I'll post a link back here when it's ready.

Here we go:
https://gitlab.com/BuildStream/buildstream/merge_requests/973


After adding many comments to !973 above, I would assert that no, you
probably do not agree, so maybe this is worth discussing further
first ?

Cheers,
    -Tristan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]