Re: Storing Source references (e.g. commit shas) separately

[Jürg Billeter <j bitron ch>]

Hi Tristan,

The proposal looks sensible and useful to me.

On Sun, 2018-01-14 at 21:39 +0900, Tristan Van Berkom wrote:
>   Example:
>   ~~~~~~~~
>
>   # The dictionary of source references
>   references:
>
>     # foo.bst has one git source
>     foo.bst:
>     - ref: 02349cfbbf6c5c1242681aa50b828f841e0e3a42
>
>     # bar.bst has two tarball sources
>     bar.bst:
>     - ref: 0b78b483c179f6998a0df582aea3d77340bb1e9d887b52ed8fae677d535fd19d
>     - ref: 185f0f175a90bcfc55cf3cf6ceff8d447a6269492c0ca1a1fc0748ea2c181363

I'm not too happy about simply relying on the order of sources. The
source list of an element can change and then BuildStream would
(attempt to) use the wrong references, possibly resulting in confusing
error messages.

It's not an issue for the very common case of a single source, so maybe
it doesn't matter in practice. We could write the whole source node to
project.refs but that might make some aspects more complex.

Jürg