Re: [BuildStream] Thoughts around plugins: deprecation



On Fri, Nov 30, 2018 at 15:03:26 -0500, Chandan Singh wrote:
I was thinking that, in order to be able to silence a deprecation warning we
need to be able to address the specific plugin it comes from.  Since during the
migration from one plugin to another (across repos) there may be a time when
more than one plugin has the same *basename* it's necessary to be able to
address them within their particular sources.

I see. I was hoping that we'd be able to derive this information
implicitly. Since a given project cannot use two plugins withe same
name, and we would know which project the element (and hence the
warning) came from, shouldn't we able to say something like "source
FOO from project BAR is deprecated" ? This would mean that the
deprecation warning would appear once per project when a project has
junctions. If that is acceptable, then we may be able to avoid this
new logic about names and paths. What do you think?

Personally I worry that within a project it might be necessary to have multiple
plugins of the same name during a transition period.  I suppose an alternative could
be to allow the import of plugins to rename them, e.g.

```yaml
plugins:
  - origin: whereverwemovepiptoo
    elements:
      pip:
        version: 0 
        rename: newpip
```

Would that sit better with you than a complex new naming scheme?

D.

-- 
Daniel Silverstone                          https://www.codethink.co.uk/
Solutions Architect               GPG 4096/R Key Id: 3CCE BABE 206C 3B69


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]