Re: [BuildStream] Proposal: label name change: review -> verify

[Agustín Benito Bethencourt <agustin benito codethink co uk>]

Hi,

replying myself here after clarifying the topic with Laurence.

On Wednesday, 1 August 2018 11:17:53 CEST Agustín Benito Bethencourt via 
Buildstream-list wrote:
> Hi Laurence,
>
> On Tuesday, 31 July 2018 20:40:47 CEST Laurence Urhegyi via Buildstream-
>
> list wrote:
> > On 23/07/18 16:23, Jim MacArthur via Buildstream-list wrote:
> > > I'm fine with this, but can I suggest we start using the 'review'
> > > label
> > > on MRs instead to indicate that they need review? I find it very
> > > useful to be able to filter current issues for this to find work to
> > > review and would like to continue doing so.
> >
> > Sounds like a sensible work-flow to me, and I can see that we now have
>
> > both 'Verify' and 'Review' labels:
> The proposal was to rename the label, not to create a new one and
> changing the scope of the Review label. Can you send a proposal about
> adding a new label called Review, explaining what would we use it for?
>
> I am not trying to be too formal, just ensure that, since this is a
> matter of policy you and I serve as example on how to propose changes.,
> Hopefully others will in the future following what we have done.
>
> > https://gitlab.com/BuildStream/buildstream/labels
> >
> > I just added a description to the 'Review' label.

For a reason I cannot understand, after renaming the label from Review to 
Verify, the Review label showed up in the buildstream repo. I thought it 
was Laurence who added it there, based on hi mail. He was not. It has not 
MR nor issue using it. I just erased it.

Apologies Laurence.

Best Regards


-- 
Agustín Benito Bethencourt
Principal Consultant
Codethink Ltd
We respect your privacy.   See https://www.codethink.co.uk/privacy.html