[tim-janik/beast] Track primitive properties ported to C++ (#109)
- From: Stefan Westerfeld <notifications github com>
- To: tim-janik/beast <beast noreply github com>
- Cc: Subscribed <subscribed noreply github com>
- Subject: [tim-janik/beast] Track primitive properties ported to C++ (#109)
- Date: Sun, 28 Jul 2019 09:13:43 -0700
I've ported all Track properties to C++ that do not contain object references. Two things are worth mentioning.
Const MIDI_MAX_CHANNEL
- I declared this as constant, but maybe the definition must be moved elsewhere. It seems to be required in bsebasics.idl, too (there is a // FIXME: MAX_MIDI_CHANNEL
in the MidiChannelEvent
definition)
- I didn't touch
"signal::property-notify::n-voices"
and similar signal code in bsttrackview.cc, I'm not sure what the C++ property equivalent would be
You can view, comment on, or merge this pull request online at:
https://github.com/tim-janik/beast/pull/109
Commit Summary
- BSE: Track::muted: port property to C++
- BEAST-GTK: bsttrackview: use muted C++ property
- BSE: Track::midi_channel: port property to C++
- BEAST-GTK: bsttrackview: use midi_channel C++ property
- BSE: Track::n_voices: port property to C++
- BEAST-GTK: bsttrackview: use n_voices C++ property
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]