Re: Resampler uninitialized value

[Stefan Westerfeld <stefan space twc de>]

   Hi!

Am 27.12.19 um 01:21 schrieb Tim Janik:
> please note this warning in a recent CI run:
>
>   CXX      out/tests/testresamplerq.o
> tests/testresamplerq.cc:199:20: warning: 1st function call argument is an
> uninitialized value
>           TASSERT (bse_db_from_factor (rt_up.max_error, -200) < -125);
>                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./bse/testing.hh:22:56: note: expanded from macro 'TASSERT'
> #define TASSERT(cond)           TASSERT__AT (__LINE__, cond)    ///<
> Unconditional test assertion, enters breakpoint if not fullfilled.
>                                                        ^~~~
> ./bse/testing.hh:115:26: note: expanded from macro 'TASSERT__AT'
>   do { if (BSE_ISLIKELY (cond)) break;          \
>                          ^~~~
> ./bse/cxxaux.hh:40:57: note: expanded from macro 'BSE_ISLIKELY'
> #define BSE_ISLIKELY(expr)      __builtin_expect (bool (expr), 1)       ///<
> Compiler hint to optimize for @a expr evaluating to true.
>                                                         ^~~~
> 1 warning generated.
>
> https://travis-ci.org/tim-janik/beast/jobs/629651405
>
> There are also some fcompare warnings you might want to take a look at.

Right, this was actually helpful input by cppcheck/scan-build: I created
pull requests for the resulting changes, two of the commits are really
bug fixes.

 - https://github.com/tim-janik/beast/pull/134
 - https://github.com/tim-janik/beast/pull/135

   Cu... Stefan
-- 
Stefan Westerfeld, http://space.twc.de/~stefan