Re: [tim-janik/beast] BSE: fix undo problems that occur after removing a bus (#82)

[Tim Janik <notifications github com>]

Hey Stefan, thanks for looking into this.
I don't fully follow the argument you make in your comment though.

• Why should an undo step be recorded for restoring a connection that doesn't exist in the first place?
• Also, with your code, calling disconnect_bus() repeatedly will record more and more undo steps, for a connection that's not existing and could have been restored at most only once anyway.

It look like you're onto something here, but AFAIU the "fix" in this PR is almost certainly not the right one.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.