Re: [tim-janik/beast] Port Song::loop_left property (#65)

[Tim Janik <notifications github com>]

Thanks for the PR, a couple comments:

•  SfiInt lleft = self->song.loop_left();
  

Use just int, float, etc in new code, instead of gint or SfiInt.

• BseSong self = const_cast<SongImpl> (this)->as<BseSong >();
  This should be "as<BseSong>", without the extra space.

•  bool loop_enabled = self->loop_enabled_SL;
  

You're saving an old value here for comparing later. There's no need to keep this a variable, i.e. please make that const in similar code in the future:
+ const bool loop_enabled = self->loop_enabled_SL;

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.