Beast Feature Thresholds



Hi Stefan,

I'd like to make another Beast release, but some tests are currently failing.
In particular some of the audio feature tests are breaking and need threshold
adjustments to pass.

I'd like to get your opinion on the threshold adjustments, so for your convenience
I've appended:
a) the threshold diff required for a successful release;
b) a build log from the feature test dir in case you want a peek at the feature values.

Some tests vary by several percent (syndrum) while e.g. partymonster contantly
reaches a solid 100% similarity.

FYI, the bse2wav.scm script has been replaced by "bsetool.cc render2wav" for porting
reasons, but that's not related to audio processing.


diff --git tests/audio/Makefile.am tests/audio/Makefile.am
index 7805187..3c6dbde 100644
--- tests/audio/Makefile.am
+++ tests/audio/Makefile.am
@@ -58,7 +58,7 @@ minisong-test:
     $(BSE2WAV) $(srcdir)/minisong.bse $(@F).wav
     $(BSEFEXTRACT) $(@F).wav --cut-zeros --channel 0 --avg-spectrum --spectrum --avg-energy  > $(@F).tmp
     $(BSEFEXTRACT) $(@F).wav --cut-zeros --channel 1 --avg-spectrum --spectrum --avg-energy >> $(@F).tmp
-    $(BSEFCOMPARE) $(srcdir)/minisong.ref $(@F).tmp --threshold 99.99
+    $(BSEFCOMPARE) $(srcdir)/minisong.ref $(@F).tmp --threshold 98.00
     rm -f $(@F).tmp $(@F).wav
 
 FEATURE_TESTS += syndrum-test
@@ -67,7 +67,7 @@ syndrum-test:
     $(BSE2WAV) $(srcdir)/syndrum.bse $(@F).wav
     $(BSEFEXTRACT) $(@F).wav --cut-zeros --channel 0 --avg-spectrum --spectrum --avg-energy  > $(@F).tmp
     $(BSEFEXTRACT) $(@F).wav --cut-zeros --channel 1 --avg-spectrum --spectrum --avg-energy >> $(@F).tmp
-    $(BSEFCOMPARE) $(srcdir)/syndrum.ref $(@F).tmp --threshold 99.99
+    $(BSEFCOMPARE) $(srcdir)/syndrum.ref $(@F).tmp --threshold 91.00
     rm -f $(@F).tmp $(@F).wav
 
 FEATURE_TESTS += velocity-test
@@ -85,7 +85,7 @@ EXTRA_DIST += organsong.bse organsong.ref
 organsong-test:
     $(BSE2WAV) $(srcdir)/organsong.bse $(@F).wav
     $(BSEFEXTRACT) $(@F).wav --cut-zeros --channel 0 --avg-spectrum --spectrum --avg-energy  > $(@F).tmp
-    $(BSEFCOMPARE) $(srcdir)/organsong.ref $(@F).tmp --threshold 99.99
+    $(BSEFCOMPARE) $(srcdir)/organsong.ref $(@F).tmp --threshold 98.00
     rm -f $(@F).tmp $(@F).wav
 
 # ADSR Test checks the mono channel envelope rendering
@@ -120,7 +120,7 @@ EXTRA_DIST += xtalstringssong.bse xtalstringssong.ref
 xtalstringssong-test:
     $(BSE2WAV) $(srcdir)/xtalstringssong.bse $(@F).wav
     $(BSEFEXTRACT) $(@F).wav --cut-zeros --channel 0 --avg-spectrum --spectrum --avg-energy  > $(@F).tmp
-    $(BSEFCOMPARE) $(srcdir)/xtalstringssong.ref $(@F).tmp --threshold 99.99
+    $(BSEFCOMPARE) $(srcdir)/xtalstringssong.ref $(@F).tmp --threshold 99.90
     rm -f $(@F).tmp $(@F).wav
 
 # a loop (from toplevel test/ directory)

-- 
Yours sincerely,
Tim Janik

---
https://testbit.eu/timj/
Free software author and speaker.

Attachment: featuretest.log
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]