Re: SpectMorph vs. RAPICORN_CONVENIENCE

[Tim Janik <timj gnu org>]

On 13.10.2015 15:17, Stefan Westerfeld wrote:
>    Hi!
>
> When I try to build a recent SpectMorph against a recent BEAST, I've seen many
> error messages related to the assert, assert_unreached, assert_return, ...

Yeah, that's a bug.
Note that Beast has transitioned to use those Rapicorn macros only very recently, which is why those bugs are 
still urking in the code base.

> /usr/local/beast/include/beast-0.9/sfi/glib-extra.hh: In function 'void g_bit_matrix_change(GBitMatrix*, 
> guint, guint, gboolean)':
> /usr/local/beast/include/beast-0.9/sfi/glib-extra.hh:174:67: error: 'assert_return' was not declared in 
> this scope
>    assert_return (matrix && x < matrix->width && y < matrix->height);

Header files in Beast or Rapicorn should always use the full namespaced macros, i.e. RAPICORN_ASSERT_RETURN 
and friends.
That's without any exception for all files that are installed.

> For fixing this, I suggest replacing usages of all RAPICORN_CONVENIENCE macros
> by their long names, whenever they are used in rapicorn or beast header files
> (*.hh). These functions would be affected:

Exactly.

> I volunteer to create a patch for that.

Great, please go ahead.

I'm still in the middle of a major packaging overhaul, so probably won't find the time too soon.

>    Cu... Stefan


-- 
Yours sincerely,
Tim Janik

https://testbit.eu/timj/
Free software author and speaker.