Re: compile error: Rapicorn 15.09 on Ubuntu 14.04

[Tim Janik <timj gnu org>]

On 02.10.2015 21:20, Stefan Westerfeld wrote:

> Here is a patch that makes the rcore dir compile on both: kubuntu14.04 and 15.04.
>
> diff --git a/rcore/aida.hh b/rcore/aida.hh
> index b77ca2f..20ad8a0 100644
> --- a/rcore/aida.hh
> +++ b/rcore/aida.hh
> @@ -275,7 +275,8 @@ private:
>    void    rekind  (TypeKind _kind);
>  public:
>    /*dtor*/ ~Any    ();                                  ///< Any destructor.
> -  explicit  Any    ();                                  ///< Default initialize Any with no type.
> +  /* FIXME: removed explicit keyword to compile under g++-4.8.4 */
> +  /*ctor*/  Any    ();                                  ///< Default initialize Any with no type.
>    /// Initialize Any from a @a anany which is of Any or derived type.
>    template<class V, REQUIRES< ::std::is_base_of< Any, typename std::remove_reference<V>::type >::value > = 
> true> inline
>    explicit  Any (V &&anany) : Any()     { this->operator= (::std::forward<V> (anany)); }
>
> This change doesn't need to stay in forever, only so long as we see that many
> people rely on g++-4.8.

Thanks! Applied.

I just had to fix up the commit message, and we don't really need a "FIXME" comment for this in the code.

To make things easier for us, please do me a favor and next time, use:

git format-patch --cover-letter -M -s -o ../patches/ origin/master
vim ../patches/0000-cover-letter.patch
git send-email ../patches/*                                # might need apt-get install git-email


>    Cu... Stefan


-- 
Yours sincerely,
Tim Janik

https://testbit.eu/timj/
Free software author and speaker.