Re: MERGE: bsescm2cxx

[Tim Janik <tim janik lanedo com>]

On Thu, 12 May 2011, Stefan Westerfeld wrote:

>   Hi!
>
> I've modified the C sources in the bsescm/ directory to be compiled as C++
> sources, please merge:
>
> repo:   http://space.twc.de/public/git/stwbeast.git
> branch: bsescm2cxx

Thanks a couple style things that need fixing still:

* Please use void* instead of gpointer where possible.

* Please use the following C++ish cast notation:
  +  gh_new_procedure ("bse-choice-match?", BseScmFunc (bse_scm_choice_match), 2, 0, 0);

* For sfi_glue_gc_add(), please investigate if changing
  the second argument to (void(*free_func)(void*)) is likely to
  reduce casts. The reason the second funciton pointer argument is
  just void* is convenience in C, but were're moving away from that
  so it doesn't make sense to keep convenince C stuff if it makes
  our C++ life harder.

* Please get rid o fthe extra space here:
  +  SignalData *sdata = (SignalData *) data;
  Should be:
  +  SignalData *sdata = (SignalData*) data;


>   Cu... Stefan
> --
> Stefan Westerfeld, Hamburg/Germany, http://space.twc.de/~stefan


Yours sincerely,
Tim Janik

---
http://lanedo.com/~timj/ - Founder and CEO of Lanedo GmbH.
Free software author and contributor on various projects.