Re: MERGE: bse2cxx-part5



On 05.08.2011 19:47, Stefan Westerfeld wrote:
git fetchhttp://space.twc.de/public/git/stwbeast.git  bse2cxx-part5:bse2cxx-part5

Thanks again.

-      self->controls[1] = g_value_get_enum (value);
+      self->controls[1] = BseMidiSignalType (g_value_get_enum (value));

This should rather be:
+      self->controls[1] = (BseMidiSignalType) g_value_get_enum (value);

We see a lot of those enum conversion though, so I'm wondering if it isn't better for the code base to allow automatic int->enum conversion operators... Any experience with that?


--
Yours sincerely,
Tim Janik

---
http://lanedo.com/~timj/ - Founder and CEO of Lanedo GmbH.
Free software author and contributor on various projects.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]