|
Nicholas,
Can you point me to your forked repo? I just forked one here: https://github.com/bernd-wechner/bansheeperhaps you can send me a pull request for the patched files and I'll get rolling ... I wonder who "they" is that don't accept PRs and if banshee is a community driven project? Just curious. Because you're right the GNOME repo: https://github.com/GNOME/banshee/pulls?q=is%3Apr+is%3Aclosedhas only 4 PRs ever and the history suggests it's been on Github since 2006: https://github.com/GNOME/banshee/graphs/code-frequencyand sit seems the PR is a standard way of capitalising on community contribs. Of course triaging and merging them is work someone has to do, but then PRs aren't PRs, some might be onerous and others trivial patches like this ... ;-). Regards, Bernd. Nicholas Little via banshee-list wrote: Nice find, cheers. I'm not sure I'd bother with the pull request, last time I checked they didn't accept them - you're better off commenting on the bugzilla entry so that the maintainers get a notification. I've tested that patch and it works for me. As in, I can autoreconf, configure and make and the program doesn't crash :) The only thing missing from that patch is the update to the mono.m4 within the Hyena submodule for completeness but that's just duplication of what's already shown for the main one - I've added that in the patches I pushed this morning to my forked respositories. FYI use 'git apply' for patches that look like that. On 5 June 2017 at 08:23, Bernd Wechner <bernd wechner gmail com> wrote: > Actually I just found a fix someone else did: > > https://bugzilla.gnome.org/show_bug.cgi?id=753091 > > He posted a patch: > > https://bug753091.bugzilla-attachments.gnome.org/attachment.cgi?id=308515 > > Now I just have to work out how to apply the patch (and find time to) and > then perhaps to post a pull request to the banshee repo for it (assuming it > does the job). > > Regards, > > Bernd. > > Nicholas Little via banshee-list wrote: > > Hi Bernd, > > That's some nice shell foo. In configure.ac you'll find: > > SHAMROCK_CHECK_MONO_2_0_GAC_ASSEMBLIES([ > Mono.Posix > ICSharpCode.SharpZipLib > ]) > > You'll probably have to do some hacking around in the build subtree, > which contains all the macros used by autotools, in order to get it to > work - specifically take a look at > https://github.com/GNOME/banshee/blob/master/build/m4/shamrock/mono.m4 > > We could probably look at updating some of these dependencies as I > think some distributions are dropping Banshee through build > difficulties - Gentoo appears to be anyway so feel free to share a > patch when you get up and running. > > Good luck. > > Yours, > Nicholas > > On 29 May 2017 at 01:53, Bernd Wechner <bernd wechner gmail com> wrote: >> Thought I'd try building Banshee again almost 18 months after first >> effort. >> First efforts failed primarily because Mint was based on a dated release >> fo >> Ubuntu at the time , but it's up to date now and has been for a while so I >> thought to give it a crack. So I followed the directions here: >> >> http://banshee.fm/download/development/ >> >> under Ubuntu. And all is well until I run autogen.sh which bails with: >> >> checking for Mono 2.0 GAC for Mono.Posix.dll... not found >> configure: error: missing required Mono 2.0 assembly: Mono.Posix.dll >> Error: There were errors when running './configure', a step that is >> required >> to configure banshee >> >> Go figure! I'd have thought that was well covered by all the prerequisites >> listed, and I've installed MonoDevelop and Mono from the package >> mono-complete from the Ubuntu repositories (labelled as Complete mono >> runtime, development tools and all libraries) but no luck. If I "locate >> Mono.Posix" telling results are: >> >> /usr/lib/mono/4.5/Mono.Posix.dll >> /usr/lib/mono/gac/Mono.Posix >> /usr/lib/mono/gac/Mono.Posix/4.0.0.0__0738eb9f132ed756 >> /usr/lib/mono/gac/Mono.Posix/4.0.0.0__0738eb9f132ed756/Mono.Posix.dll >> >> To wit Mono.Posix.dll is installed, but autogen.sh isn't finding it. >> Perhaps >> some environment variable or other is what it wants, if it's too blind to >> find it alone. What is going on and why (again) is Banshee apparently not >> so >> simple to build? After all the clear effort that's gone into Ubuntu >> support >> on that development page and more? >> >> Anyhow: >> >> bash -x autogen.sh >> >> reveals that ./configure is what's bailing. And: >> >> bash -x configure >> >> in turn reveals that this is what's failing: >> >> + test -e /usr/lib/mono/2.0/Mono.Posix.dll -o -e >> /usr/lib/mono/2.0/Mono.Posix.dll >> >> And voila, I have Mono 4.5 not 2.0. >> >> So, that begs the obvious questions: >> >> 1) Does banshee really depend on a dated version of Mono? (a version >> superceded in 2009!) >> 2) Can I install a dated version of Mono? And if so, how? >> 3) Can such a dated version of Mono exist in parallel with the latest >> version without causing hassles elsewhere? >> >> Puzzled, and appreciating any insights. >> >> Kind regards, >> >> Bernd. >> >> >> _______________________________________________ >> banshee-list mailing list >> banshee-list gnome org >> https://mail.gnome.org/mailman/listinfo/banshee-list (unsubscribe here) > > > > > > _______________________________________________ > banshee-list mailing list > banshee-list gnome org > https://mail.gnome.org/mailman/listinfo/banshee-list (unsubscribe here)
|