Re: [Banshee-List] [banshee] [FileSystemQueue] Delete from drive command (bgo#609100)



On Sun, Feb 7, 2010 at 1:31 AM, Alexander Kojevnikov
<alexk src gnome org> wrote:
>         protected virtual bool DeleteTrack (DatabaseTrackInfo track)
>         {
> -            throw new Exception ("PrimarySource DeleteTrack method not implemented");
> +            if (!track.Uri.IsLocalPath)
> +                throw new Exception ("Cannot delete a non-local resource: " + track.Uri.Scheme);

Hey Alexander, Andres,

I don't think we want to do this IslocalPath check - the GIO backend
should be able to import and delete non-local files, and this would
thwart that from working properly, no?.  Is the point of the check
just to get better error messages?  Could potentially augment the
check, looking at Banshee.IO.Provider.LocalOnly &&
!track.Uri.IsLocalPath

Gabriel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]