Re: [Banshee-List] banshee r5017 - in trunk/banshee: . src/Core/Banshee.ThickClient/Banshee.Gui



On Sun, 2009-02-08 at 14:01 -0600, Gabriel Burt wrote:
> On Sun, Feb 8, 2009 at 3:06 AM,  <blorentz svn gnome org> wrote:
> > Log:
> > 2009-02-08  Bertrand Lorentz  <bertrand lorentz gmail com>
> >
> >        * src/Core/Banshee.ThickClient/Banshee.Gui/SourceActions.cs: Patch from
> >        John Millikin fixing the export of a playlist that was never browsed
> >        (BGO #570842).
> >
> >
> >
> > Modified:
> >   trunk/banshee/ChangeLog
> >   trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/SourceActions.cs
> >
> > Modified: trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/SourceActions.cs
> > ==============================================================================
> > --- trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/SourceActions.cs     (original)
> > +++ trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/SourceActions.cs     Sun Feb  8 09:06:09 2009
> > @@ -269,6 +269,7 @@
> >             if (source == null) {
> >                 return;
> >             }
> > +            source.Activate ();
> 
> Calling Activate here might be ok, but would probably be better to
> just call source.Reload (), no?

As far as I can tell, Activate just does this :
    if (!ever_reloaded)
        Reload ();

which is what we need : load the source if it has never been loaded
before.

-- 
Bertrand Lorentz <bertrand lorentz gmail com>
> http://flickr.com/photos/bl8/ <

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]