Well, a bug has been fixed, the proper code is now compiled, and I've been un-confused ! Excellent ! While working on the regression test for the resize bug, I noticed that several tests are failing for me. I see that in the meantime you've already fixed one. The ones that are now failing are : 1) StringUtilTests.TestDoubleToTenthsPrecision 2) QueryTests.TestQueryValueSql 3) QueryTests.TestQueryParsing Is it worth looking into ? -- Bertrand Lorentz <bertrand lorentz gmail com> > http://flickr.com/photos/bl8/ < On Sat, 2008-05-17 at 01:01 -0600, Aaron Bockover wrote: > The NET_* defines are internal to the class libraries in Mono itself. I wrote RangeCollection initially for Banshee to solve selection management efficiently for our ListView, but then realized Mono's Windows Forms could greatly benefit from the code as well in all the cases where they have to deal with selections. > > The problem was that all of the winforms code was .NET 1.1, so I needed to provide two versions that differed slightly. Anyway, apparently we've actually been using the .NET 1.1 version of RangeCollection in Banshee (which has the silly resize bug Bertrand found), since NET_2_0 was never defined in (or maybe was removed from) our build system. > > So, I'll define NET_2_0 and apply the patch on the bug. > > Thanks Bertrand! > > --Aaron > > >>> "Sandy Armstrong" <sanfordarmstrong gmail com> 05/16/08 5:09 PM >>> > On 5/16/08, Bertrand Lorentz <bertrand lorentz gmail com> wrote: > > Hi, > > > > While looking into http://bugzilla.gnome.org/show_bug.cgi?id=533099 I > > noticed the following thing : > > > > In two files in trunk there are some lines of code in "#if NET_2_0" > > blocks. I'm using mono 1.2.6, and I think it has all the .NET 2.0 > > features (generics, etc.), so I expected those lines to be compiled. > > > > It turns out that it's not the case (the #else blocks are compiled). Now > > I'm all confused and I'd like to be un-confused... > > > > So, is this the expected behaviour ? > > If not, is there something wrong on my system (gentoo), or is there > > something missing in the banshee build stuff ? > > I'm noticing the same thing with Mono 1.9.1 on openSUSE, so it's not > something wrong on your system. My guess is that the compiler used to > define NET_2_0 under certain circumstances, and no longer does. > Either that or something is missing from Banshee's build scripts, as > you say. > > Sandy
Attachment:
signature.asc
Description: This is a digitally signed message part