Re: [Banshee-List] banshee r3335 - in trunk/banshee: .src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Audioscrobblersrc/Libraries/Lastfm/Lastfm

["Gabriel Burt" <gabriel burt gmail com>]

On Wed, Feb 27, 2008 at 1:28 PM, Brian Nickel <brian nickel gmail com> wrote:
> > trunk/banshee/src/Extensions/Banshee.Lastfm/Banshee.Lastfm.Audioscrobbler/
>  > AudioscrobblerService.cs  Wed Feb 27 08:50:05 2008
>  > >  -            if (song_started && !queued && track.Duration.TotalSeconds
>  > > 30 &&
>  > >  +            if (!queued && track.Duration.TotalSeconds > 30 &&
>  > >                  track.ArtistName != "" && track.TrackTitle != "" &&
>  >
>  > Please do not compare against "".  Use String.Empty, or use the
>  > String.IsNullOrEmpty method.
>
>  Comparing against String.Empty is not recommended. If the string is known to
>  be non-null, String.Length == 0 would be the best method, otherwise
>  String.IsNullOrEmpty.
>
>  http://msdn2.microsoft.com/en-us/library/ms182279(VS.80).aspx

Good to know, thanks Brian.

Gabriel