Re: [Banshee-List] banshee r3200 - in trunk/banshee: . src/Core/Hyena.Gui/Hyena.Data.Gui/ListView



Hey Scott,

On Feb 10, 2008 8:39 AM,  <scottp svn gnome org> wrote:
> Log:
> * src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs:
>   Assures that all rows in view are rendered.

To be consistent, can you put the first two lines of the ChangeLog
entry in the svn commit message?  (eg DATE Scott Peterson <..> \n)

> Modified: trunk/banshee/src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs
> ==============================================================================
> --- trunk/banshee/src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs      (original)
> +++ trunk/banshee/src/Core/Hyena.Gui/Hyena.Data.Gui/ListView/ListView_Windowing.cs      Sun Feb 10 14:39:10 2008
> @@ -272,7 +272,7 @@
>          }
>
>          private int RowsInView {
> -            get { return (int) Math.Ceiling (list_alloc.Height / (double) RowHeight); }
> +            get { return (int) Math.Ceiling (list_alloc.Height / (double) RowHeight) + 1; }
>          }
>      }
>  }

Why do we need the + 1?  The Math.Ceiling should take care of rounding
the number up for any partial rows.

Gabriel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]