Re: [Banshee-List] SVN compile error

["Sandy Armstrong" <sanfordarmstrong gmail com>]

2008/4/25 Bertrand Lorentz <bertrand lorentz gmail com>:
>
> On Fri, 2008-04-25 at 20:25 +0800, Hyperair wrote:
>  > 2008/4/25 David Nielsen <gnomeuser gmail com>:
>  >
>  >
>  >         2008/4/25, Hyperair <hyperair gmail com>:
>  >
>  >                 2008/4/25 David Nielsen <gnomeuser gmail com>:
>  >
>  >                         I hit this playing with SVN 3827.
>  >
>  >                         Compiling Banshee.Dap.dll...
>  >                         ./Banshee.Dap/DapService.cs(105,82): error
>  >                         CS1061: Type `Mono.Addins.TypeExtensionNode'
>  >                         does not contain a definition for `Type' and
>  >                         no extension method `Type' of type
>  >                         `Mono.Addins.TypeExtensionNode' could be found
>  >                         (are you missing a using directive or an
>  >                         assembly reference?)
>  >                         Compilation failed: 1 error(s), 0 warnings
>  >                         make[4]: *** [../../../bin/Banshee.Dap.dll]
>  >                         Fejl 1
>  >
>  >                 Same thing happens when I try to compile it on
>  >                 Archlinux. I've heard on #banshee from slomo that the
>  >                 problem occurs on Debian as well. He said something
>  >                 about an outdated Mono.Addins package.
>  >
>  >         Fedora 9 has 0.3.1 which is the latest released version,
>  >         mono-addins svn only lists cecil changes since that release,
>  >         can that really be true?
>  >
>  >         - David
>  >
>  >
>  >
>  >         Maybe not? I have no idea, seriously.
>
>  The latest banshee code needs Mono.Addins from SVN.
>  In Mono.Addins, the Type property was added to the TypeExtensionNode
>  class after the latest release. See :
>
>  http://anonsvn.mono-project.com/viewcvs/trunk/mono-addins/Mono.Addins/Mono.Addins/TypeExtensionNode.cs
>
>  I guess the configure dependency check will be updated after the
>  next Mono.Addins release.

Attached patch so configure checks for >= 0.4 on the mono-addins
libraries.  Works with latest Mono.Addins from SVN.

OK to commit?

Sandy

Index: build/m4/banshee/mono-addins.m4
===================================================================
--- build/m4/banshee/mono-addins.m4	(revision 3827)
+++ build/m4/banshee/mono-addins.m4	(working copy)
@@ -1,12 +1,12 @@
 AC_DEFUN([BANSHEE_CHECK_MONO_ADDINS],
 [
-	PKG_CHECK_MODULES(MONO_ADDINS, mono-addins >= 0.3)
+	PKG_CHECK_MODULES(MONO_ADDINS, mono-addins >= 0.4)
 	AC_SUBST(MONO_ADDINS_LIBS)
 
-	PKG_CHECK_MODULES(MONO_ADDINS_SETUP, mono-addins-setup >= 0.3)
+	PKG_CHECK_MODULES(MONO_ADDINS_SETUP, mono-addins-setup >= 0.4)
 	AC_SUBST(MONO_ADDINS_SETUP_LIBS)
 
-	PKG_CHECK_MODULES(MONO_ADDINS_GUI, mono-addins-gui >= 0.3)
+	PKG_CHECK_MODULES(MONO_ADDINS_GUI, mono-addins-gui >= 0.4)
 	AC_SUBST(MONO_ADDINS_GUI_LIBS)
 ])