Re: [Banshee-List] m3u playlist importing

["Trey Ethridge" <tethridge gmail com>]

Hello Steve,

Thanks for the patch.  Typically, the core developers recommend
creating a bug in bugzilla.gnome.org and attaching your patch to it.
I'm not a core dev, but I've submitted a few patches.  If it is in
bugzilla with a patch, they will get to it.

-- Trey

On 10/23/07, Steve Howard <dev gostevehoward com> wrote:
> Hi,
>
> Is this the place to send patches? I just started using Banshee and have
> been unable to import an m3u playlist at all.  Even for the simplest
> playlist, it would try to import the songs despite the fact that they were
> already in my library, and then fail to import them saying they were already
> in my library.
>
> I tracked down what I think is the problem and have attached a simple patch
> that fixes it for me.  Basically the m3u playlist reader returns URIs, and
> then the ImportPlaylistWorker compares these URIs to Paths of library songs
> (rather than URIs), which results in them always failing to match.  I
> changed it to use URIs for the library songs.
>
> This is basically my first time contributing to an open-source project, and
> my first time working in C#, so cut me some newbie slack :).  I also just
> made this fix as quickly as possible, without looking really closely at the
> structure of the code, so be warned.
>
> Steve
> _______________________________________________
> Banshee-list mailing list
> Banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list
>
>
>