Re: [Banshee-List] Current SVN doesn't build

[Brian Kerrick Nickel <brian nickel gmail com>]

Sorry about that. This one should work.

On Sun, 2007-06-03 at 18:38 +0100, Andrew Gee wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I've just run the patch and now receive this error when compiling...
> 
> ./Banshee.AudioProfiles/ProfileManager.cs(245,33): warning CS0168: The
> variable `profile' is declared but never used
> ./Banshee.AudioProfiles.Gui/ProfileConfigurationDialog.cs(368,26):
> warning CS0168: The variable `iter' is declared but never used
> ./FileTrackInfo.cs(52,62): error CS0234: The type or namespace name
> `TagLibVfsCreator' does not exist in the namespace `Banshee.IO'. Are you
> missing an assembly reference?
> ./DBusRemote.cs(43,34): warning CS0219: The variable `nameReply' is
> assigned but its value is never used
> 
> - --
> Andrew Gee
> andrew webspot co uk
> http://www.webspot.co.uk
> 
> GPG Key: http://webspot.co.uk/key.asc
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> 
> iD8DBQFGYvx5eE9nhbkYalgRAp22AKCFKYWMX8PdhNWyINxXDvvDFkDUaQCfSyKQ
> epk03oDzTXAWZqJh5ePX25A=
> =UGy5
> -----END PGP SIGNATURE-----
> _______________________________________________
> Banshee-list mailing list
> Banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list

Index: src/Dap/Banshee.Dap.Ipod/DatabaseRebuilder.cs
===================================================================
--- src/Dap/Banshee.Dap.Ipod/DatabaseRebuilder.cs	(revision 2295)
+++ src/Dap/Banshee.Dap.Ipod/DatabaseRebuilder.cs	(working copy)
@@ -114,7 +114,7 @@
         
         private void ProcessTrack(FileInfo file)
         {
-            TagLib.File af = TagLib.File.Create(file.FullName);
+            TagLib.File af = Banshee.IO.IOProxy.OpenFile(file.FullName);
             Track song = dap.Device.TrackDatabase.CreateTrack();
 
             song.FileName = file.FullName;
Index: src/Core/Banshee.Base/IO/IOProxy.cs
===================================================================
--- src/Core/Banshee.Base/IO/IOProxy.cs	(revision 2295)
+++ src/Core/Banshee.Base/IO/IOProxy.cs	(working copy)
@@ -58,9 +58,18 @@
             
             file = (IFile)Activator.CreateInstance(config.FileBackend);
             directory = (IDirectory)Activator.CreateInstance(config.DirectoryBackend);
-            TagLib.File.SetFileAbstractionCreator(TagLibVfsCreator);
         }
         
+        public static TagLib.File OpenFile(string file, string mimetype, TagLib.ReadStyle readStyle)
+        {
+            return TagLib.File.Create(TagLibVfsCreator (file), mimetype, readStyle);
+        }
+        
+        public static TagLib.File OpenFile(string file)
+        {
+            return TagLib.File.Create(TagLibVfsCreator (file));
+        }
+        
         private static TagLib.File.IFileAbstraction TagLibVfsCreator(string file)
         {
             return (IDemuxVfs)Activator.CreateInstance(config.DemuxVfsBackend, new object [] { file });
Index: src/Core/Banshee.Base/FileTrackInfo.cs
===================================================================
--- src/Core/Banshee.Base/FileTrackInfo.cs	(revision 2295)
+++ src/Core/Banshee.Base/FileTrackInfo.cs	(working copy)
@@ -49,7 +49,7 @@
             ParsePath(uri.LocalPath);
             track_id = 0;
    
-            TagLib.File file = TagLib.File.Create(uri.LocalPath);
+            TagLib.File file = Banshee.IO.IOProxy.OpenFile(uri.LocalPath);
    
             artist = Choose(file.Tag.JoinedArtists, artist);
             album = Choose(file.Tag.Album, album);
Index: src/Core/Banshee.Base/StreamTagger.cs
===================================================================
--- src/Core/Banshee.Base/StreamTagger.cs	(revision 2295)
+++ src/Core/Banshee.Base/StreamTagger.cs	(working copy)
@@ -83,7 +83,7 @@
                 }
             }
 
-            return TagLib.File.Create(uri.IsLocalPath ? uri.LocalPath : uri.AbsoluteUri, 
+            return Banshee.IO.IOProxy.OpenFile(uri.IsLocalPath ? uri.LocalPath : uri.AbsoluteUri, 
                 mimetype, TagLib.ReadStyle.Average);
         }