Re: [Banshee-List] Current SVN doesn't build

[Brian Kerrick Nickel <brian nickel gmail com>]

A full patch is attached. This should prevent breakage for any remote
directories you might have.

- Brian

On Sat, 2007-06-02 at 16:38 -0400, Igor Guerrero wrote:
> I confirm that. And I know that it happend because of the last days
> update of TagLib, it should be fine in the next couple of days(I
> hope).
> 
> But is you really need banshee from svn right now apply this "patch": 
> 
> Index: src/Core/Banshee.Base/IO/IOProxy.cs
> ===================================================================
> --- src/Core/Banshee.Base/IO/IOProxy.cs (revision 2294)
> +++ src/Core/Banshee.Base/IO/IOProxy.cs (working copy) 
> @@ -58,7 +58,7 @@
>              
>              file =
> (IFile)Activator.CreateInstance(config.FileBackend);
>              directory =
> (IDirectory)Activator.CreateInstance(config.DirectoryBackend);
> -            TagLib.File.SetFileAbstractionCreator(TagLibVfsCreator);
> +            //TagLib.File.SetFileAbstractionCreator(TagLibVfsCreator);
>          }
>          
>          private static TagLib.File.IFileAbstraction
> TagLibVfsCreator(string file) 
> 
> 
> 
> On 6/2/07, Will Farrington <wcfarrington gmail com> wrote:
>         Title says it all. Here's the error:
>         
>         ./IO/IOProxy.cs(61,25): error CS0117: `TagLib.File' does not
>         contain a
>         definition for `SetFileAbstractionCreator'
>         ./DBusRemote.cs(43,34): warning CS0219: The variable
>         `nameReply' is 
>         assigned but its value is never used
>         Compilation failed: 1 error(s), 1 warnings
>         make[4]: *** [Banshee.Base.dll] Error 1
>         make[4]: Leaving directory
>         `/home/will/Bin/banshee/src/Core/Banshee.Base'
>         make[3]: *** [all-recursive] Error 1 
>         make[3]: Leaving directory `/home/will/Bin/banshee/src/Core'
>         make[2]: *** [all-recursive] Error 1
>         make[2]: Leaving directory `/home/will/Bin/banshee/src'
>         make[1]: *** [all-recursive] Error 1
>         make[1]: Leaving directory `/home/will/Bin/banshee' 
>         make: *** [all] Error 2
>         
>         _______________________________________________
>         Banshee-list mailing list
>         Banshee-list gnome org
>         http://mail.gnome.org/mailman/listinfo/banshee-list
> 
> 
> 
> -- 
> :::lxuser 391715:::
> http://igordevlog.blogspot.com/ 
> _______________________________________________
> Banshee-list mailing list
> Banshee-list gnome org
> http://mail.gnome.org/mailman/listinfo/banshee-list

Index: src/Dap/Banshee.Dap.Ipod/DatabaseRebuilder.cs
===================================================================
--- src/Dap/Banshee.Dap.Ipod/DatabaseRebuilder.cs	(revision 2291)
+++ src/Dap/Banshee.Dap.Ipod/DatabaseRebuilder.cs	(working copy)
@@ -114,7 +114,7 @@
         
         private void ProcessTrack(FileInfo file)
         {
-            TagLib.File af = TagLib.File.Create(file.FullName);
+            TagLib.File af = TagLib.File.Create(Banshee.IO.TagLibVfsCreator (file.FullName));
             Track song = dap.Device.TrackDatabase.CreateTrack();
 
             song.FileName = file.FullName;
Index: src/Core/Banshee.Base/FileTrackInfo.cs
===================================================================
--- src/Core/Banshee.Base/FileTrackInfo.cs	(revision 2291)
+++ src/Core/Banshee.Base/FileTrackInfo.cs	(working copy)
@@ -49,7 +49,7 @@
             ParsePath(uri.LocalPath);
             track_id = 0;
    
-            TagLib.File file = TagLib.File.Create(uri.LocalPath);
+            TagLib.File file = TagLib.File.Create(Banshee.IO.TagLibVfsCreator (uri.LocalPath));
    
             artist = Choose(file.Tag.JoinedArtists, artist);
             album = Choose(file.Tag.Album, album);
Index: src/Core/Banshee.Base/IO/IOProxy.cs
===================================================================
--- src/Core/Banshee.Base/IO/IOProxy.cs	(revision 2291)
+++ src/Core/Banshee.Base/IO/IOProxy.cs	(working copy)
@@ -58,7 +58,6 @@
             
             file = (IFile)Activator.CreateInstance(config.FileBackend);
             directory = (IDirectory)Activator.CreateInstance(config.DirectoryBackend);
-            TagLib.File.SetFileAbstractionCreator(TagLibVfsCreator);
         }
         
         private static TagLib.File.IFileAbstraction TagLibVfsCreator(string file)
Index: src/Core/Banshee.Base/StreamTagger.cs
===================================================================
--- src/Core/Banshee.Base/StreamTagger.cs	(revision 2291)
+++ src/Core/Banshee.Base/StreamTagger.cs	(working copy)
@@ -83,7 +83,7 @@
                 }
             }
 
-            return TagLib.File.Create(uri.IsLocalPath ? uri.LocalPath : uri.AbsoluteUri, 
+            return TagLib.File.Create(Banshee.IO.TagLibVfsCreator(uri.IsLocalPath ? uri.LocalPath : uri.AbsoluteUri), 
                 mimetype, TagLib.ReadStyle.Average);
         }