Re: [Banshee-List] [Patch] speeding up "search by track"
- From: Patrick van Staveren <trick vanstaveren us>
- To: banshee-list gnome org
- Subject: Re: [Banshee-List] [Patch] speeding up "search by track"
- Date: Fri, 21 Jul 2006 13:09:26 -0400
Dominik,
Very cool - and a simple fix, too! I had always noticed this issue.
As with anything - especially patches like this which are ready to be
commented on to see whether they're good to commit - open a new bug on
bugzilla. (btw, don't re-use an old one). There's a handful of folks
like myself and Ruben who eat/breathe/sleep new patches on bugzilla
and we'll help make sure it gets in there. And of course, this makes
it easier for abock to keep track of what to commit.
Go ahead and file a bug unless abock/ruben is going to commit this one
right away :)
Good work!
Patrick
--
Patrick "Trick" van Staveren
http://trick.vanstaveren.us
----- Message from neptoon gmail com ---------
Date: Fri, 21 Jul 2006 10:40:00 +0200
From: Dominik Meister <neptoon gmail com>
Reply-To: banshee-list gnome org
Subject: [Banshee-List] [Patch] speeding up "search by track"
To: "ML, Banshee" <banshee-list gnome org>
Hi,
I'm the guy who provided the patch for BGO #333904 (searching based on a
track's metadata).
I noticed that this can be very slow when having a larger library due to
the fact that banshee tries to search after each character "entered" to
the search field.
I've attached a patch which speeds up the search by suspending the
OnSimpleSearch method until the whole search criteria has been "entered"
into the field.
I was not sure about posting this on the mailing list but it's only a
small 4-lines patch. If you prefer a bugzilla entry, should I open a new
bug or attach it to the original one (and reopen it)?
Thanks, Dominik
--
Dominik Meister <neptoon gmail com>
My public GnuPG key is available at http://meischter.homelinux.org/gpg.txt
----- End message from neptoon gmail com -----
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]