Re: [Banshee-devel-list] GStreamer Equalization support

[hixon alexander mediati org]

I actually started a bit of hacking on the equalizer component a few  
weeks back (see attached patch on  
http://bugzilla.gnome.org/show_bug.cgi?id=426562).

My GStreamer code is fairly messy, and your implementation is much,  
much cleaner. However, I would have liked to see equalizer-nbands,  
rather than equalizer-10bands, since it may be possible later to have  
equalizers with an adjustable number of frequency bands.  
g_object_set(G_OBJECT(engine->equalizer), "num-bands", 10, NULL); can  
be used to emulate the current implementation.

My code also has the added functionality to load preset values from  
the last session, enable/disable the equalizer, as well as hiding the  
menu item depending on if the GStreamer element can be found.

I too agree with Ivan, that the Banshee.Equalizer needs a bit of  
cleaning up, and that the actual values of the bands get stored in a  
neater way.

Hopefully the best bits of both patches can be merged, and then  
possibly work on the preamp started.

Quoting "Ivan N. Zlatev" <contact i-nz net>:

> I found out that an equalizer element has been commited in
> gst-plugins-bad [1], so I hacked on adding equalization support for
> that. In theory it should be working fine, but unfrotunatly with my
> glib here I get some weired !IS_GVALUE assertation failures. I have
> attached the patch if someone wants to give it a try and see if it
> works for them. There are still that need polishing in the Equalizer.*
> namespace, also some settings storing for the equalizer (enabled, load
> last active preset at startup). I hope I will have more time to hack
> on :-). In order for the equalizer to be activated one has to open
> View -> Equalizer. Check stdout/err for output.
>
> Regards.
>
> [1] cvs -d:pserver:anoncvs freedesktop org/cvs/gstreamer co gst-plugins-bad
>    in gst/equalizer
>
> --
> Ivan N. Zlatev
>
> Web: http://www.i-nZ.net
> "It's all some kind of whacked out conspiracy."

Regards,
Alex