Hi Jack: On 03/15/2020 04:35:22 PM Sun, Jack via balsa-list wrote:
On 2020.02.26 13:49, Albrecht Dreß wrote:Hi Peter! Thanks a lot for reviewing the patch! Am 26.02.20 17:27 schrieb(en) Peter Bloomfield:I'm testing it right now, with the toolbar item installed--good to see the red seal again! One comment: the ctrl-D accel key conflicts with Toggle:Deleted; which reminds me, we really should implement a shortcuts-window!Ouch, I missed that one… Any idea for a replacement? C, R, Ctrl-C and Ctrl-R are also occupied. Maybe Ctrl-Y (as “Y” appears in “crypt”), Ctrl-Alt-D? Thanks, Albrecht.Hello all, [sorry to not reply to the last in thread, but this is the only one I could find.] I just did my first recompile since this was committed, and it seems the Decrypt shortcut is Ctl-D. I don't actually remember the final decision of the discussion, but I thought some three key combo was going to be used. A plain "D" moves to trash. I personally preferred the old toggle:deleted, and only used move to trash for something I thought I might want back. Is there any way for me to map some key the toggle:deleted?
I believe we all agree that the decrypt shortcut needs to be changed; ctrl-Y is a leading candidate.
Also, it seems that Ctl-D still does toggle:deleted if Decrypt is not applicable to that message. Should it not do nothing in that case?
That's what happens when we have ambiguous shortcuts. If a message has no crypto, there's no ambiguity, so ctrl-D means toggle-deleted. If it /has/ crypto, ctrl-D is ambiguous, and somehow Decrypt gets priority. Best, Peter
Attachment:
pgpquGUiIhDUW.pgp
Description: PGP signature