Re: [Patch] unify wrapped label creation

Am 27.01.20 21:38 schrieb(en) Albrecht Dreß:
If I'm right (and I recognize a substantial probability that I'm wrong!-), we should just use the "xalign" 
property to make sure that the text is flush left (or occasionally flush right) in the space allocated to the widget.

Does that make any sense?

Yes, you're right, it does…  Actually it's easy to fix with the patch – just remove line 934 
“gtk_widget_set_halign(label, GTK_ALIGN_START);” in misc.c!

…or do not apply the patch, and everywhere where it would be used (i.e. libbalsa_create_wrap_label() would be 
called) add the xalign property.  I think the code simplification (one statement compared to three or four) 
outweighs the extra overhead (the call plus the bool compare), though.


Attachment: pgpI41w4F9pes.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]