Re: [Patch] Improve low-level network library, POP3 responsiveness on error

[Peter Bloomfield <PeterBloomfield bellsouth net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Albrecht,

On 01/20/2018 10:11:19 AM Sat, Albrecht Dreß wrote:
> Hi all,
>
> attached is a patch which improves the low-level network library, and should improve the responsiveness of 
> POP3 connections on error.
>
> For the network library, it introduces two new methods for shutting down the network connection, and for 
> checking the connection status.  The unit tests have been fixed, and the testing prerequisite ncat has been 
> replaced by a trivial Python script.
>
> For POP3 connections, on error the connection is now terminated without sending the QUIT command, as to avoid 
> a “hanging” connection while waiting for a reply or a timeout to it.
>
> As the patch modifies configure.ac, I guess the meson build stuff needs to be modified as well, but 
> unfortunately I don't know how (probably just removing the “sed_program” and “ncat_program” checks?).  It 
> would be great if someone with deeper insight could have a look at it.
>
> Opinions?

Thanks for the patch! Looks like a really useful modification to the shutdown sequence. Given the frequency 
of errors with certain POP3 servers, it should make a marked improvement.

Pushed to master, with a companion patch to make the corresponding changes in the meson build files.

Best regards,

Peter
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQS030wPRfNNA5alz3MfX9S1uSp09QUCWmOk/AAKCRAfX9S1uSp0
9adBAKCAw1ZowWoYDOViK1fVtkNscOD5IgCfTk7IJmO4zWVzNbCVeNoM4DoUPU4=
=NxFC
-----END PGP SIGNATURE-----