Re: [Patch] Crypto performance improvements

[Peter Bloomfield <PeterBloomfield bellsouth net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Albrecht,

On 02/12/2018 10:18:37 AM Mon, Albrecht Dreß wrote:
> Hi all,
>
> attached is a bigger patch which improves the performance of the GpgME crypto operations in Balsa.
>
> Basically, it delays loading the public key of a signature until the user actually wants to display (or 
> print) it.  As a consequence, the signature “traffic light” is now based entirely on GpgME's status.  Note 
> that this results in a small difference from the previous implementation, where the indicator was “green” 
> when both the signature validity and the key's owner trust were at least marginal.  With the patch, using the 
> default GpgME model, the key's owner trust must be one level higher (full) for a “green” signature.  However, 
> I think this approach is even better as it will (probably) show similar trust results as other MUA's.
>
> I also took the opportunity to re-factor some functions (inter alia now including the same key details in a 
> print-out as in the display widget), and to set the “crypto” log domain for the related source files.
>
> As always, any comment will be welcome!
>
> Cheers,
> Albrecht.

Thanks for the patch, and the efforts that went into it! Balsa builds and runs with it, so I've pushed it to 
master to allow wider testing.

I added a change to meson.build to bump the minimum gpgme version, and I updated the warning message in 
configure.ac to match the new minimum version.

Best,

Peter
-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQS030wPRfNNA5alz3MfX9S1uSp09QUCWoIeeQAKCRAfX9S1uSp0
9aNtAJ4hiBMYkOvQHk/Q54l5YGvmK4A3xACfcWL3+1PgMdQPC6w+w6bChja7jFs=
=ueJl
-----END PGP SIGNATURE-----