Re: Preparing for Gtk+ version 4



Hi Albrecht,

On 01/24/2017 04:14:45 PM Tue, Albrecht Dreß wrote:
Hi Peter:

Am 23.01.17 17:38 schrieb(en) Peter Bloomfield:
Reposting without the attachment--too big.

A common problem with this mailing list...

On 01/23/2017 11:34:03 AM Mon, Peter Bloomfield wrote:
I did try installing the .deb, using alien to convert it to a .rpm, but it looks like "dependency hell"--no 
automatic dependency resolution! Perhaps there's another GUI with a .rpm package...

Hmmm, "uncrustify --help" says:

---8<-----------------------------------------------------
There are currently 412 options and minimal documentation.
Try UniversalIndentGUI and good luck.
---8<-----------------------------------------------------

Here are the UniversalIndentGUI dependencies on my Ubuntu box, if this is helpful for you:

albrecht@deneb:~$ ldd $(which universalindentgui)
        linux-vdso.so.1 =>  (0x00007fff2199f000)
        libqscintilla2.so.12 => /usr/lib/libqscintilla2.so.12 (0x00007fcfe1e89000)

Yes, it was libqscintilla2 that stopped the install, and it just brought back memories of chasing down 
dependencies all night, so I quit!

        libQtScript.so.4 => /usr/lib/x86_64-linux-gnu/libQtScript.so.4 (0x00007fcfe19c6000)
        libQtGui.so.4 => /usr/lib/x86_64-linux-gnu/libQtGui.so.4 (0x00007fcfe0cd1000)
        libQtNetwork.so.4 => /usr/lib/x86_64-linux-gnu/libQtNetwork.so.4 (0x00007fcfe097c000)
        libQtCore.so.4 => /usr/lib/x86_64-linux-gnu/libQtCore.so.4 (0x00007fcfe0489000)

OK, that actually looks like a manageable list of Qt stuff, perhaps I'll try again...
...
With some tweaks to your config file, I got uncrustify doing a pretty good job. I believe the "add" options should mostly be "force", 
otherwise we could be left with some nonstandard formatting, like multiple spaces where one is required (e.g. between "if" and "("). And I 
set "align_var_def_star_style=2"; dangling stars, so that the variable names are aligned, similar to Gtk code. And a few other small tweaks.

Yes, that sounds good!
... but if I can get uncrustify doing a reasonable job with the CLI and no GUI, why bother?!

We need to have a discussion about hard tabs! I know it's still a controversial topic; personally, I don't 
like them, especially when tab stops are expected to be set every 4 places. Indentation can look different in 
vim, gedit, pasting into e-mail, and so on; eliminating them makes the indenting unambiguous. But opinions 
vary!

I fully agree with you that avoiding tabs makes everything a lot more portable.  Not sure if there is an 
option to replace tabs by spaces (I guess it is...).

There is:

 # 0=spaces only
 # 1=indent with tabs to brace level, align with spaces (default)
 # 2=indent and align with tabs, using spaces when not on a tabstop
-indent_with_tabs                = 1        # number
+indent_with_tabs                = 0        # number

I'll add the config file to the git tree so that we can all play with it and tweak it to our general 
satisfaction. On the current master tree, uncrustify gives build failures, but that's just some questionable 
conditional compilation that should be fixed anyway, and will go away in a gtk4 branch.

Best,

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]