Re: some regressions in current HEAD

[Pawel Salek <pawsa0 gmail com>]

On 07/01/2009 05:34:54 AM, Ildar Mulyukov wrote:
> On 01.07.2009 01:31:21, Pawel Salek wrote:
> > On 06/30/2009 09:04:21 PM, Ildar Mulyukov wrote:
> > > On 01.07.2009 00:57:29, Ildar Mulyukov wrote:
> > > > On 30.06.2009 23:00:48, Pawel Salek wrote:
> > > > > Could you please verify whether the attached patch fixes the  
> > > > > problems 1 and 2?
> > > >
> > > > Yes! The patch covers the problems 1 and 2. Thanks.
> > > ... But still it's not complete. The message where I wrote "Yes!  
> > > The patch covers the problems 1 and 2. Thanks." particularly  
> > > suffers from the problem #1.
> > > #2 is really OK.
> >
> > I guess I will need again a detailed scenario to reproduce it...
>
> Yeah, sure. I'm sorry I didn't it yesterday. Just it was too late.  
> Here it is:
> 1. Take my letter from this thread dated 01.07.2009 00:57:29 GMT+6  
> and copy it to Drafts.
> 2. Double-click the copied message.
> 3. Remove the signature in the end of the letter.
> 4. Ctrl+G to insert your own.
> 5. Change ids and see what happens.
>
> Hope it would show the problem.

Yes, it does! The key action here is that one edits the draft. Frankly,  
I do not know how balsa should really behave. We have a settings  
controlling automatic signature insertion, signature insertion when  
editing a reply and when forwarding a message... What should happen  
when we continue writing a draft?

I am leaning towards a solution that if the message contained the  
signature before switching the identity of the sender, it will have the  
signature replaced with the signature of the new identity. Would you  
call it a consistent behaviour?

Pawel