Re: Some reply bugs [was Re: New mails in mailboxlist]

[Peter Bloomfield <peterbloomfield bellsouth net>]

On 06/07/2005 03:51:30 PM Tue, Misu Moldovan wrote:
[ snip ]
> I've been able to reproduce the problem with the official Balsa  
> 2.3.0 package from Debian 3.1r0 Sarge too if the locale  
> settings are set to ro_RO.ISO-8859-2 (with ro_RO.UTF-8  
> everything is just fine). I think I know what causes it too...  
> Your mail was written in a Saturday, which in Romanian locale  
> settings is "Sîmbătă", short form "Sî". This short form is  
> missing from the "Date" field in the mailbox view and replying  
> to such a mail is not really possible, I get an empty window  
> when trying to reply :(

Good work!  The short form date wasn't in my prefs, so the bug  
didn't show itself.  A simple matter of converting the formatted  
date from the locale charset to utf-8...patch attached.  If it  
fixes things for you, I'll commit it to cvs.

> I'm also aware of another nasty bug when replying... If you  
> save repeatedly a reply when composing in Balsa's composer  
> window, the mail loses the In-Reply-To header. To replicate it  
> reply to a mail, save it once, look at the source of the draft,  
> notice the In-Reply-To header, then save one more time and look  
> again at the draft. The In-Reply-To header is gone.
>
> If needed, I may fill the bug reports in Bugzilla and test for  
> the fixes, I'll try to be as responsive as possible.

Thanks--I'll look into that one--more later.

Best,

Peter

Index: libbalsa/libbalsa.c
===================================================================
RCS file: /cvs/gnome/balsa/libbalsa/libbalsa.c,v
retrieving revision 1.98
diff -u -r1.98 libbalsa.c
--- libbalsa/libbalsa.c	6 Jun 2005 16:48:36 -0000	1.98
+++ libbalsa/libbalsa.c	7 Jun 2005 20:48:47 -0000
@@ -355,7 +355,7 @@
 
     strftime(rettime, sizeof(rettime), date_string, &footime);
 
-    return g_strdup(rettime);
+    return g_locale_to_utf8(rettime, -1, NULL, NULL, NULL);
 }
 
 LibBalsaMessageStatus