Re: filters no-worky?

[Pawel Salek <pawsa theochem kth se>]

On 02/26/2005 03:10:41 AM, Kacper Wysocki wrote:
> [snip]
> I've got a succession of builds available- one that works from Feb  
> 20th and one where filtering's broken from Feb 23rd. The following is  
> the only likely changelog item to have caused the problem:
>
> 2005-02-23  Pawel Salek
>
> 	* NEWS: release 2.3.0
> 	* libbalsa/mailbox_local.c: fix one of the problems with msg  
> filtering.
>
> ... which could mean that filtering is broken in the 2.3.0 release. I  
> have rolled back the change, and can confirm that it fixes the  
> problem.
>
> Although I have little understanding of what's actually going on in  
> the patch, and what problem it's fixing (could it be the previously  
> discussed filter application slowness?), reversing the attached
> (cvs diff -D "Feb 22" libbalsa/mailbox_local.c) makes filters work  
> for me again.
> Index: libbalsa/mailbox_local.c
> ===================================================================
> RCS file: /cvs/gnome/balsa/libbalsa/mailbox_local.c,v
> retrieving revision 1.129
> retrieving revision 1.130
> diff -u -r1.129 -r1.130
> --- libbalsa/mailbox_local.c	7 Feb 2005 01:43:54
> -0000	1.129
> +++ libbalsa/mailbox_local.c	23 Feb 2005 08:21:37
> -0000	1.130
> @@ -414,7 +414,8 @@
>                  match = libbalsa_utf8_strstr(entry->from,
>
> cond->match.string.string);
>              else {
> -                g_return_val_if_fail(message, FALSE);
> +                g_return_val_if_fail(!message, FALSE);
> +                message = libbalsa_mailbox_get_message(mailbox,
> msgno);
>                  str =
>                       
> internet_address_list_to_string(message->headers->
>                                                      to_list, FALSE);

When the filtering was done on the TO field exclusively, one got  
critical warnings in the removed g_return_Val_if_fail()... But I see a  
problem when one tries to filter on both CC and TO.

Would it be OK to replace the code there with:

       else {
            if(!message)
                message = libbalsa_mailbox_get_message(mailbox,msgno);
            str = internet_address_list_to_string(message->headers->


?

Pawel