Re: [BUG+PATCH] address entry, vcard utf8 fixes

On 11/03/2004 01:30:13 PM, Albrecht Dreß wrote:
Hi all,

below is a small patch to address two utf8 related problems in Balsa CVS.

(1) When reading badly formed VCARD entries, it was not guaranteed that the name and/or nickname were actually converted from the system locale to utf8. The patch to libbalsa/address-book-vcard.c fixes this (and cleans up the code a little bit).

That sounds useful!  (Can't get into the attachment right now...)

(2) The address entry widget simply doesn't accept any national chars and throws pango errors when trying to enter one. The reason is the use of the (depracted) GdkEventKey::string for libbalsa_keystroke_add_key() in libbalsa/address-entry.c. The patch now uses GdkEventKey::keyval and converts it properly from ucs4 to utf8.

Ouch! I didn't know you were working on that...I just committed to cvs a rewrite of the address-entry widget, using GtkEntryCompletion, which avoids all that low-level keystroke stuff. The code your patch affects is still there, but it will now be compiled by default only in pre-gtk-2.4 trees.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]