Re: question about the NEW and REPLIED flags

[Bart Visscher <magick Linux-Fan com>]

On Sat, 01 Mar 2003 16:38:38 Magick wrote:
> On Sat, 01 Mar 2003 16:08:54 Pawel Salek wrote:
>> On Sat, 1 Mar 2003, Bart Visscher wrote:
>> > Also hen trying to split the LIBBALSA_MESSAGE_FLAG_NEW flag, I noticed
>> > this in filter.c:
>> > 	case CONDITION_FLAG:
>> > 	    /* NOTE : nothing about replied flag in the IMAP protocol,
>> > 	       so continue if only this flag is present */
>> > 	    if (!(cond->match.flags & ~LIBBALSA_MESSAGE_FLAG_REPLIED))
>> > 		continue;
>> >
>> > But looking at rfc2060 I find this:
>> >          \Answered   Message has been answered
>> >
>> > Should that be changed?
>> >> True: the comment in the code is false.
> I'll make a patch for it.
I have not checked it, but it is relatively simple.
-- 
When a guy says "the last thing I'd wanna do is hurt you" it just means
he's gotta do other things first.
Fingerprint = CD4D 5601 287D F075 6F96  6157 99F9 E56A 4B08 6D06
--- balsa-cvs-arch/libbalsa/filter.c	2003-02-26 19:57:32.000000000 +0100
+++ balsa-replied/libbalsa/filter.c	2003-03-01 16:48:00.000000000 +0100
@@ -408,10 +408,8 @@
 	    g_string_prepend(buffer, "NOT ");
 	    break;
 	case CONDITION_FLAG:
-	    /* NOTE : nothing about replied flag in the IMAP protocol,
-	       so continue if only this flag is present */
-	    if (!(cond->match.flags & ~LIBBALSA_MESSAGE_FLAG_REPLIED))
-		continue;
+	    if (cond->match.flags & LIBBALSA_MESSAGE_FLAG_REPLIED)
+		extend_query(buffer, "ANSWERED", NULL);
 	    if (cond->match.flags & LIBBALSA_MESSAGE_FLAG_NEW)
 		extend_query(buffer, "NEW", NULL);
 	    if (cond->match.flags & LIBBALSA_MESSAGE_FLAG_DELETED) {