pop3 - "Fatal error!" status ?

[Carlos Morgado <chbm chbm nu>]

What is the status of this problem ? the current code in cvs leaks and it's
ugly. I lost track of what works for who. Does

--- mailbox_pop3.c	2001/09/06 09:03:55	1.28
+++ mailbox_pop3.c	2001/09/07 17:17:10
@@ -293,21 +293,17 @@
 	return;
     }	
     libbalsa_mailbox_open(tmp_mailbox);
-    /* chbm: fixme - make this more linear */
-    if((m->inbox) && (tmp_mailbox->messages)) {
-	if(libbalsa_messages_move(tmp_mailbox->message_list, m->inbox)) {    
-	    unlink((const char*)tmp_path);
-	} else {
-	    libbalsa_information(LIBBALSA_INFORMATION_WARNING,
-				 _("Error placing messages from %s on %s\n"
-				   "Messages are left in %s\n"),
-				 mailbox->name, 
-				 LIBBALSA_MAILBOX(m->inbox)->name,
-				 tmp_path);
-        libbalsa_mailbox_close(LIBBALSA_MAILBOX(tmp_mailbox));
-	}
+    if((m->inbox) && (tmp_mailbox->messages) &&
+	!libbalsa_messages_move(tmp_mailbox->message_list, m->inbox)) {    
+	libbalsa_information(LIBBALSA_INFORMATION_WARNING,
+			     _("Error placing messages from %s on %s\n"
+			       "Messages are left in %s\n"),
+			     mailbox->name, 
+			     LIBBALSA_MAILBOX(m->inbox)->name,
+			     tmp_path);
+	libbalsa_mailbox_close(LIBBALSA_MAILBOX(tmp_mailbox));	
     } else {
-    libbalsa_mailbox_close(LIBBALSA_MAILBOX(tmp_mailbox));
+	libbalsa_mailbox_close(LIBBALSA_MAILBOX(tmp_mailbox));
 	unlink((const char*)tmp_path);
     }
     gtk_object_destroy(GTK_OBJECT(tmp_mailbox));	

work for you ? peter ? melanie ?

-- 
Carlos Morgado - chbm(at)chbm(dot)nu - http://chbm.nu/ -- gpgkey: 0x1FC57F0A
http://wwwkeys.pgp.net/ FP:0A27 35D3 C448 3641 0573 6876 2A37 4BB2 1FC5 7F0A
Software is like sex; it's better when it's free. - Linus Torvalds