Fwd: Re: PATCH: anti memleak part 3 [ali akcaagac stud fh-wilhelmshaven de]



On 2001.10.18 19:02:23 +0200 Peter Bloomfield wrote:
> >  /* Check all mailboxes in a list
> > @@ -1568,6 +1569,8 @@
> > 
> >          list = g_list_next(list);
> >      }
> > +
> > +    g_list_free (list);
> >  }
> > 
> >  /*Callback to check a mailbox in a balsa-mblist */
> 
> These `g_list_free (list)'s aren't a good idea.  The argument `list' is 
> always NULL on exiting a loop like this, and `g_list_free(NULL)' is a 
> no-op.  You also don't want to free the list that you've just 
> traversed, because it's `balsa_app.inbox_input', and you'll be wanting 
> that later!

lemme check this up again..

-- 
Name....: Ali Akcaagac
Status..: Student Of Computer & Economic Science
E-Mail..: mailto:ali.akcaagac@stud.fh-wilhelmshaven.de
WWW.....: http://www.fh-wilhelmshaven.de/~akcaagaa



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]