Re: Balsa command line attachement patch

["W. Michael Petullo" <mike flyn org>]

>>> I would like to resubmit the patch to you which allows one to specify
>>> an attachment on the command line, in addition to a recipient.  My
>>> patch adds a -a or --attach option which takes paths as an argument.
>>> ``balsa -a /foo/bar'' and ``balsa --attach=/foo/bar,/foo/baz'' are two
>>> examples of my patch's use.

>> The patch is OK apart from the choice of the separator character: comma
>> is a legal character in Unix file name and is used to mark version of
>> the file (CVS, RCS). I think ';' would be better. Even better solution
>> would be to allow multiple '-a' options...

> No!  Not ;!  ; is th command seperator.  One might do something like
> balsa --attach=/foo/bar;sendmail -q.
>
> For this reason, a ; would be a very bad choice.  I think the multiple
> -a/--attach option is much better...

Yes, I agree that multiple -a options would be best.  I did not use this
method in my patch because the infrastructure did not seem to be in the
command line parsing code.  However, now that it seems my patch will be
accepted, I will take the time to implement it this way.

On a related note, I have not done much GNOME development.  How do
I generate a configure script for the Balsa code I get out of CVS?
My regular `aclocal; autoconf; autoheader; libtoolize --force; automake`
returns the following errors:

aclocal: configure.in: 49: macro `AM_ACLOCAL_INCLUDE' not found in library
aclocal: configure.in: 103: macro `AM_PATH_GNOME_PRINT' not found in library
aclocal: configure.in: 117: macro `AM_GNU_GETTEXT' not found in library
autoconf: Undefined macros:
configure.in:104:       AC_DEFINE(HAVE_GNOME_PRINT)
configure.in:130:AC_DEFINE_UNQUOTED(BALSA_MAJOR, $BALSA_MAJOR)
configure.in:131:AC_DEFINE_UNQUOTED(BALSA_REVISION, $BALSA_REVISION)
configure.in:132:AC_DEFINE_UNQUOTED(BALSA_PATCHLEVEL, $BALSA_PATCHLEVEL)
configure.in:133:AC_DEFINE_UNQUOTED(BALSA_VERSION, "$BALSA_VERSION")
configure.in:200:       AC_DEFINE(BALSA_SHOW_ALL)
configure.in:218:       AC_DEFINE(BALSA_MDN_REPLY)
configure.in:241:               AC_DEFINE(BALSA_USE_THREADS,1)
configure.in:243:               AC_MSG_ERROR([Balsa requires GThread from GLib
+to use threading.])
configure.in:263:       AC_CHECK_LIB(ldap, ldap_search, AC_DEFINE(ENABLE_LDAP)
+LIBS="-lldap -llber $LIBS", AC_MSG_ERROR([*** You enabled LDAP but ldap library
+is not found.]), -llber)
configure.in:298:               AC_DEFINE(HAVE_GTKHTML)
configure.in:318:       AC_DEFINE(USE_PIXBUF)
configure.in:379:AC_DEFINE_UNQUOTED( BALSA_STD_PREFIX, "$BALSA_STD_PREFIX" )
configure.in:380:AC_DEFINE_UNQUOTED( BALSA_DATA_PREFIX, "$BALSA_DATA_PREFIX" )
configure.in:381:AC_DEFINE_UNQUOTED( GNOME_STD_PREFIX, "$GNOME_STD_PREFIX" )
configure.in:382:AC_DEFINE_UNQUOTED( GNOME_LIB_PREFIX, "$GNOME_LIB_PREFIX" )
configure.in:383:AC_DEFINE_UNQUOTED( GNOME_DATA_PREFIX, "$GNOME_DATA_PREFIX" )
configure.in:384:AC_DEFINE_UNQUOTED( BALSA_COMMON_PREFIXES, `echo
+$BALSA_COMMON_PREFIXES` ) dnl bleah
configure.in:394:               AC_MSG_ERROR([As a CVS user, you need to get gob+to build Balsa. It is available from Gnome CVS in the module 'gob'])
configure.in:412:       AC_CHECK_LIB(esmtp, smtp_start_session,
+AC_DEFINE(ENABLE_ESMTP) LIBS="$LIBS -lesmtp", AC_MSG_ERROR([*** You enabled
+ESMTP but esmtp library is not found.]), -lesmtp)
configure.in:466:                       AC_MSG_ERROR([*** You need iconv for
+libmutt.])
configure.in:53:        AC_MSG_ERROR([You need GLib installed -- GNOME requires
+this as well.])
configure.in:69:        AC_MSG_ERROR([*** libpspell not found.  Pleas check
+http://www.balsa.net for information on the required files.])
configure.in:86:                        AC_MSG_ERROR([Balsa requires a version
+of gnome-libs newer than 1.2.1] )
You should add the contents of `/usr/share/aclocal/libtool.m4' to `aclocal.m4'.
automake: configure.in: required file `./install-sh' not found
automake: configure.in: required file `./mkinstalldirs' not found
automake: configure.in: required file `./missing' not found
automake: Makefile.am: required file `./COPYING' not found
configure.in: 117: required file `./ABOUT-NLS' not found
macros/Makefile.am:33: INSIDE_GNOME_COMMON does not appear in AM_CONDITIONAL
libbalsa/Makefile.am:66: @LIBOBJS@ seen but never set in `configure.in'
src/Makefile.am:72: variable `GNOME_LIBDIR' not defined
src/Makefile.am:72: variable `GNOMEUI_LIBS' not defined
src/Makefile.am:72: variable `INTLLIBS' not defined
src/Makefile.am:72: variable `PTHREAD_LIB' not defined
src/Makefile.am:72: variable `GNOME_PRINT_LIBS' not defined

Thanks!

-- 
Mike

:wq