Re: Balsa command line attachement patch



> > I would like to resubmit the patch to you which allows one to specify
> > an attachment on the command line, in addition to a recipient.  My
> > patch adds a -a or --attach option which takes paths as an argument.
> > ``balsa -a /foo/bar'' and ``balsa --attach=/foo/bar,/foo/baz'' are two
> > examples of my patch's use.
> 
> The patch is OK apart from the choice of the separator character: comma
> is a legal character in Unix file name and is used to mark version of
> the file (CVS, RCS). I think ';' would be better. Even better solution
> would be to allow multiple '-a' options, I believe it is possible with
> the popt library. Would you mind having look at it? I would truly
> appreciate it (and all the balsa users as well, I guess).

No!  Not ;!  ; is th command seperator.  One might do something like
balsa --attach=/foo/bar;sendmail -q.

For this reason, a ; would be a very bad choice.  I think the multiple
-a/--attach option is much better.  Much like using multipl -I switches for
multiple include directories.

-- 

Daniel Foster - daniel@34SP.com




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]