Re: New command line attachment patch



I've never used this functionality, so I'm not familiar with the 
issues. One comment: isn't

-    if (balsa_app.compose_email || balsa_app.attach_file) {
+    if (balsa_app.compose_email || 
g_slist_length(balsa_app.attach_file)) {

overkill? Why go to the trouble of computing the length of the GSList, 
if all you need to know is whether it's nonempty?

      if (balsa_app.compose_email || balsa_app.attach_file) {

should continue to work just fine!



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]