Re: pending patch

[Pawel Salek <pawsa TheoChem kth se>]

(I apologise for sending prematurely an unfinished version).

I have some comments on the balsa-filing4.patch. I am about to commit it
with some changes summarized below:

1. g_malloc result need not be checked, it never fails. g_malloc() will
abort entire program on out of memory exception.

2. do not use tabs for indentation. There has been a hot discussion on
gnome-devel about indentation depth (which is pretty much arbitrary,
IMO) but everybody agreed that using tabs for saving few characters is
evil.

http://mail.gnome.org/archives/gnome-devel-list/2001-August/msg00025.html

3. folder_mru integrity. I did not like the style the
balsa_app.folder_mru integrity was achieved. The integrity should be
assured when folder_mru or mailbox_nodes are modified, not when
folder_mur is accessed. No folder should end up on folder_mru when it
does not exist in mailbox_nodes. When a folder is removed from
mailbox_nodes, it should be removed from folder_mru as well. (there was
a function creating menu from folder_mru - but it also modified
folder_mru when it could not find given mailbox).

4. do not make symbols global when they are really local
(FOLDER_MRU_LENGTH). Prefer const int to #define.

Cheers,

Pawel

On 2001-08-25 15:31 M . Thielker wrote:
> Hi,
> 
> On 2001.08.25 12:21 christophe barbe wrote:
> > Is there a reason to not commit this patch ?
> > Is there a more recent version of it ?
> 
> 4 is the current version, there appears to be no need to make any
> changes, I
> consider it final. The attached patch is updated fpr current CVS.
> 
> Melanie
>