Re: size/lines clist initialisation fix.



On 2001.08.13 17:17:19 +0200 Maciej Golebiewski wrote:
> >[figure 1]
> >
> >.----------------------------------------------------------------------.
> >| # | S | A | From | Subject | Date | Size                             |
> >`----------------------------------------------------------------------'
> ><------------------------ 640 pixels ---------------------------------->
> 
> OK, I see your point now. Right, I did not think about such effect.

no problem :) that's why open source is good for, we could all help
each other and make something good more perfect.

> >another example would be, the windowmanager, lets say you run some
> >apps, and you wonder why you get some BIG fileselectorboxes with
> >OK, CANCEL and whatever buttons you have they are soo damn big that
> >you could press them beeing 20 meters away from your monitor now go
> >to this window, and shrink it.. also the elements are getting shrinked
> >dynamically.
> 
> The question is why they were so big in the first place? Maybe because
> they were hardcoded to look nice on a monitor with hi res and small
> diagonal? :)

no, the filedialog or otherdialog are getting the parent mainwindow
structure passed by, so, if the gnome main window has a size of 1024x786,
then by passing the structure over to it's child (in this example dialogs)
they get the same dimensions. depending on the windowmanager too. now that
the dialogs are totally dynamic (all elements inside are selfattaching)
they change dimensions too. we had such discussions about dimensioning
and positioning for a couple of years with 'motif' this discussion never
ends and books are written about this :)

> >i've added the 6th case, otherwise we may run in default on worst
> >case.
> 
> OK. Thanks for fixing the gotchas. Just one remark: this code (case 6)
> is  relevant only when storing the size width in preferences. The
> original patch wasn't doing this and so the code was not needed then.

yeah sure. but now i think it's quite reasonable and satisfy balsa's other
code and style and for the sake of correctness.

i hope pawel is going to commit "this patch" and "the 'size vs. lines' patch"
to the CVS so i could work with clean mind on this 'trashcan full/empty' patch.
i don't want to pollute the mailinglist with tons of different patches.

-- 
Name....: Ali Akcaagac
Status..: Student Of Computer & Economic Science
E-Mail..: mailto:ali.akcaagac@stud.fh-wilhelmshaven.de
WWW.....: http://www.fh-wilhelmshaven.de/~akcaagaa




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]